From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F565C4338F for ; Wed, 28 Jul 2021 23:48:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0FFA6103B for ; Wed, 28 Jul 2021 23:48:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232800AbhG1XsT convert rfc822-to-8bit (ORCPT ); Wed, 28 Jul 2021 19:48:19 -0400 Received: from mga18.intel.com ([134.134.136.126]:51286 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232641AbhG1XsS (ORCPT ); Wed, 28 Jul 2021 19:48:18 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10059"; a="199988469" X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="199988469" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2021 16:48:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="464860836" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 28 Jul 2021 16:48:16 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 28 Jul 2021 16:48:15 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 28 Jul 2021 16:48:14 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2242.010; Wed, 28 Jul 2021 16:48:14 -0700 From: "Luck, Tony" To: Sean Christopherson , "Hansen, Dave" CC: Jarkko Sakkinen , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages Thread-Topic: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages Thread-Index: AQHXg/G3voDWmDqCq06DL34grJaPratZaKWA//+WanCAAHqDAIAABZsA//+MGqA= Date: Wed, 28 Jul 2021 23:48:14 +0000 Message-ID: References: <20210719182009.1409895-1-tony.luck@intel.com> <20210728204653.1509010-1-tony.luck@intel.com> <20210728204653.1509010-2-tony.luck@intel.com> <17054ca5-0ef7-4b28-ab26-b1b96aa7403f@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - epc_page = sgx_alloc_epc_page(NULL, true); > + epc_page = sgx_alloc_epc_page(va_page, true); Providing a real value for the owner seems much better than all the hacks to invent a value to use instead of NULL. Can you add a "Signed-off-by"? Then I'll replace my part 0001 with your version. -Tony [Just need to coax you into re-writing all the other parts for me now :-) ]