From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB6F8380FEE for ; Tue, 4 Aug 2026 18:08:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785866893; cv=none; b=YsIWo+gL4CKml5b0zwgdqPI0O8ods90HOkrYWhF6lsBV3h72tcKqRM/bofkRXY/kJVokjr4P0FB/orlzBNZRY9HcT1eFVnoXFyST07s6bIQB8NcxYtxlAVjsSoiy5jwNs562uc9ECDuraC18EyGUF1zUz4+SkmSa4Es5uYmpPqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785866893; c=relaxed/simple; bh=p402t6s4dsATom6C//ZA3V0XuQ2KGU4ByQP7LL1aEl8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ft+cAFXZxTA8iFK15bX96VR5LRVK/hdiM4tts3UaLYH3A7fsUWdrsXOYggxaN9lwvDsdIOLkgoHcaCap7o33Qr/dFA+v5ep+PffpP772li3hNFIrwK8+HMZHUf/q902xjEfPEgou+WpMHqx9addh5R0rHiVFVcxdcK/k3IrujI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o/rLauv3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Hpagcymk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o/rLauv3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hpagcymk" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 674H3PKc404513 for ; Tue, 4 Aug 2026 18:08:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GU1YtUDGbsfxTlijAya+pOjBIhU0+IZyXpQLGX6+QZc=; b=o/rLauv3GaIsBjcx /uTgzvuU3kdMD3n6mT6NJbQU/cw8fHHY/QbTVehsDSdEAcF9ORRT+aQ3CqMzksn8 kowqJPHoVobbZczkeSYcT9aBaREraZQI4u2T1zdFB3vYYOPw95yy1F2u5AZAistC A0HQXm1mO0/W/sHunI/80kPWpgRDRdOr5qqSTxoimsxeK4WEV61D3tQPM9ZdY/BA IBaxuYxLJUO8JXes8oqHIigPyd40NcSDsn1qNNG6QnQrhl++mlI8jwdTi3KNi847 fkcIWGi/npiVs3HWC9jEO6SOEPhDPakfq3CG1xZzGcZbObJbQTjR+a8wpJtippip WuBxuw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fum56gakb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 18:08:10 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-ca124bf0189so1013101a12.0 for ; Tue, 04 Aug 2026 11:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785866890; x=1786471690; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GU1YtUDGbsfxTlijAya+pOjBIhU0+IZyXpQLGX6+QZc=; b=HpagcymkPPaoRLtH/uE/cKTzCRu8uJyzDjE+JGhDDQiP+qrT0NLm9183hAxnVkJwbM LnbjrI3yGjviQdqowBlcQ5zgKx4MpAnOcFGJ23NAMkxeDJmlzclNnDM3ITpdkUhwJPKg dXmottWSy4jRNpVrZKxdAJUn7K+0sejXzOqgRwj6i2jWiSA/hApB/R6L1A0foe/1on4J 2BgYMVLqmeh2cStv9HcVZHCkILbOvPIjlRhKFROgxmWlhYRdcQ7mLOfGUPjUteZgh/f4 kyQ6QLi+5Bq0vnoUuLnes9CHJxTTpa4j4eC5rw/RJceAtAzTAZWgvZAppJoiln0lY0ha DjrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785866890; x=1786471690; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GU1YtUDGbsfxTlijAya+pOjBIhU0+IZyXpQLGX6+QZc=; b=kSicesjsBksgeL3eggjY3ZmoCP05yZloxwnpGDfHMtQ4NQXfw4FPwHb4zu54ZVJ87l IX5bZFSatnTpf/FZ17LpXOdGpxF7RSCl0bV6RSjZAn4vMF3clxeH/L4+Einx5Ztuj1nK 3bAAC1Pn33Gba+MlSPHQDOWC19BL/mUttVDywo+KTIpDD3dZBGqmt1SDTO4sMSJhBoxk gVOpsqYbfbM/irmq+D+QHGwFP5l/eFMcbh4AEBZPXMl1ZbF3dJpN4wuaXFrTJRN/GahA FeH3MGIuRMpYE1FTnR4Mqfj20Iw5iZG9yQyNgbRfnDO4ID7NG4kIlXdhl8Q1Vb8iH5Mm lwGA== X-Forwarded-Encrypted: i=1; AHgh+RpmJsMpVrpDb3luawb7i+7xwnnbY51zc5/vNgrFJWirKuXMgnQgEAXReGftdiuskt1b6d340EdHFNkO5Qo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/7de6csfGnefoCoslxqNFeAWJK6/d9p0qb4zQjj+uHEoyRS3n saF8+GZEDR0eSsZzzioGPIPw1z8EUWh8pL0rX2t1FCX+ugaCCkqFD3+vT8UzbCcGXEGB+w03Jpp T1qNjkp/cmbF9Ti/8mv9CGgNBMR4lHe0S9RT3CjldF8x1xFXEZ28GQwNX0ndmkjJretA= X-Gm-Gg: AR+sD12fsqAFFyYXDppECuE3gQP7YfgGCXeuMD3GYpPB9eijfs6+92DYNnjXzfoDva3 X2daMFm6E5daQ9EXoBbzI9wEB2tNPyHZMRBQvlAWYw9U/aNQJEF5Hsxryfd2s+ODFQkOYR6RUqn cb5eRO4joOGbIZMfOxf4GygtYrzVRHEAv8vfy028PgcOStxmOzBJJRJqkrvLHovo4+s4TKkseJL k0oL9AZjoFVCq4c3r24Lszghiv+80I9WhA5TKYy4n3p5R7/OMdLCyd53GqoDI9RUGcEpcI/jEC1 aiHQgQhK2yD97S8TgCTpLS7koKaFU8OaLQ+leHvkv0P4EP3SbU44wi7ZIqdgi4AcvPLs+DFHJgA oLlcEDMjsoJ6RMmTZakmkp2H+Th/Mf64u9w== X-Received: by 2002:a05:6a21:6906:b0:3bf:b7e8:68ab with SMTP id adf61e73a8af0-3cb6c752d6dmr5609274637.2.1785866890333; Tue, 04 Aug 2026 11:08:10 -0700 (PDT) X-Received: by 2002:a05:6a21:6906:b0:3bf:b7e8:68ab with SMTP id adf61e73a8af0-3cb6c752d6dmr5609227637.2.1785866889874; Tue, 04 Aug 2026 11:08:09 -0700 (PDT) Received: from [192.168.1.8] ([106.222.234.41]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315863b0a9csm9922859eec.2.2026.08.04.11.08.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 11:08:09 -0700 (PDT) Message-ID: Date: Tue, 4 Aug 2026 23:38:04 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 05/14] i3c: Make dev->desc locking assumptions explicit To: Adrian Hunter , alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, akhilrajeev@nvidia.com, rafael@kernel.org, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org References: <20260804133810.184905-1-adrian.hunter@intel.com> <20260804133810.184905-6-adrian.hunter@intel.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260804133810.184905-6-adrian.hunter@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: X6zIgYNiAWSzbUA59tZptzHWGa380mGH X-Authority-Analysis: v=2.4 cv=Co+PtH4D c=1 sm=1 tr=0 ts=6a722a8a cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=/lQgZcjXNA7ZrIsIl4Cfeg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=RYwuQet4LqFKJ_N4TO4A:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDE0NiBTYWx0ZWRfX70EdsLUvrBNy 99JEMmuhptZCy17siw8eBCdCSDEEhW5H7Joi2QWWLhFVv3GJz5pHZ+0hkxHhOcxxiVekJAZ56IK /iyNcDDs04zUryxz8sGGIuOX8ytRv44= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDE0NiBTYWx0ZWRfX7T4mawaNvrYX +mPNGMbXupdqARj5CEETN8cJUSkXufYLf4foue5rCUUy15ecBKAdrCYzTWNpGD0/cVD77tfkmV0 4QcBVs/V38UhBnrRFvmTZ8lGtofBeP1hLt9zzg8XuNLtim4kpb1HpDTXVBajKmi49dkKdht7ZcG KuCQ0nkBiVDAEal5e3OQeUQDEg/EWlXTTKxBAehILy9cFug5bCiOoKnqJETt1CPXWToFcYPkCQJ mlmVX07NhoeOpTPd+4DQBTaM4LRKT195yZ5fEURYzXCNXW1Ds1Vzwg2PR/ISy/BK2DhI8BFUjCC H0rLY1GV8uifH2Rwdjgfyrg6VtbfbqFIGwuRKgwswQRB0Nnc2V2akKctxLNf/SKnVsuiorbwsR5 D/fdFmFtMl9Hxd0colupTK9brGF2HdGNjq5Nw12SaE0VMD5LSP1f4CgcyBMhdJtHt/adSyyasWM 4ijOErwQ39ycuopt+Ew== X-Proofpoint-GUID: X6zIgYNiAWSzbUA59tZptzHWGa380mGH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_03,2026-08-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040146 On 8/4/2026 7:08 PM, Adrian Hunter wrote: > i3c_device_get_info() takes the bus normal-use lock before accessing > dev->desc. Under that lock, the descriptor pointer is guaranteed to be > valid for the duration of the access. > > Remove the unnecessary NULL check on dev->desc so the code more clearly > reflects the locking rules and expected descriptor lifetime. > > Signed-off-by: Adrian Hunter > --- > > > Changes in V3: > > New patch > > > drivers/i3c/device.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c > index a3778282e84c..5e6df6de0283 100644 Acked-by: Mukesh Savaliya