From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012063.outbound.protection.outlook.com [40.107.200.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66EED38E12A for ; Fri, 23 Jan 2026 04:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.63 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769144035; cv=fail; b=FFSjMfOtj3TQsAPEkSbx7t4xzPGISPdZXcPK+1VQ5u5oQJpGyyARCnqfdpIjbDV/Z0SlzIFLYwXhp5DjbcGzOZzVft8MGBcGt8MJ8pMJqyOiGst5MfUgOncjWJKhBQF9/spG8rdzOFrbnzTLw0LGpb1ywNKIXBWWrJ/Z4Z49fIg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769144035; c=relaxed/simple; bh=QoKBn4qIbIBwN5E0HZeLko4kr6FbwAXFnum1nxRDqGc=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=udDBnc7oUt4jGjzMUxE8bYR6hgvg1Kn6EaGY09X2QXadGTGKYyP97SIQowalILvIM75in53BE3Vq1XKfV4LBz9V51SoyhnghPo8rfMfW072AwyhIEe1Tx/F2cVqpqJ3Ud9oZnl3a06eJfKM8biI3ZU2f6ayCLPkUdCdEv7Iyex0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=3kbVJIKo; arc=fail smtp.client-ip=40.107.200.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="3kbVJIKo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kW8qZd/URjqxB+pAKINyQ3/E/BC8S0b5J+zIAhu02D/6CnCp/j6jlaFt0tKXcyLUqogornLH495zzdHL66aAtQKzaW0lPTv3o2ShWMcDg/HwukuRjEtuEs+LNgc5kVn3ZMG3N3ZtkRtWuKsASCubVNxja/BhBwtLaWUTGjhoUIo078iLqF7W2pD81Z6fYWdSxL2x8GIJt2UEcHFPIcF7kpFcYugDzilk1VcuP+cYYW2+0Q1OYSTzSVsq7KUDqeQVlHa1n05AH5B2U4B+XUTsAZLFZVpPAga1Z9JhQfV/QxZgEFZD+1vvJKTwClMJAEQTAu8PiNpa6bQNEDn49JRRFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wk/hojaHW3kUbrApc1kMKvWL/KviZoLqKJkOeLOk6fM=; b=KKMpk/8uvdHp4iENfPtEuECErIGT15HC+Atv61MnicyXl4lofhr4JRKSAEbqRBhXxDqhI1cMxjDyQFNIM5IA8vYf8nmNcrRYIG7iDHOmw9tvcqcU9O6kkVrtNyDYPgFqKR2o9UUSMbbdQwLDdWdQN7CEcx8BOmfrq5rj07zjRde6HWClhGDR6kgBGNNATHKU1hDHi5w3sMYM9uIMm+HLuDhdTMptnhllv44jwaI/Znk6nsvis2Rki5A8KYK1hMkFWr00+O+TXkdJMwCBP6p9LOvnaqLbd1PmkIhgfnW+cfh14Goxy52UhzYwIJxOJvxsFKJFlPOEioMLCv0gFOe+Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wk/hojaHW3kUbrApc1kMKvWL/KviZoLqKJkOeLOk6fM=; b=3kbVJIKo4Dk6VSPGNn5mF30PB4wyWE6la11PdlxokqGvVIIcyK2z22QVGAcNi2ABmSpLUk5kvckoxhK4CeKsj63RtBPIvrBe8wOOL8ThMDnuqAGuM79pyZI8GweXdgwJvEktj1WAHfRf6U+DyXKQEdV6QXZUS+yEkNvuTEKb7Uw= Received: from DM6PR21CA0004.namprd21.prod.outlook.com (2603:10b6:5:174::14) by BN5PR12MB9461.namprd12.prod.outlook.com (2603:10b6:408:2a8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.10; Fri, 23 Jan 2026 04:53:43 +0000 Received: from CY4PEPF0000EDD3.namprd03.prod.outlook.com (2603:10b6:5:174:cafe::c5) by DM6PR21CA0004.outlook.office365.com (2603:10b6:5:174::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9564.3 via Frontend Transport; Fri, 23 Jan 2026 04:53:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by CY4PEPF0000EDD3.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.3 via Frontend Transport; Fri, 23 Jan 2026 04:53:43 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 22 Jan 2026 22:53:42 -0600 Received: from [10.136.37.139] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 22 Jan 2026 20:53:39 -0800 Message-ID: Date: Fri, 23 Jan 2026 10:23:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/8] sched/topology: Switch to assigning "sd->shared" from s_data To: Shrikanth Hegde CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Chen Yu , "Gautham R. Shenoy" , "Ingo Molnar" , Peter Zijlstra , Juri Lelli , Vincent Guittot , References: <20260120113246.27987-1-kprateek.nayak@amd.com> <20260120113246.27987-4-kprateek.nayak@amd.com> <7b0eb351-741b-428a-9bb3-ab0b8a0c81e2@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD3:EE_|BN5PR12MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: ce9628cb-b6c7-43b3-64d3-08de5a3b6273 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RGp3V0RKT01qa050UithcFJmMFJYejhFeENucFFjdmpDbzlCeksvNzFSUkIx?= =?utf-8?B?MGsrUFRtUE1DdlowWHFiUVZSNi90RXFqUDVEK0FiZmg1Zzgxc1lTSUlVbkZx?= =?utf-8?B?cnVIaVFRY1oxeE9ZbUgxcmMrWFExNTAvWTJ4QUlOVEJ6RkQ0Qkh3eWUxay9t?= =?utf-8?B?UFFEUzhadjN1N2VGOEw1NURsMEVqTTFGU1JNUnNtczFDSzNqLzJNa3VaRXYr?= =?utf-8?B?SEFwV21KcnZOcEpPSHN0d05TbnZxUzJBaVZYaTBVRnovTnRmVU4yUS9Calk2?= =?utf-8?B?Wk1ETk0vU2JPS1hWSWtrUlkyRjdocTF4eWF4Sk1QaXNLZmx3UWQyN1VFVjl0?= =?utf-8?B?TDZmMUVVVTlPUW9WR21PZlgyNXJJVzlqVUZ0VTNvR0U3UkRqM014cUFqNGd4?= =?utf-8?B?cXZHL1RjSmRHc0VpdldkN2VibXpYM0NyNVZJUUl6UFpwU1BLbitGcEpCVER1?= =?utf-8?B?NFJONC95a0k2S1JYWUJpWlNzQnpnTkl1QWU1MDhSL0FvVEMvejFPd2U5NFJs?= =?utf-8?B?anBwM1FkWXA3bXpLSGt1VEU4Z2pyUHNZejdoL3hQRU9haWozajRHT2Vab0dt?= =?utf-8?B?Qzh4ZEl2S2ExSm5nSWJaZ0dCNm9iQlUvbmZ0MXkwNjlhVm51cnBpZmJBK2t0?= =?utf-8?B?d0l2R0I2L3hvbkM5NnhydTgxUlVDUVhmTnlBcTJnRUZYbmdrMVo4L25JT1ow?= =?utf-8?B?aVNaSXQzcWtiRC85L2VyRngraHNZNWY0eGpEbStzVExRMHVIa3JRMFYrZHha?= =?utf-8?B?dk55TGwyQSs2eEkwVVhBZDEydkhRQ3hoSkorOUlrOS9OZjNLaWlDdTI2NzE4?= =?utf-8?B?NWtaNzJ3MC9GQmlwdFArWkFTL1l0elBlMmdFd3VKb3Bma1ZRRnBrN3ZES2VI?= =?utf-8?B?UnkxeXFBTzYzdFZIbU5WcWdGMmZJWHoycFJSQzJLUzNaZkhHVmZVRDN1U2ho?= =?utf-8?B?NTFBMkkxVUxYcDAxdXJ4OVJBZUZIRms4ME9mUytYM0owV1JQQm0yeEVPcXAz?= =?utf-8?B?RS9yN0RySzhkTkFnYmtUeC83RmVHT0xoMmtsWHN5R1NpN3BGT1JrLyt0UzNm?= =?utf-8?B?cGRodHVrS3lvVDFzTWY2dXVhTEZVNTVzcEdWK09XTFBZSHg5T2ppODN4YUJI?= =?utf-8?B?L2JXTnhQMG4xZFVLYUtWUmFIMDkxOUEyVmo4NnI2MmdFbVdPeDFTZlhxWkt6?= =?utf-8?B?dk5mUHJWYlVhbGdPWnVCR3FQR3BJOHZJNkZPU1FsMDBvVGpBbFB5NWh4ZUIx?= =?utf-8?B?Sis4eE40MnFoNkRwNmVWS1VDVVYwc0tlL3pTQi9xRTVyRmRCWndlaW1ZRi9u?= =?utf-8?B?UExCZVMxQjZYeXBHSHRackpUMDdIV2Z3QUR4QmllaHRoUmFuWk5LcDdzb3lj?= =?utf-8?B?eko1ZjJaWFRTMGdTei9EYjVVMUdGRk5hQ3M4L01DQkc2UzM4aUtFeEJrU3pT?= =?utf-8?B?b0tBY2J0YmFxY1MxVmJaNDdtanJ3QURtdmsrWXJNUFFTQ3ZjSDFOMEpqRWxS?= =?utf-8?B?OGNmQkE5WWpGQ01ITTZFZFFYMWkzMW5SejRkODhUNXZFQUkvVVJVYU9OOUVk?= =?utf-8?B?MGplTk9NcDdBZ2s4NWNzQkJqZHlvVXlCTTFTY0JWU0tNMUx6alh5VmJ2QVd0?= =?utf-8?B?c1ZWelI3eURvcmV2ZVh2Vi82ejNXc3puWkNDaUhmNXkrYkJaWFlsRWl2azZq?= =?utf-8?B?ZFlybjVic3FlV1FzSVhLbXFCRHBWOWJuUlBGWHoxc0xGTTlsdVBEeDl3bDZm?= =?utf-8?B?QkQ5c2pZLy9FbitvMGNZQXVkT2I2ZU9sOGVMb3J2WWQ1T3NmV0dNQTJvbVU1?= =?utf-8?B?TVBRQ2VyRWFibUE0VGE3WUxDVUZsVXZ6K3dvY2QxWlRsbnBzSnpBaGxZazIy?= =?utf-8?B?ZjdjUHZGV0pPQ0VKUHltOURacEdReTVWUjFlYWFXQmVaOFd6WkN3SDdQMDVu?= =?utf-8?B?MlNuZHJERXczS08rTWZ5a2JXYUhseGU4RlBqbklTeFovcnROcFRIbVJmL043?= =?utf-8?B?OENXN3piZjErdlRYUmp3djJGN1FFU212Y3RmTWhjSFVCL3lSdUtEQlk5Y3Fu?= =?utf-8?B?TUNTaWRuRy9IM0pwVDAzRW1mdzh2L0lnOVY4SFRLdDNEUkovczRpMHd6VmFQ?= =?utf-8?B?djNJZ2UzQURqS21pbU1YNkQ2L1lnNHhiWC9qMXZIQm9iUitkSEZRWE1XSHJz?= =?utf-8?B?NFFLVURhYmdEb0duYlhxeFNvbnUyQmtjTnhoK2Z2VWJ3SEUybFBBVHU1eG42?= =?utf-8?B?MU9wNG00b2pqbFpkUk9sdjdXTkV3PT0=?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2026 04:53:43.3609 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce9628cb-b6c7-43b3-64d3-08de5a3b6273 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD3.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN5PR12MB9461 On 1/23/2026 9:38 AM, Shrikanth Hegde wrote: >> I can put the claim_allocations() bits the previous loop and pass the >> CPU and the s_data reference so it can free both "d.sds" and all the >> "d.sd" bits in one place and retain this reverse loop for >> init_sched_groups_capacity(). Does that sound better? >> > > Yes.IMO Having it in one place is better. > Even the next loop could be used to do that. Ack! Will change accordingly in the next version. Thank you again for the suggestion. -- Thanks and Regards, Prateek