From: John Meneghini <jmeneghi@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kbusch@kernel.org, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
emilne@redhat.com, jrani@purestorage.com, randyj@purestorage.com,
chaitanyak@nvidia.com, hare@kernel.org
Subject: Re: [PATCH v7 1/1] nvme-multipath: implement "queue-depth" iopolicy
Date: Thu, 20 Jun 2024 10:41:22 -0400 [thread overview]
Message-ID: <b09f3db4-df3a-4dce-a490-32b38e97231a@redhat.com> (raw)
In-Reply-To: <20240620065641.GA22113@lst.de>
On 6/20/24 02:56, Christoph Hellwig wrote:
>> + WARN_ON_ONCE((atomic_dec_if_positive(&ns->ctrl->nr_active)) < 0);
> Overly long line.
>
> But I don't understand why you need the WARN_ON anyway. If the value
> must always be positive there is no point in atomic_dec_if_positive.
> If misaccounting is fine there WARN_ON is counterproductive.
Agreed. I wanted this here for testing purposes. In all of my hours of running tests I never saw this warning go off, so I
agree it should be removed.
/John
next prev parent reply other threads:[~2024-06-20 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 16:35 [PATCH v7 0/1] nvme: queue-depth multipath iopolicy John Meneghini
2024-06-19 16:35 ` [PATCH v7 1/1] nvme-multipath: implement "queue-depth" iopolicy John Meneghini
2024-06-20 6:56 ` Christoph Hellwig
2024-06-20 14:41 ` John Meneghini [this message]
2024-06-20 17:54 ` John Meneghini
2024-06-24 8:46 ` Christoph Hellwig
2024-06-24 17:50 ` John Meneghini
2024-06-24 17:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b09f3db4-df3a-4dce-a490-32b38e97231a@redhat.com \
--to=jmeneghi@redhat.com \
--cc=chaitanyak@nvidia.com \
--cc=emilne@redhat.com \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=jrani@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox