From: Charan Teja Kalla <charante@codeaurora.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched,psi: fix the 'int' underflow for psi
Date: Thu, 15 Apr 2021 20:25:32 +0530 [thread overview]
Message-ID: <b0a0b8f5-a5bc-4807-f55b-288db57c74e2@codeaurora.org> (raw)
In-Reply-To: <YHhQ7tDZWF6tHXSQ@cmpxchg.org>
Thanks Johannes!!
On 4/15/2021 8:12 PM, Johannes Weiner wrote:
> Makes sense, it's more graceful in the event of a bug.
>
> But what motivates this change? Is it something you hit recently with
> an upstream kernel and we should investigate?
We specifically didn't hit the issue around this change. Identified this
while doing code walk through.
>
> There is already a branch on the tasks to signal the bug. How about:
>
> if (groupc->tasksk[t]) {
> groupc->tasks[t]--;
> } else if (!psi_bug) {
> printk_deferred(...
> psi_bug = 1;
> }
Looks cleaner. Will raise V2 with this.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation Collaborative Project
prev parent reply other threads:[~2021-04-15 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 14:29 [PATCH] sched,psi: fix the 'int' underflow for psi Charan Teja Reddy
2021-04-15 14:42 ` Johannes Weiner
2021-04-15 14:55 ` Charan Teja Kalla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0a0b8f5-a5bc-4807-f55b-288db57c74e2@codeaurora.org \
--to=charante@codeaurora.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox