Re: [PATCH v3 3/4] crypto: ccp: Add SNP firmware hotload support

[Tom Lendacky <thomas.lendacky@amd.com>]

On 11/4/24 13:30, Dionna Amalie Glaze wrote:
> On Mon, Nov 4, 2024 at 9:06 AM Tom Lendacky <thomas.lendacky@amd.com> wrote:
>> On 11/1/24 19:08, Dionna Glaze wrote:
>>

>> This is a big patch. Can you split this up into smaller patches? At a
>> minimum, one patch that adds the context tracking and one that adds the
>> firmware support.
>>
> 
> Can do. Would it be appropriate to also add a sysfs attribute group
> for sev that makes the firmware version more easily readable? Or
> should I put that in a follow-up chain?

That would be best as a separate patch series. But doesn't the
SEV_PLATFORM_STATUS or SNP_PLATFORM_STATUS ioctl() give you all the
information you need?

Thanks,
Tom

> The dmesg log about the firmware version isn't the best for writing
> automation for managing firmware hotloading at scale, and we're better
> set up for working with sysfs generally.
> 
>> Also, can the guest context page tracking and new firmware related
>> functions be placed in a new file, sev-fw.c or similar, that is
>> conditionally built based on CONFIG_FW_UPLOAD. Then a header file can be
>> used to provide the different implementations of the new functions
>> removing the #ifdefs from the code.
>>
>> Thanks,
>> Tom
>>