From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B6F915FA81 for ; Mon, 16 Mar 2026 10:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773655453; cv=none; b=Xr7KHZ6AFX6FllToDd9aUFqgok93DwNEzoviqFN8jNd/yLcUYuay5OLgEToTC1HrBst6du3ePcwMrUwLruijs1mZtnp2Z57xmoq8pkXKZQG4L9XhBb60F3Vvj+UKgiqrrdAEu8J1qVpEobeZJvON212vjReTFb+qlHn4tSDbRqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773655453; c=relaxed/simple; bh=gPGxzaQMfTm3BYwVqIxHNQ+Hn5RVj2msxraZs8ZL2FM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SI+QP4xShGoiTfB8X+kJYa3QYVcx03aWSXcRWmcCEQ44xais7QXF7oDaXTEqeD8kpCueJvZbrIuCc0HjboRn/OAYFVxi3zuqDEojPJJ6WQFlD3jq/QdMjqHgcoIeJ2rQzdvcqiF3NtB2J4lqlq1u17Ih54lZEHpOCqi4XtKEkhI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=oV9nokCS; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=AffWizTZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=O3RNzaZc; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6rMru4vL; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="oV9nokCS"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="AffWizTZ"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="O3RNzaZc"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6rMru4vL" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2D2AF5BCC3; Mon, 16 Mar 2026 10:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773655450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KfwgO5Xm1GA/MmpYiz1fWmR2hvwviD2iUrNXxDIfK+s=; b=oV9nokCSKpYJ40z0cakqJu9UnLSsX7IDTbdB+q17zlFYzarrEXontL9Aj2huj+5x9jYZNP MHp7r7S2AR0PjpJUhw3XbuVyc8awn3LJ0D3tYu3C+afYeoFGz0vGPUyOQMlnbe1jf+Xj8a NaVXz1kBij7j5uK/EAWaJZBh7ds28rE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773655450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KfwgO5Xm1GA/MmpYiz1fWmR2hvwviD2iUrNXxDIfK+s=; b=AffWizTZgQe2B6eWb6P4QpyGK2m4nEk3lAHEqT7GzOeMIwdcGPJ6YmtX38xAuJbKoAeMh2 F2Hm0ZJGbvhSMLBg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773655448; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KfwgO5Xm1GA/MmpYiz1fWmR2hvwviD2iUrNXxDIfK+s=; b=O3RNzaZcDLMzwZwhOUcba/mMYAUuzkiehahPfoYIZ/9U2QzpCaTa+5FjYS+DGOdjKzjkIZ h3g7tYuk/56F5oJMgSxYnmYNVgxVa10U3cRuxGnPYxcdkmRXNE857EPh26O1gD1crTZhRc VHWzzjmzLpn4KhsoN9cmtLgslKSEILk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773655448; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KfwgO5Xm1GA/MmpYiz1fWmR2hvwviD2iUrNXxDIfK+s=; b=6rMru4vLQ6FnQv+NNJeD8d6rBt/oU5xhhFBG5GoQaLkgeGd6MJuTrCPlMXqAQG2UrJLraf g4EoAxmty6zm0GCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E58C04273B; Mon, 16 Mar 2026 10:04:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KMGZNpfVt2nrQgAAD6G6ig (envelope-from ); Mon, 16 Mar 2026 10:04:07 +0000 Message-ID: Date: Mon, 16 Mar 2026 11:04:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/ast: DisplayPort edid supports 256 bytes To: Jammy Huang , Dave Airlie , Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260313-upstream_ast_dp_edid-v1-1-2a75b7c091b2@aspeedtech.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260313-upstream_ast_dp_edid-v1-1-2a75b7c091b2@aspeedtech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_TO(0.00)[aspeedtech.com,redhat.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[9]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,imap1.dmz-prg2.suse.org:helo,bootlin.com:url,aspeedtech.com:email,suse.de:mid] X-Spam-Flag: NO X-Spam-Score: -4.30 X-Spam-Level: Hi Jammy Am 13.03.26 um 11:04 schrieb Jammy Huang: > DisplayPort supports edid at most 256 bytes. Thus, allow it to fetch > edid block 0 and 1. > > Signed-off-by: Jammy Huang > --- > ASPEED DisplayPort's EDID size can be 256 bytes at most. Thus, EDID > blocks fetched can be 0 and 1. > --- > drivers/gpu/drm/ast/ast_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ast/ast_dp.c b/drivers/gpu/drm/ast/ast_dp.c > index 9d07dad358c..c938e1d6b1d 100644 > --- a/drivers/gpu/drm/ast/ast_dp.c > +++ b/drivers/gpu/drm/ast/ast_dp.c > @@ -88,7 +88,7 @@ static int ast_astdp_read_edid_block(void *data, u8 *buf, unsigned int block, si > int ret = 0; > unsigned int i; > > - if (block > 0) > + if (block > 1) > return -EIO; /* extension headers not supported */ But see the code at [1]. It clears the number of extensions to zero and updates the checksum accordingly. This is required to make the shortened EDID work with DRM. If you leave this as-is, it will still clear support for any extension in block 1. See the table 2.4 in the VESA EDID 1.4 standard for the semantics. For 1.3, if the number of blocks is >2, the first extensions is a 'block map of the extensions'. This is useless, as it's not a data extension in itself.  In 1.4, the block map is optional. That code should clear the EDID's number of extensions to 0 or 1, depending on whether there is a block map to be expected. Best regards Thomas [1] https://elixir.bootlin.com/linux/v6.19.8/source/drivers/gpu/drm/ast/ast_dp.c#L157 > > /* > > --- > base-commit: 5ee8dbf54602dc340d6235b1d6aa17c0f283f48c > change-id: 20260313-upstream_ast_dp_edid-5fe6adf7ad36 > > Best regards, -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)