From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752641AbdBMSwx (ORCPT ); Mon, 13 Feb 2017 13:52:53 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:24934 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752476AbdBMSww (ORCPT ); Mon, 13 Feb 2017 13:52:52 -0500 Subject: Re: [PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented IOCTLs To: Paul Durrant , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <1487005404-3183-1-git-send-email-paul.durrant@citrix.com> <1487005404-3183-2-git-send-email-paul.durrant@citrix.com> Cc: Juergen Gross From: Boris Ostrovsky Message-ID: Date: Mon, 13 Feb 2017 13:52:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1487005404-3183-2-git-send-email-paul.durrant@citrix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/13/2017 12:03 PM, Paul Durrant wrote: > The code sets the default return code to -ENOSYS but then overrides this > to -EINVAL in the switch() statement's default case, which is clearly > silly. > > This patch removes the override and sets the default return code to > -ENOTTY, which is the conventional return for an unimplemented ioctl. > > Signed-off-by: Paul Durrant Applied to for-linus-4.11. -boris