linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Ingo Molnar <mingo@redhat.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 6/7] kernel-trace: Adjust two checks for null pointers in uprobe_buffer_init()
Date: Fri, 5 May 2017 23:09:30 +0200	[thread overview]
Message-ID: <b0ef0720-4ba4-1281-395f-e6ce639873d2@users.sourceforge.net> (raw)
In-Reply-To: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 5 May 2017 22:30:16 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 kernel/trace/trace_uprobe.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 3e662d7ea6a4..e9c1865f7397 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -705,13 +705,13 @@ static int uprobe_buffer_init(void)
 	int cpu, err_cpu;
 
 	uprobe_cpu_buffer = alloc_percpu(struct uprobe_cpu_buffer);
-	if (uprobe_cpu_buffer == NULL)
+	if (!uprobe_cpu_buffer)
 		return -ENOMEM;
 
 	for_each_possible_cpu(cpu) {
 		struct page *p = alloc_pages_node(cpu_to_node(cpu),
 						  GFP_KERNEL, 0);
-		if (p == NULL) {
+		if (!p) {
 			err_cpu = cpu;
 			goto err;
 		}
-- 
2.12.2

  parent reply	other threads:[~2017-05-05 21:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 21:00 [PATCH 0/7] kernel-trace: Fine-tuning for seven function implementations SF Markus Elfring
2017-05-05 21:01 ` [PATCH 1/7] kernel-trace: Combine two function calls into one in hist_trigger_entry_print() SF Markus Elfring
2017-05-05 21:02 ` [PATCH 2/7] kernel-trace: Replace five seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-05 21:03 ` [PATCH 3/7] kernel-trace: Adjust two checks for null pointers in compatible_field() SF Markus Elfring
2017-05-23  5:15   ` Steven Rostedt
2017-05-05 21:04 ` [PATCH 4/7] kernel-trace: Improve a size determination in create_hist_field() SF Markus Elfring
2017-05-05 21:05 ` [PATCH 5/7] kernel-trace: Replace two seq_printf() calls by seq_puts() in probes_seq_show() SF Markus Elfring
2017-05-05 21:06 ` [PATCH 0/7] kernel-trace: Fine-tuning for seven function implementations Steven Rostedt
2017-05-05 21:21   ` SF Markus Elfring
2017-05-22  7:45   ` SF Markus Elfring
2017-05-23  5:18     ` Steven Rostedt
2017-05-05 21:06 ` [PATCH 6/7] kernel-trace: Adjust two checks for null pointers in uprobe_buffer_init() SF Markus Elfring
2017-05-05 21:09 ` SF Markus Elfring [this message]
2017-05-05 21:10 ` [PATCH 7/7] kernel-trace: Delete an error message for a failed memory allocation in create_trace_uprobe() SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0ef0720-4ba4-1281-395f-e6ce639873d2@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).