From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756089AbdEEVJk (ORCPT ); Fri, 5 May 2017 17:09:40 -0400 Received: from mout.web.de ([212.227.15.4]:49475 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbdEEVJi (ORCPT ); Fri, 5 May 2017 17:09:38 -0400 Subject: [PATCH 6/7] kernel-trace: Adjust two checks for null pointers in uprobe_buffer_init() From: SF Markus Elfring To: Ingo Molnar , Steven Rostedt Cc: LKML , kernel-janitors@vger.kernel.org References: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> Message-ID: Date: Fri, 5 May 2017 23:09:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:WPmMVLQEIgvn/Uz22eWuPmOzFyNe3sAnC2wZCatShnAm8FA074V ABTTTkWmXTNpaWJPngwMfOFdJhuALM2MBT3OpZWy08L3BTP5YdbQdw5qL1xT74tq/Ao+1Z0 Wz4nC6EvCDawvuPJiOWwgFOtpu4LCTQO7mLm7MIVKG8KObGPzIHs71P5Arf5FUgPbU6aUS1 J6c22eQggLDN1Hdt8u+9A== X-UI-Out-Filterresults: notjunk:1;V01:K0:9NwBttBbBMg=:chBn7sF7zT6MsMsod4GHJd 305S+bIEOogaF7ubzGvDPEEdVOuZzc76ANDPP/R7eq6STsmwpwdo33QFaCnHwY9jkzdA3LD85 uBAF3/f4M0IzgTZcYeIGpa33Kn5ezU4xprmacfwwP7JdTb9ijtGYuSdMDA2IzoBkW58SzIH1u z+RWb+tV1nUvNh4WA2RzQb6paUBDDxm9XDViMutE9W0d5erit5W4q76tTUsx4CGurTEL/IOy3 BF2AgWP2TodcBx0XLNB0/1CkaejQihKuaCk+IDCcw+RfgceaC1copt3wmdR+kUICpJUJkjaxs GaSbei8vTJ6Y6CfJu1hNKP/MRS7Bqto0EN88E6H9wyobs6C+dReIauwO3DaTGoCBahjAx/EMN TPLpi1u+ZJjNhlLZeHY0Ey6Fws22VrxZ9XECavlTjURMP72DU+heLs/Gdw09DeYD23CjUphIS /BGy5N9cfvO0S4KQ8d+pD55ABFY7B2U1zX6DyZkzzv06c2S/oc2qs+W316I1+xJEKrzLJV5yQ /s3xyWvoLCzbgrpJIj5Xw1pPMEcJvw40CBrBMUtkG+9g7ze/E7mM2RCoSQu0/muc88JR5AQGa 7R2X8dHAJGObS00epdRActIfbTAgQkNiMyxMI995uYO/JgyX9n6LcZk4Vidrxvm27av+GA1cg YDUf+mkwYRBM/8F2NDccWIWxInE02wuWkls6aHRW1u0DDInL5pxi0RPL/+00ZtlpbvMdWo+E6 mkPwELKvfFI4jV1l4oigGeerIIpevE99Dkxo4b9SmyGpRoOsbXbETRqKu1YokqcVmlrMhsLQ7 pobs5jD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 5 May 2017 22:30:16 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code place. Signed-off-by: Markus Elfring --- kernel/trace/trace_uprobe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index 3e662d7ea6a4..e9c1865f7397 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c @@ -705,13 +705,13 @@ static int uprobe_buffer_init(void) int cpu, err_cpu; uprobe_cpu_buffer = alloc_percpu(struct uprobe_cpu_buffer); - if (uprobe_cpu_buffer == NULL) + if (!uprobe_cpu_buffer) return -ENOMEM; for_each_possible_cpu(cpu) { struct page *p = alloc_pages_node(cpu_to_node(cpu), GFP_KERNEL, 0); - if (p == NULL) { + if (!p) { err_cpu = cpu; goto err; } -- 2.12.2