From: "Henning P. Schmiedehausen" <hps@intermeta.de>
To: linux-kernel@vger.kernel.org
Subject: Re: Can't burn DVD under 2.5.59 with ide-cd
Date: Fri, 24 Jan 2003 09:10:02 +0000 (UTC) [thread overview]
Message-ID: <b0qvta$fo6$1@forge.intermeta.de> (raw)
In-Reply-To: 20030123180653.GU910@suse.de
Jens Axboe <axboe@suse.de> writes:
>In drivers/ide/ide-cd.c:cdrom_end_request(), try to insert something
>ala:
> if ((rq->flags & REQ_SENSE) && uptodate) {
> struct request *failed = (struct request *) rq->buffer;
> struct cdrom_info *info = drive->driver_data;
> void *sense = &info->sense_data;
>+ if (failed && block_pc_request(failed))
>+ printk("%s: failed %p\n", __FUNCTION__, failed->sense);
> if (failed && failed->sense)
> sense = failed->sense;
Shouldn't this be below the 2nd if() and then just test "sense" ?
Like
> if (failed && failed->sense)
> sense = failed->sense;
>+ if (failed && block_pc_request(failed))
>+ printk("%s: failed %p\n", __FUNCTION__, sense);
That makes sure, that you report what is analyzed later here:
> cdrom_analyze_sense_data(drive, failed, sense);
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen -- Geschaeftsfuehrer
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH hps@intermeta.de
Am Schwabachgrund 22 Fon.: 09131 / 50654-0 info@intermeta.de
D-91054 Buckenhof Fax.: 09131 / 50654-20
next prev parent reply other threads:[~2003-01-24 9:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-23 17:52 Can't burn DVD under 2.5.59 with ide-cd Joerg Schilling
2003-01-23 18:01 ` Gregoire Favre
2003-01-23 18:06 ` Jens Axboe
2003-01-23 18:10 ` Jens Axboe
2003-01-23 18:55 ` Gregoire Favre
2003-01-23 19:07 ` Jens Axboe
2003-01-23 19:21 ` Gregoire Favre
2003-01-23 21:18 ` Jens Axboe
2003-01-23 21:54 ` Gregoire Favre
2003-01-24 7:55 ` Jens Axboe
2003-01-24 9:10 ` Henning P. Schmiedehausen [this message]
2003-01-24 9:26 ` Jens Axboe
2003-01-25 14:25 ` Gregoire Favre
2003-01-26 16:23 ` Jens Axboe
2003-01-26 16:38 ` Gregoire Favre
2003-01-23 18:02 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2003-01-22 15:38 Joerg Schilling
2003-01-22 8:23 Joerg Schilling
2003-01-22 8:35 ` Jens Axboe
2003-01-22 9:47 ` Gregoire Favre
2003-01-22 12:57 ` Bob_Tracy(0000)
2003-01-23 17:51 ` Gregoire Favre
2003-01-22 12:00 ` Andre Hedrick
2003-01-22 18:13 ` William Lee Irwin III
2003-01-22 1:09 Joerg Schilling
2003-01-22 8:05 ` Jens Axboe
2003-01-21 22:07 Gregoire Favre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b0qvta$fo6$1@forge.intermeta.de' \
--to=hps@intermeta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox