From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3CBE351C28 for ; Mon, 6 Jul 2026 01:42:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783302175; cv=none; b=Wtfqf9VlCoNaw1LZIorRWDUVMwlEXMxtfJm2UZU4xADW2Bpe0nIkX0agQpetZny9TWLGtr6y6y2gpH/6iPwP6hgsx119C4FCmc3VGK3pRNvdiz+q/WRA8a3C8ddI1PM152oeJpksgplNaowZz9IBrnodD9Cy+WD8iWiOJlznWjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783302175; c=relaxed/simple; bh=auuE+qiAeK/cs6i3yewtCQh7qLdHLrn/RcPLhuqu/K0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ijDoxasnPF9/kii/pT/AQBJaG/7AFtbzhlOz2beCxrEJacvyWOLfoSZvra4yBd2yW+A/oBNRVSZP1eAXU21oq70DjNeV56ajdTYEYjmNWAKAigRKF42Kc4PR+DRBCqsozIzX0ArwjFI3oxnUR1ape4TDro9/ecPWHAdB4fi/jE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=X6HU2VVf; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="X6HU2VVf" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783302168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fs3PDk+ICzT5JmREAjpkl1+i96EjXK1gwBqdT/2GxVA=; b=X6HU2VVf9Rmd+xYkCimrMRYONFxHlj1FLzMdWaDQIJ4CIisKe6O4ebHBhIO8xFtEpzsw1V if9clW5afwlt64H2wgInX7C2clZrNM4KB9RbhlwJBI4/bl5XISTBr2BGjRLv8fXIxd6+qZ HNfDAc3wBC6KybvkkcQAmn7/fpWtHpI= Date: Mon, 6 Jul 2026 09:42:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] mm/mseal: fix mseal documentation for 32-bit kernels Content-Language: en-US To: Matthew Wilcox Cc: linux-mm@kvack.org, Jonathan Corbet , Shuah Khan , Andrew Morton , "Liam R . Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Nathan Chancellor , Peter Zijlstra , Miguel Ojeda , Nicolas Schier , Thomas Gleixner , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Alice Ryhl , Douglas Anderson , Gary Guo , Anand Moon , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20260703022507.187457-1-leon.hwang@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Leon Hwang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 4/7/26 08:39, Matthew Wilcox wrote: > On Fri, Jul 03, 2026 at 10:25:07AM +0800, Leon Hwang wrote: >> Document the -EINTR return from mmap_write_lock_killable(), fix the > > No, you don't understand the whole concept of "killable". If a > task receives a fatal signal, it dies before it returns to userspace. > So userspace never gets to see the -EINTR. It's fine to document inside > the kernel that function foo() can return -EINTR, but it's pointless to > document it for userspace. > > This is how "killable" differs from "interruptible". Interruptible allows > non-fatal signals to wake a task, and then the task can see the -EINTR. > But many processes do not check the error code, and so read() and write() > (despite being documented as being able to return EINTR!) do not do so > in practise. Thanks for your explanation. Will drop the -EINTR documentation change from mseal.rst. Thanks, Leon