From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8896F1F4C8E for ; Tue, 30 Dec 2025 06:02:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767074569; cv=none; b=GYLEVSAdyxHAGoflarfWqyvA2k+qzvN0WtQsCCksu9Tiowyo6O9uEpIuhQ8dbX11Z72bBBytmmt3r76rsCNHxANXo894YVH3eDD5nPoLOaCuuTQqXuMLEEyf3Vx1qVskKp/939pZKL1LVAD3X78I9/ivNNh04FNoA0J/T5MVdXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767074569; c=relaxed/simple; bh=Kwas6i+yO6AYTCY2Bi0oOc14wGQ+uPdyWPo2DNR48tU=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=lyuCXooyLFu2BTtig5NY0guZpY0c4QlDhBlQfB/J2h9Wr3VG5nfXOJo2+EKWW7xP1cRoiHsz2qOIJD6WZedOON+TTSlPL/WbwAAO4JjxrACp09JsJRiitt9TnolIMbFqdV2RV/IHQ3h5D20G9/1pqKlFJJn/er+ZEjmi1GA9EDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DWwr6CD2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NYGS5n2v; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DWwr6CD2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NYGS5n2v" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BU3hsJr2547838 for ; Tue, 30 Dec 2025 06:02:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MElqb+vB8K63hON6iSmHcwD/Y1fFl71V1NoNoV+IIa8=; b=DWwr6CD26zJj9Mel hBupvAC98jMDa9PzB3IcvY7TpUsnZBkglg7k1VAIyhMqiAEiF4vFfhax+1eK/FEb CXTV95mGjbUjmUKp2GOAFvSl46OlDKrPtrkMDrUNPeDkHYI6/OyZ3tAbC/PtqG7X ouk0G6GK38FjH4Keed6ailPDI6P94RZq8RNW3j1ezm6qm6TE/ds8bY7GY17Fltuf P9k3cC9OXfI54wW7+WPXLhnZTbd5+9QXiNxqMtTzkA9mFG+UsF4F28c6xx9lMPji J7sOKu63HyBYWn6V5txYKhHaTPPIxwtgXBU/bxrgyBFdw6JSlNhjzc/O1vVDzcJ1 kUI7nQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc7398895-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 06:02:47 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-34ab459c051so24129746a91.0 for ; Mon, 29 Dec 2025 22:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767074567; x=1767679367; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=MElqb+vB8K63hON6iSmHcwD/Y1fFl71V1NoNoV+IIa8=; b=NYGS5n2vjxF4kNuYqChFFYL1mw6kIChC8S/wec2c0DNp36+zx1fepfxOZgaaQJEiQm agLopHvcaMDA0lD31sfPhZzhvRxUd1lCH+ScnKsC05tFQFSLQBi8gWRwOTg5nzoAXYla 5r9tkVzrXfM9bYDxj0EQBOjaHGEcU6F95EaB/nrCE9tAMHPWmzNeKx9pGCqiKwT4DLlU tlKWYquZ9RYGp/c7FLUI1e9soe7uATE+FhrxVXd+Ge1klzOnAUmou6k8aW9cbc9803mX uW8h+yChYFSu29yPPCL/eGhNNRb+DE54aMkzrH9Qs29b+cUTxQV0v9ATUeOc2EML0I0V pL7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767074567; x=1767679367; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MElqb+vB8K63hON6iSmHcwD/Y1fFl71V1NoNoV+IIa8=; b=e8B5oGY1yFdEpx2rAo1O38/9bt8ClhGd6imgYA25IDkG9w9UeL4ico9po/O0XJ3rOO t2YsuLPiYv9B2PBnkOC8n6ZrJVbsvnIkRr44L3dYq/Vp4a0nL/gZzmbgMqnLC5QsQ0Yb JJOhcPeeAf+JW5RehJ4cKLA3b4E9ZWy/g/P0eb4TiA6AVZzukdnqnxTnepSEibzkXby8 L1rayvrw9c4yL3/H9wi8exbwBY44V7kltdOb8kH/+n1cjnagEbJRUczoCNcdnxozKg0H UjjhfYluvCZxJi6I5OVvdbiA+pfmKpVGmk5LAgOhouqmMvijMuRGtqjO5f9nhxBd2L3u MDHw== X-Forwarded-Encrypted: i=1; AJvYcCWbFsdiVx83tO2m3aK17P37YgDw4HuwmXHpOb93wih+RnoQv4aolo+1/FxlVgBeM8HMcTZ5pSud5lfJceY=@vger.kernel.org X-Gm-Message-State: AOJu0YwepAV6ginVqDLIUDM0RQoOthIrqf+8QE1lBL6j5qOR7fOobqva /zJ4h0f+gcwDwwL5rSmBSpZMe/dR/fsUeVrNi+HT5uHc7CmnK2ijV3kDtw5cjDgEKtrwgJJsuuN 4y1rcS7Ul22VTlviiVomRem7rMj3nGyt6ofU5X/9eBwb2t4Jdgf4+QhDXw4SciBI9CSV5jGY1D4 k= X-Gm-Gg: AY/fxX48+VIXAHkrDvygbOAUQB+eYGIIYvF1fgBROHo+9nG6c5yNsP0a7n5npxNrBYX q6+dOlu5/tis0mUp4JIkpKm2Kml/sUn2zuA1+rfeyJuSp55SvSbWhA95ELcwcPdsAAxuutq/s5q fs0BFakDyccYTl1Dd/lm3Cn/Tss7o/e7V2PjQiicczJPPBy/rHPM/UzjjWIPDQIGNYkjQxfNAmU 3o6x6GfgbdPyCg5NxMFGRd0WLWQf6R9MSWUvhW1R/XrVwI4BK2CofcTVyb56cBLGIyZzxeFe+jJ oGfjwMia9NTH75XtyBdGVS/berUBXN4z4eRix0GbtI2K92Xo2RQ64EOJGh5j7QTBicyOU/uGhKc OhzsbR6iisNMQcMnVb7z3TTVUR4IY7V8N1UukJUE= X-Received: by 2002:a17:90b:35d2:b0:340:776d:f4ca with SMTP id 98e67ed59e1d1-34e921e057cmr30065546a91.26.1767074566750; Mon, 29 Dec 2025 22:02:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFcdegpDZU4uHFbOONZR0iUuxpEWmvOTtglW+/1Y/PXUFGcUNtlm4gnCiJfdjxq6efdjBrYmw== X-Received: by 2002:a17:90b:35d2:b0:340:776d:f4ca with SMTP id 98e67ed59e1d1-34e921e057cmr30065522a91.26.1767074566240; Mon, 29 Dec 2025 22:02:46 -0800 (PST) Received: from [10.217.223.198] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1e7c530f72sm26471509a12.29.2025.12.29.22.02.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 22:02:45 -0800 (PST) Subject: Re: [PATCH v3] mmc: host: sdhci-msm: Add support for wrapped keys To: Konrad Dybcio , adrian.hunter@intel.com, ulf.hansson@linaro.org, ebiggers@kernel.org, abel.vesa@linaro.org Cc: linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Wenjia Zhang References: <20251229070507.3322149-1-neeraj.soni@oss.qualcomm.com> From: Neeraj Soni Message-ID: Date: Tue, 30 Dec 2025 11:32:41 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: xVjU-LCXkQ1gtAlrDHkONkdBWoqu-nbB X-Authority-Analysis: v=2.4 cv=HrV72kTS c=1 sm=1 tr=0 ts=69536b07 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=90dgnz13A4KOmbfFnlkA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDA1MyBTYWx0ZWRfX6hkAKIoGMOLQ odNSDIDQV9IJe2yXHyfMLZYuJ7nzM3ZwEQmkQp1fieGqDENuwHhG7W+C8wSw7UiUSzUcJUkUE24 +20+wxa/bQFaDl2uQ4tfqp++/6/Xb+lUpRbU3WU6suUMExxO5q0TZId2R6vdwrpbNmJ4xy9zCRT URL+O8b0Rl+Da3EIKo8Fediw2VCaIhyvSY/6RSOqjiQoj5PyB0ZHPHKchK8SXQvvcy5nutpeACh WF8E0N1aSKxMilJ7Q4WMsaz0cJdzf5SDHY5MafFCVC8LiKQqjm/X0sUsG1s377nusRC8YcShVII iwY5Upb+YZbKed1e0isKVV0HGTNSIdsZRrcetJSIJHI1x8EZ8X6zfpb3n0myv/8hYJdGtzsFH9l UN/N9Xm951oZ4D8fhWepKV1z6FqUnHJf1PjzcVOZ/ir9H7WG8805nvYh1MUxqwoXu8k/QwQWDmH 9HigYIwKNVYOWIt1h3A== X-Proofpoint-ORIG-GUID: xVjU-LCXkQ1gtAlrDHkONkdBWoqu-nbB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_07,2025-12-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 adultscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300053 Hi, On 12/29/2025 6:48 PM, Konrad Dybcio wrote: > On 12/29/25 8:05 AM, Neeraj Soni wrote: >> Add the wrapped key support for sdhci-msm by implementing the needed >> methods in struct blk_crypto_ll_ops and setting the appropriate flag in >> blk_crypto_profile::key_types_supported. >> >> Tested on SC7280 eMMC variant. > > [...] > >> +static int sdhci_msm_ice_derive_sw_secret(struct blk_crypto_profile *profile, >> + const u8 *eph_key, size_t eph_key_size, >> + u8 sw_secret[BLK_CRYPTO_SW_SECRET_SIZE]) > > These should be aligned, please touch that up Thanks for pointing out. Will fix it in next patch. > >> +{ >> + struct sdhci_msm_host *msm_host = >> + sdhci_msm_host_from_crypto_profile(profile); > > Please feel free to unwrap this line (and its copies) Sure. >> + >> + return qcom_ice_derive_sw_secret(msm_host->ice, eph_key, eph_key_size, >> + sw_secret); > > And this one too Okay will fix this too in next patch. > > Logic-wise, I don't see anything obviously wrong> > Konrad > Regards Neeraj