From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3E3AC433B4 for ; Fri, 30 Apr 2021 23:07:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5E4B613F8 for ; Fri, 30 Apr 2021 23:07:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232750AbhD3XH4 (ORCPT ); Fri, 30 Apr 2021 19:07:56 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:41833 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231502AbhD3XHz (ORCPT ); Fri, 30 Apr 2021 19:07:55 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1619824026; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=V+oj2FdgO738BZ62IBogKd0JpzcCrCkPU4H+tDaGYLE=; b=suFKIvyeJBoCzvR6y3xsuajYkU6VZ085yFxzY1C6v5BA61L85iT1Zd7VjCaQzuf8ctdEzxTN exO9CE/3L9fQ+29MU0ZWidzR3v583dzmZL9tuLLw0I4mqyVvJXi7PRyZJZi1vo+sdZC3RvLq r8qywMIPWejn4+8Ci4rkYs0Mbq4= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 608c8d9974f773a664283773 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 30 Apr 2021 23:07:05 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 02233C4338A; Fri, 30 Apr 2021 23:07:05 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id F3F79C433F1; Fri, 30 Apr 2021 23:07:02 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 30 Apr 2021 16:07:02 -0700 From: abhinavk@codeaurora.org To: Stephen Boyd Cc: Rob Clark , Sean Paul , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kuogee Hsieh , Dmitry Baryshkov , aravindh@codeaurora.org, freedreno@lists.freedesktop.org Subject: Re: [Freedreno] [PATCH 0/6] drm/msm: Trim down drm debugging logs In-Reply-To: <20210430193104.1770538-1-swboyd@chromium.org> References: <20210430193104.1770538-1-swboyd@chromium.org> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-04-30 12:30, Stephen Boyd wrote: > This patch series attempts to trim down the drm logging in the msm > driver to make it useable with DRM_UT_DRIVER, DRM_UT_KMS, and DRM_UT_DP > levels enabled. Right now the log is really spammy and prints multiple > lines for what feels like every frame. I moved those prints off to > other DRM_UT_* levels that felt appropriate. Please review. > > Cc: Dmitry Baryshkov > Cc: Abhinav Kumar > Cc: Kuogee Hsieh > Cc: aravindh@codeaurora.org > Cc: Sean Paul > For the entire series, Reviewed-by: Abhinav Kumar > Stephen Boyd (6): > drm/msm: Move vblank debug prints to drm_dbg_vbl() > drm/msm: Use VERB() for extra verbose logging > drm/msm/dp: Drop malformed debug print > drm/msm: Move FB debug prints to drm_dbg_state() > drm/msm/disp: Use plane debug print helper > drm/msm/disp: Move various debug logs to atomic bucket > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 16 ++++---- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 22 +++++------ > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 38 +++++++++---------- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ++--- > .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 6 +-- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 ++++------ > drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 14 +++---- > drivers/gpu/drm/msm/dp/dp_panel.c | 1 - > drivers/gpu/drm/msm/msm_drv.c | 4 +- > drivers/gpu/drm/msm/msm_fb.c | 8 ++-- > 12 files changed, 67 insertions(+), 75 deletions(-) > > > base-commit: 9f4ad9e425a1d3b6a34617b8ea226d56a119a717