From: "Henning P. Schmiedehausen" <hps@intermeta.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [BUG] e100 driver fails to initialize the hardware after kernel bootup through kexec
Date: Sun, 26 Jan 2003 21:56:46 +0000 (UTC) [thread overview]
Message-ID: <b11liu$bcl$1@forge.intermeta.de> (raw)
In-Reply-To: 20030124160748.GB18428@gtf.org
Jeff Garzik <jgarzik@pobox.com> writes:
>+ /* Wait 20 msec for reset to take effect */
>+ set_current_state(TASK_UNINTERRUPTIBLE);
>+ schedule_timeout(HZ / 50);
Hm. This assumes HZ=100, doesn't it?
>+ /* Wait for command to be cleared up to 1 sec */
>+ for (i=0; i<1000; i++) {
>+ if (!readb(&bdp->scb->scb_cmd_low))
>+ break;
>+ set_current_state(TASK_UNINTERRUPTIBLE);
>+ schedule_timeout(HZ / 1000);
>+ }
HZ = 100 -> HZ / 1000 == 0 ?
This whole patch scares me. :-)
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen -- Geschaeftsfuehrer
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH hps@intermeta.de
Am Schwabachgrund 22 Fon.: 09131 / 50654-0 info@intermeta.de
D-91054 Buckenhof Fax.: 09131 / 50654-20
next prev parent reply other threads:[~2003-01-26 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1042450072.1744.75.camel@aminoacin.sh.intel.com>
2003-01-24 6:49 ` [BUG] e100 driver fails to initialize the hardware after kernel bootup through kexec Michael Fu
2003-01-24 14:01 ` Eric W. Biederman
2003-01-24 14:57 ` Andrey Nekrasov
2003-01-24 16:07 ` Jeff Garzik
2003-01-26 21:56 ` Henning P. Schmiedehausen [this message]
[not found] ` <mailman.1043391842.14884.linux-kernel2news@redhat.com>
2003-01-24 16:49 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b11liu$bcl$1@forge.intermeta.de' \
--to=hps@intermeta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox