From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5BAE33D506 for ; Fri, 8 May 2026 11:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778239552; cv=none; b=o2T5EwKOSV1hccEHesHpQu5xYk3TmC9SMLHAxfAF1sQcGti4a8bYLJ9ki8kNRFbsmswT+fqucbBwCmm8X4JnhnnzSM5a2nP2bN1dKm/NvZ9J0jmxNo3gVjPZa0iSSCOx0T6e/AvcDW/B/4rtYaVGy+/rdCtvctXAriQwhu0S3L4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778239552; c=relaxed/simple; bh=wD5j8rt0dSEhF0q2hMieIlg5zWqwgiIHlW5Kir+x28Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gQnjWbuso/Aro2AWRfYnT7DWDop/Ae+pqGSclQBzyKO65RQlwD6nRAc6Rx80jM42P67ye5q25hvtWW6/9fYOjYsqcHMQeHuLE+Rcaldd8QyBSkwWLLP+xOuHQBno+ZjSBihuRfNRpGkefw1FJfX5cNerlLWyvsO+1Cu7A6gtMWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A3FfqYFH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=boagcqmC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A3FfqYFH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="boagcqmC" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6487Kgok318082 for ; Fri, 8 May 2026 11:25:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= g0jTW4sKikY/wqz7iN40y6tzI3Wvh1YmdS9omy6vL5s=; b=A3FfqYFHipDqEGBb ufOskjXITkepCCsoGU9ES5upnvlZI6IW2086xNDJEeANMkP1G+qilCw+6DqLZ96d y8FUoyhRUb5ANW/7B6VXMkgxS6tDQ7zqq7jTEIg9AEt+ZIDOM7tNyWOg/uNcL/ML fPwgP/A80wUoOxmNkC3PRfp/+QKovvuGBHBFXfxX7yhJdGtjQl/ka2yuMODBdW1K 8jk3pI38RWH9u2gLDlL5zv3MI/IH9+tYNgJxC26SR6Hcr0Y19kaGEAExIvgG/6NQ 0qaZ8HmK41X0cJWheYh+M0nWYZR6i+86tJQT0UTYK+1K/AlomTbinxyDR6nLm/Je w3Erpg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1bc00y1f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 11:25:50 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51494d74d4bso5680971cf.1 for ; Fri, 08 May 2026 04:25:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778239549; x=1778844349; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=g0jTW4sKikY/wqz7iN40y6tzI3Wvh1YmdS9omy6vL5s=; b=boagcqmCWiw2H4Faow9chO++NNVT5gOc7EdZ7avybemP2ZMw3Bhmj0oWH6e8uDlRDD ndTHjFXRc7pvwahxtLDK7yawyRQTDi+F/kVIvDlGinrZnU/C/9GNMr1khGovueBKkvsM Ur6FSLRYgT7vpQQ9ZNkJ2LvG6OENYlpuYV9521HnAZBuvVxJlGALMXZfvdKR5laVL8Qx EAjJZHnmLIbeFLda8dXCy7epf0Yor7SwHGGmunX7xMHdrvTeOtx0CozRfWLCA7rjaVz+ ihl2I19/AY8dHwsutDTmae5X7MDQk0HhCX4xlDGRrH7VRuzIRRl78f4OG783kc/E/h0W C1bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778239549; x=1778844349; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g0jTW4sKikY/wqz7iN40y6tzI3Wvh1YmdS9omy6vL5s=; b=VVkTDc/b+hQjHUEpcVifE/JDMTUBVvn2DNo1ju/lrMTCut5VRghzUqJlKbMRgq+4bn KhlB4LwRXlTMnX9zI731BUWxx4DwgRiWGzqr+0eVXWW+SkJHoIBfhOKTQtYu5BLFIfyM AspYkCqN5c3Iypl4RXtRVGMilCOQsevlr7kmCI8AJFrNC8h5FHmXNtAS5dLMqK8YmBI2 CZvOZKQxoleamBfB/I7Er21A/THmxww9TQJsw+P0ztZboGM7kUAIfv7e2aXxnP2qbRzq DxLmkxJZguaHvnIwW1cW1ZEIP7e804P/kDIJEnEInrcnOvxRup7nDc8QP6lhiY4zdoZn Gxrg== X-Forwarded-Encrypted: i=1; AFNElJ83Hpyp1ldf8iQhbIZJHWc8LOLJIQsJ/+iV0/+ZkE+nEkg3GAuzIc5pt2rHNdBaMTRI4Cb4l/lw+IdWzaU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywu/Ho43B0/bK1du92SoasJ2guBnVzTotvxLIKjOCVeoXTmp628 HstlkH4GVDXLaINcZzztIic2i1bYmM3fci/Hrxfx2USICMRWZ3F71bakVeOu8M8ianTB69RvAMO NWrQEYJK0CgWUeomrILEqbCbjHC5jRBH+dQmWu3Z6dF/7ZpyO4ihxmuvTmSL2xD4305w= X-Gm-Gg: AeBDieu5id2D2eaIenehBR0BqmQGH5eVGfcWUULLWbp6mB5r3w9B/J7ejTZf/i3XMzd x8bg4BIVhAKraADkAawxjwrfJIaeEyshJ3T5nBA+rFMh1/7d0ojCwLEj9xbgNT0dij3UJcnOutg hxLBk+XcJzcMbEtIAgQ8/Ynp44KGStkbzdd7WhBJxHIpuvbKbMxBtznwSMQ9jg6F4M/C/dfPQKQ Ry1FyvKXKzTTYfyL7uH7zuFLKk1iJpJzTbofLkZ11LUYz5+QNr5bML61P/CAvvq3nT4Ap7z5jdw 1yKUGIp1v+gKSsBDpixe6LdluV2rVx8GW9ItWrY2mFnrh5Y+KZfx5Q8F5tQ2Pj8wgzDVu5qiwv8 Z6r4r160SQjMKVHQhlP/Y53moIPPKg//nCgub2kzU3YsNLTMh7+S87LXMIC/1kG2pw456VJRgUt QHS3VBukEn+Kkujg+tLdE= X-Received: by 2002:a05:622a:178a:b0:50e:5a1c:d807 with SMTP id d75a77b69052e-51475c1a3eamr83898051cf.27.1778239548937; Fri, 08 May 2026 04:25:48 -0700 (PDT) X-Received: by 2002:a05:622a:178a:b0:50e:5a1c:d807 with SMTP id d75a77b69052e-51475c1a3eamr83897821cf.27.1778239548539; Fri, 08 May 2026 04:25:48 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:1bee:ca9c:164a:a7b3? ([2a05:6e02:1041:c10:1bee:ca9c:164a:a7b3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4548e4bbebdsm4002131f8f.5.2026.05.08.04.25.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2026 04:25:47 -0700 (PDT) Message-ID: Date: Fri, 8 May 2026 13:25:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] thermal/core: Split __thermal_cooling_device_register() into two functions To: Lukasz Luba Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, rafael@kernel.org References: <20260505144447.2853933-1-daniel.lezcano@oss.qualcomm.com> <96515043-d9be-475e-81ba-71a8fbeeaedd@arm.com> <70f2b2b4-6066-4c48-8834-b907b5146a08@arm.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <70f2b2b4-6066-4c48-8834-b907b5146a08@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDExOCBTYWx0ZWRfX4xjBQ0fj8ipk bssqCohTuesEPLeBK5UpXq2sI52AdTHVYUhljs7jGIkb2xsC4OAx5AaekiiVq8+emP+v+nLAOjN 8gsgJTXWmPOGXIjtl50pfb/WTefp0Etr9dH7FiU65QpBmIaho/diJibuuylcQdSZet2uFAkQmd3 Tm6aGXMrclS5wJBBvtctWX0raRnat/CGlYqrR3tyLfgMGeYipZG5xRxdDVX5W0VpIhvALX1bvpI BphELb7U6092t3Xwc76q6pg77dGZm1XbgD5PdybW7n0dxBl3j9CbcpOhTWEV+nR4nZYstPDlVob uh3MeUXcsarPhcyboB1HrDIUhTzW1zff24XTgKDKyhDjwahNKObThYlHtH4YT8Po0pkrmG3K2wh fHQAYzps7Nn4SrIP1trYeSVnqxNY8/YnvxRxfGRRzV09jgvH2KlrORkQPI8pYt1pl4Wz2swOqFE oqHDhkE3rElJW/XZO/g== X-Proofpoint-GUID: ZX8yf1dzot3DEk3uLHv73IkcUogf0GgJ X-Authority-Analysis: v=2.4 cv=JJQLdcKb c=1 sm=1 tr=0 ts=69fdc83e cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=cq08qmKiVzzLYLijMZEA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: ZX8yf1dzot3DEk3uLHv73IkcUogf0GgJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080118 On 5/8/26 12:35, Lukasz Luba wrote: > > > On 5/7/26 19:26, Daniel Lezcano wrote: >> On 5/7/26 12:02, Lukasz Luba wrote: [ ... ] > I would call them explicitly in case of 'if(ret)' > error from dev_set_name()... > Then the rest could end in case of error with that new > 'put_device()' logic at the bottom. > Would you agree? > > A different option would be to refactor thermal_release() > and somehow recognize the cooling device not based on name. This mechanism is not adequate. thermal_release should not be used this way, neither it should be needed. We should have: thermal_class = class_create("thermal"); if (IS_ERR(thermal_class)) ... No thermal_release needed. But, static void cooling_dev_release(struct device *dev) { thermal_cooling_device *cdev; cdev = to_cooling_device(dev); thermal_cooling_device_destroy_sysfs(cdev); kfree_const(cdev->type); ida_free(&thermal_cdev_ida, cdev->id); kfree(cdev); } static void tz_dev_release(struct device *dev) { thermal_zone_device *tz; tz = to_thermal_zone(dev); thermal_zone_destroy_device_groups(tz); thermal_set_governor(tz, NULL); ida_destroy(&tz->ida); mutex_destroy(&tz->lock); complete(&tz->removal); } In thermal_cooling_device_add() { ... cdev->device.release = cooling_dev_release ... } In thermal_zone_device_register_with_trips() { ... tz->device.release = tz_dev_release ... }