From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B934D23D7E6 for ; Tue, 12 May 2026 00:55:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.132 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778547311; cv=none; b=imPMTwT2631mtwIVx8hOQ5JvaSRl8kWF9k8P9pl3Zr3k2vKnu5o0UEtVTT462uPFLzdzG6YxrPxMBaeV1tPoXS8dO8whL/cIf0FE3LbAiqTP0TGJs4DNkI17j88iOGTsQXqdBAS1gDxsmnCc17VMCYjcr+9n8PSmAZXZzLgycY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778547311; c=relaxed/simple; bh=UN261jqcoK0p99m7xl+N1wLa9ZxWtx0cE7pCtvpR2/w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W/Qf4keTh/9vs+X0dp9+aoYbH8nZ5/cBm7G32nbb50pfvZ1qP8w4GsSBeHlcReOTPrmUs5e2oRkxL5hS2eRUMqE4BxqZCUGSyYVxxA6+m2g3DnZK+gsZiQZyiT+ZJJMJomsawfUHQo9eWlrYOHbbVbP4HCoqpsz0zmswr/OM27k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=xJ7eiC5y; arc=none smtp.client-ip=115.124.30.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="xJ7eiC5y" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1778547306; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=N/KLe3Yts3q+6w5dMQr/xNmnwmQSv/P07HQ1TqjvMRk=; b=xJ7eiC5yDfgtecqtzpEHNv8NlHOm2GyCzKQS8C/NGXyM5RlSDYXpoVw5l2UN1ytx4KT2q54njEjsLv+6v2OnAdYqxScSTqe+2eRcKFSITlo47T+TBhNmzAstCrkBWJZpl/btJNAeM1+GlG+qfhNq7IMrDcmFDs5rH6dc2FrMZds= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R901e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037026112;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0X2oYab._1778547305; Received: from 30.74.144.137(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0X2oYab._1778547305 cluster:ay36) by smtp.aliyun-inc.com; Tue, 12 May 2026 08:55:05 +0800 Message-ID: Date: Tue, 12 May 2026 08:55:05 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Revert "tmpfs: don't enable large folios if not supported" To: Andrew Morton , Lorenzo Stoakes Cc: hughd@google.com, willy@infradead.org, ziy@nvidia.com, david@kernel.org, lance.yang@linux.dev, wangkefeng.wang@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260511150158.921c0ac72b31a6fa0a125ab8@linux-foundation.org> From: Baolin Wang In-Reply-To: <20260511150158.921c0ac72b31a6fa0a125ab8@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/12/26 6:01 AM, Andrew Morton wrote: > On Mon, 11 May 2026 13:03:04 +0100 Lorenzo Stoakes wrote: > >> On Wed, May 06, 2026 at 04:58:20PM +0800, Baolin Wang wrote: >>> >>> >>> On 5/5/26 6:47 PM, Lorenzo Stoakes wrote: >>>> On Tue, May 05, 2026 at 11:46:11AM +0100, Lorenzo Stoakes wrote: >>>>> Acked-by: Lorenzo Stoakes >>>>> >>>>> As David asked, should we have a Fixes tag? What about cc: stable? >>> >>> Sure. But this fix tag depends on the commit 665575cff098b, so the fixes tag >>> should be: >>> >>> Fixes: 5a90c155defa ("tmpfs: don't enable large folios if not supported") >>> Depends-on: 665575cff098b ("filemap: move prefaulting out of hot write >>> path"). >> >> Oh is Depends-on a tag? Wasn't aware of it :>) > > It is not. > > hp2:/usr/src/25> grep -ri Depends-on Documentation | wc -l > 0 > > But it is! > > hp2:/usr/src/25> grep -ri Depends-on ../gitlog | wc -l > 156 > > I actually removed it because a) various tools whine at me and b) we > didn't cc:stable anyway. Okay, I remember I've seen that tag :) > > Please let's not add new metadata without having told others what that > metadata means? > > "Fixes:" should be sufficient. I interpret Fixes: as "apply this to any > kernel which contains ". Is more needed? My concern is that if someone backports this patch to an older kernel version without also backporting commit 665575cff098b, it would cause a performance regression. Is there a good way to mark this kind of dependency on another patch? But I've already described this potential dependency in the commit message, so I'm fine with just adding the "Fixes:" tag.