From: Carsten Haitzler <Carsten.Haitzler@arm.com>
To: Diederik de Haas <didi.debian@cknow.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] Script style improvements in lib/coresight.sh
Date: Thu, 2 Feb 2023 08:38:46 +0000 [thread overview]
Message-ID: <b13301b1-104f-ebb5-6b2a-3d6cc3eba8a3@arm.com> (raw)
In-Reply-To: <20230201214945.127474-1-didi.debian@cknow.org>
On 2/1/23 21:49, Diederik de Haas wrote:
> These 2 patches improve the efficiency and quality of the
> lib/coresight.sh script.
>
> The first one uses grep's `-c` parameter to count the results instead of
> piping it to `wc -l`.
> The second one replaces the use of backticks (`...`) with $(...) as the
> former has several potential issues while the latter does not.
>
> Diederik de Haas (2):
> perf test: Replace 'grep | wc -l' with 'grep -c'
> perf test: Replace legacy `...` with $(...)
>
> tools/perf/tests/shell/lib/coresight.sh | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
ACK to all of this series.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2023-02-02 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 21:49 [PATCH 0/2] Script style improvements in lib/coresight.sh Diederik de Haas
2023-02-01 21:49 ` [PATCH 1/2] perf test: Replace 'grep | wc -l' with 'grep -c' Diederik de Haas
2023-02-01 21:49 ` [PATCH 2/2] perf test: Replace legacy `...` with $(...) Diederik de Haas
2023-02-02 1:53 ` [PATCH 0/2] Script style improvements in lib/coresight.sh Arnaldo Carvalho de Melo
2023-02-02 8:38 ` Carsten Haitzler [this message]
2023-02-02 13:00 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b13301b1-104f-ebb5-6b2a-3d6cc3eba8a3@arm.com \
--to=carsten.haitzler@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=didi.debian@cknow.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox