From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF1941F12E9 for ; Thu, 26 Mar 2026 02:31:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774492267; cv=none; b=cFVQi1uRU3hhv9gTkC4pB0U39vYLpTTA0nAkbW4mjQ+sxGfgHosS6NmO5oPV7FEGDrGBDmB/tXG+IBi6l2kQLMuJj+P+0r+Kr6o7wJYv+zhTxeT8sQl5uDe4c/nCbBGEiGwee64w1ATKHa58huRhQe7d6775egJC5UhJlLldYMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774492267; c=relaxed/simple; bh=1luHTjr8ISZj/JtJBLwaNEaHlIFIG7hcmwlKfkRBWDw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lx0leiv1FVUWyg5X8XrxcXO1Nvm9GuTk7+k90y3kEYBX6jFwbuLaXS6xAnVtoUIu7UH4stLiMNOyaPkn4Sjx/h2FS9iEC3ubA70EUgCoM7/h5h7ZcSxlJPnO2T5cHxY495V4aJSjBlrRKgsAaE4C7dQYWXNktmOZs/vHycbSOY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NAjgbQZP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NAjgbQZP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6CDCC4CEF7; Thu, 26 Mar 2026 02:31:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774492267; bh=1luHTjr8ISZj/JtJBLwaNEaHlIFIG7hcmwlKfkRBWDw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NAjgbQZP9xdyldpkB7+1mA8zi3L5NCsPIhg5//cvdFEbAvqGcM84Pv3r2h/eqbtiA Cu/EqHLRhPSKtVpdVuTY/f5utJlgzChvesqqEPtr3Et13PXBplWut7mHNXTZYO4Mdd kb/ZWlrvb/+ewvySSYWeQYaK9w99HD8OaEth0xSMST/lqxP6K4yfT3J2NvARsQ4Vjg oiSQ1Xm9RSKkoF/Ur0Tphmp6E8PR2Ej1Oa8hTfPZxQEUZfOSKfSKztgn2fOLjzfg4H 9GvwmgY3H8AUP414a4VtPWf7z3hJeYnuKj7L/6JYcO0i5Jjwp+1GS8WevM9sPs1BHV /sahA8BClidaA== Message-ID: Date: Wed, 25 Mar 2026 21:31:05 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1] accel/amdxdna: Fix leak when pinning ubuf pages To: Lizhi Hou , ogabbay@kernel.org, quic_jhugo@quicinc.com, dri-devel@lists.freedesktop.org, maciej.falkowski@linux.intel.com Cc: Max Zhen , linux-kernel@vger.kernel.org, sonal.santan@amd.com References: <20260326010642.2596525-1-lizhi.hou@amd.com> Content-Language: en-US From: Mario Limonciello In-Reply-To: <20260326010642.2596525-1-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/25/26 20:06, Lizhi Hou wrote: > From: Max Zhen > > When pin_user_pages_fast() returns fewer pages than requested, the pages > that were successfully pinned are not released, leading to a leak. > > Fix this by unpinning any partially pinned pages before returning failure. > > Fixes: bd72d4acda10 ("accel/amdxdna: Support user space allocated buffer") > Signed-off-by: Max Zhen > Signed-off-by: Lizhi Hou Reviewed-by: Mario Limonciello (AMD) > --- > drivers/accel/amdxdna/amdxdna_ubuf.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/accel/amdxdna/amdxdna_ubuf.c b/drivers/accel/amdxdna/amdxdna_ubuf.c > index fb999aa25318..4c0647057759 100644 > --- a/drivers/accel/amdxdna/amdxdna_ubuf.c > +++ b/drivers/accel/amdxdna/amdxdna_ubuf.c > @@ -196,13 +196,17 @@ struct dma_buf *amdxdna_get_ubuf(struct drm_device *dev, > ret = pin_user_pages_fast(va_ent[i].vaddr, npages, > FOLL_WRITE | FOLL_LONGTERM, > &ubuf->pages[start]); > - if (ret < 0 || ret != npages) { > - ret = -ENOMEM; > + if (ret >= 0) { > + start += ret; > + if (ret != npages) { > + XDNA_ERR(xdna, "Partially pinned pages %d/%u", ret, npages); > + ret = -ENOMEM; > + goto destroy_pages; > + } > + } else { > XDNA_ERR(xdna, "Failed to pin pages ret %d", ret); > goto destroy_pages; > } > - > - start += ret; > } > > exp_info.ops = &amdxdna_ubuf_dmabuf_ops;