From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3B60E94117 for ; Fri, 6 Oct 2023 20:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233578AbjJFUrj (ORCPT ); Fri, 6 Oct 2023 16:47:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233599AbjJFUr3 (ORCPT ); Fri, 6 Oct 2023 16:47:29 -0400 Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3CE0122 for ; Fri, 6 Oct 2023 13:47:23 -0700 (PDT) Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTP id oqrcqUmOBQUgRorjHqRZOX; Fri, 06 Oct 2023 20:47:23 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id orjGq1E4Pbl9BorjHq8ZYV; Fri, 06 Oct 2023 20:47:23 +0000 X-Authority-Analysis: v=2.4 cv=Q6bBXq6a c=1 sm=1 tr=0 ts=6520725b a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=Dx1Zrv+1i3YEdDUMOX3koA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=bhdUkHdE2iEA:10 a=wYkD_t78qR0A:10 a=QyXUC8HyAAAA:8 a=pGLkceISAAAA:8 a=VwQbUJbxAAAA:8 a=e5mUnYsNAAAA:8 a=NEAV23lmAAAA:8 a=cm27Pg_UAAAA:8 a=0yL73Cyy68KADmUz8mEA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=Vxmtnl_E_bksehYqCbjh:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gxo07NLXbFSWfnqQOYpGIbOTWGu4BVeTP7jYHXk3874=; b=JgvHqPHiQMKYNI1XgUZo7Vh4Jd lzqNacFRqbSwkSzk2FyX9NNJU/aDOHERlwXSRnHZXIYsgoFxAja3vpwycTCx5G6Yss9QnHwKGkZpY as2tH0Qc3DKLw2Z4WpDBbH5MEnp/6euZtMQ+FAAmPvBHlqjrzXPaF5+Q0mDdEklwwKo98WarQQyaE qEA5xEP/nw9GVWFgAB575gMdU4X0Dzde4Xl3/6XVVJHr/o3yi909a6bU9wdnx7a3mVCEZzOQ9O29E ig63PqVUEbMRKvevRwLYWpXG9+kVynfbyJ4jPZsu7S1+miYK4KzQqkBwj6ZYFtMxdu7Z3eGbyA4mW zPOn6Yug==; Received: from 94-238-9-39.abo.bbox.fr ([94.238.9.39]:47408 helo=[192.168.1.98]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.1) (envelope-from ) id 1qorjE-001Bge-09; Fri, 06 Oct 2023 15:47:20 -0500 Message-ID: Date: Fri, 6 Oct 2023 22:47:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/i915/guc: Annotate struct ct_incoming_msg with __counted_by Content-Language: en-US To: Kees Cook , Jani Nikula Cc: Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , "Gustavo A. R. Silva" , John Harrison , Matthew Brost , Michal Wajdeczko , Matt Roper , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-hardening@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , Andi Shyti , Nirmoy Das , Jonathan Cavitt , Fei Yang , linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20231006201744.work.135-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20231006201744.work.135-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 94.238.9.39 X-Source-L: No X-Exim-ID: 1qorjE-001Bge-09 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 94-238-9-39.abo.bbox.fr ([192.168.1.98]) [94.238.9.39]:47408 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 45 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOe42buIrwcF2nGuCZ21Be2UPY6BFIykQreMG5evDvQcbsdeBKl4sOGVEw6q5jh753Vv9uMbRfoO5J037f7Y0OZ4LQ9vI77ToHekYtSl5oxiZ9s7YdU3 Fe1kISvxvTxsC4TxjyxZeT524STZ7qoBhEF4/ZxBsdPepWMtmdmDLoruV++T8Fjg6FpEEPeJy8AOLroRkiPqJVKLE1RE6L5s1Vo71s17i4kfj+50BiNDUxZc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/6/23 22:17, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for > array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct ct_incoming_msg. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: David Airlie > Cc: Daniel Vetter > Cc: "Gustavo A. R. Silva" > Cc: John Harrison > Cc: Matthew Brost > Cc: Michal Wajdeczko > Cc: Matt Roper > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-hardening@vger.kernel.org > Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1] > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks! -- Gustavo > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > index 6e22af31513a..c33210ead1ef 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > @@ -96,7 +96,7 @@ struct ct_request { > struct ct_incoming_msg { > struct list_head link; > u32 size; > - u32 msg[]; > + u32 msg[] __counted_by(size); > }; > > enum { CTB_SEND = 0, CTB_RECV = 1 };