public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Rui" <rui.zhang@intel.com>
To: "david@fromorbit.com" <david@fromorbit.com>,
	"djwong@kernel.org" <djwong@kernel.org>,
	"Tang, Feng" <feng.tang@intel.com>
Cc: lkp <lkp@intel.com>, "Huang, Ying" <ying.huang@intel.com>,
	"Yin, Fengwei" <fengwei.yin@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
	"Sang, Oliver" <oliver.sang@intel.com>,
	"dchinner@redhat.com" <dchinner@redhat.com>,
	"oe-lkp@lists.linux.dev" <oe-lkp@lists.linux.dev>
Subject: Re: [linus:master] [xfs]  2edf06a50f:  fsmark.files_per_sec -5.7% regression
Date: Tue, 16 May 2023 03:07:56 +0000	[thread overview]
Message-ID: <b14bc8d1c2652ffc5e35b68279ee36ecadbfa83b.camel@intel.com> (raw)
In-Reply-To: <ZGLuea93wBdzJipX@feng-clx>


> > > Also for the turbostat.Bzy_MHz diff, IIUC, 0Day always uses
> > > 'performance' cpufreq governor. And as the test case is running
> > > 32 thread in a platform with 96 CPUs, there are many CPUs in idle
> > > state in average, and I suspect the Bzy_MHz may be calculated 
> > > considering those cpufreq and cpuidle factors.
> > 
> > If "busy MHz" includes the speed of idle CPUs, then it's not really
> > a measure of the speed of "busy" CPUs. If what you say is true,
> > then
> > it is, at best, badly names - it would just be the "average Mhz",
> > right?
> 
> I found the turbostat.c in kernel tree tools/power/x86/turbostat/
> 
> if (DO_BIC(BIC_Bzy_MHz)) {
> 	if (has_base_hz)
> 		outp +=
> 		    sprintf(outp, "%s%.0f", (printed++ ? delim : ""),
> base_hz / units * t->aperf / t->mperf);
> 	else
> 		outp += sprintf(outp, "%s%.0f", (printed++ ? delim :
> ""),
> 				tsc / units * t->aperf / t->mperf /
> interval_float);
> }
> 
> Rui Zhang told me the 'aperf' is the actual cpu cycles of a CPU in a
> period of time, and it only count when CPU is in C0 state, and will
> stop counting when cpu is in idle power state. Like in one second
> interval, if the CPU spends 500 ms running at 1000 MHz, and the other
> 500 ms in idle, then the Bzy_MHz will be shown 500 MHz.

Bzy_MHz will show 1000 MHz because it is the actual frequency when CPU
is in C0.
Avg_MHz will show 500 MHz because it is the average frequency including
the CPU idle time.

thanks,
rui


      reply	other threads:[~2023-05-16  3:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09  2:13 [linus:master] [xfs] 2edf06a50f: fsmark.files_per_sec -5.7% regression kernel test robot
2023-05-09  6:54 ` Dave Chinner
2023-05-09  7:10   ` Dave Chinner
2023-05-12  7:44     ` Oliver Sang
2023-05-12 23:05       ` Dave Chinner
2023-05-14 14:36         ` Feng Tang
2023-05-15 16:57           ` Darrick J. Wong
2023-05-15 22:20           ` Dave Chinner
2023-05-16  2:46             ` Feng Tang
2023-05-16  3:07               ` Zhang, Rui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b14bc8d1c2652ffc5e35b68279ee36ecadbfa83b.camel@intel.com \
    --to=rui.zhang@intel.com \
    --cc=david@fromorbit.com \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=feng.tang@intel.com \
    --cc=fengwei.yin@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox