From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f227.google.com (mail-dy1-f227.google.com [74.125.82.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BFE738E113 for ; Mon, 6 Apr 2026 17:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775495459; cv=none; b=PciO53N6roigQuDR/90M0ZrbOWS21v5oh9t9yeFZeC3WU4dfAbcwVXfOi0nE/yc6Cm3FgZcjoA3giEKOEQFNCIyj/hXRZUxlJlyOc67SKemWZyHVHgH4FumOhYGmGASsrOmuqgTnCkV011O6Pm3Qoxv6GPnQeazv1+M36GWBTA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775495459; c=relaxed/simple; bh=0pSdF7qltzIaD1F67lD5KMoay4WFPkbvj35zXCBItfM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GlU187aKBaqFHdA3XfruZSoDEwPKNJkBE+WjscxGKhBoPz42EZa19r0BBpR67QucbH+EeUkrJEy29jf32Rl+uNTWbzTyKMACAAdQWUpz6xlgN5ReXN98BBqqLs/qivjZublFUd7mZrUXLjLOv4zdLp//7dR0vTuaz+ZeJMwWUCs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Tn8/yZcQ; arc=none smtp.client-ip=74.125.82.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Tn8/yZcQ" Received: by mail-dy1-f227.google.com with SMTP id 5a478bee46e88-2b6b0500e06so5850601eec.1 for ; Mon, 06 Apr 2026 10:10:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775495457; x=1776100257; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WKkwSkgrg54xnZM99atDwyoSjpHQ8ks+nFdiA1+lKEI=; b=dAyZuqm1zW0DH08Zw5jlODKV5v3etKc8+j6Dn/vH0xX6NQr2ieCtOvxEUSrg3q5F3L bK5dUVEKPFa3learVoPReHdIuxAa2ta9sHuenE8tySc/ahYsxF9i5vrvJUprltTXpE1F pGnVVw+fwYVsBZvCGRXwyfcnrMDYLLqG6wMVxTqza/UR1eKfl9UUaLIqOB3p0nxTVCVB 3FwIk5zxNL1c+ukkD9+6noDbP9dS4CeLo50C+w5sjh1X8/7+8Amuh93v6wLtVh28HwHe Ct9D650lxwYw5BusW7Czu9jHpq+qbQU/B7i3gJMDJ2eWXGCu4RI8UHt30/C8Y0kJVZ0M nDPA== X-Forwarded-Encrypted: i=1; AJvYcCVPdDJGN6Jr06nomxb8qg4pGTHHFQlHPIeyPE5wlb7g52urmmzSsy8aBWpWSb/SbzGntzqegWJIO9y69Kc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc/v4/K/DlTpXyRwSb+vOSLJgUT5Mez2e93A7umF4Kynsa+Z/+ SWZKKCMUWEFsdoXmWzV8X86hrt6E6QQ6DEOuzQBH65AJwTPwE5iJ4EuncDI+nuc32e1+hKG77D4 pREMuGjU+XCfuQ04nXzfCoWqsoqR/8+fgiZp4X8eRRvwBmX8vTq1L9x6EGcQLrLr7EGTNpg77v/ 34a6cjtziHjyoOeJElcy6hViz8RxE6rFMRXJJqNuD/zdxsfdcsFN1cnnbcwVgBeCqFOGQM+uMYt K94U7R6s/JI32qk/ZMtsPx+ X-Gm-Gg: AeBDieukZ71uqsZHnI2VsakbOmabvxImml/9y1VLloFVVzDGVpQvLeqK8yWoiNEFhEK FaR9gdoU5zW7eBPlCpmjvol9aUvMPmlTTOvwRvWwFFmN3l19e/iL7ucslS+85ISo/Yu8oZntA3U l5gkEWU8NOXYDdKBpMoSIbc6OX42SRPa2CO7GNT8q0X2xW2+kx3Ts0V3LXhPRCsOELsKCBDcbB1 8yaDSaKlppULr3lO0sdGu6PAdBQ6AkaieNgd0EUuxLyvw3Ip0qS+53ccYdbY8mEpHy4gmcF1jLE TiWqFKphStcjRwlZ3ZfKhdzZYKHNwwkc1GMPYQPXO3zSevhpzapuGGWiOVqy4SAlHeaJeDnE//9 zWCBlWHyo/g6ZJKBtraB9Tt9w3oGNA82xNH/Qmk0K4v4ijFKDiCrdEbNj6E+khlmeFHIIuWfzOV 4IGM8DzdeDstkA3y6JqnKts1n/oA4KYHzaPH0NW+kZba3TRSr7JRjxX/g7sYUd/Q== X-Received: by 2002:a05:7300:a887:b0:2c7:3a7:c7b6 with SMTP id 5a478bee46e88-2cbf9af8f07mr5585099eec.6.1775495457192; Mon, 06 Apr 2026 10:10:57 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-24.dlp.protect.broadcom.com. [144.49.247.24]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-2ca793ef4b8sm977956eec.7.2026.04.06.10.10.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Apr 2026 10:10:57 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2c16233ee11so5888967eec.1 for ; Mon, 06 Apr 2026 10:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1775495455; x=1776100255; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=WKkwSkgrg54xnZM99atDwyoSjpHQ8ks+nFdiA1+lKEI=; b=Tn8/yZcQ/Zk+n94wNRTff1sSuor6U3xXTYHJpMDVdbB4ilFYgYz7g0LgaVxDuu6HzP 8KVvAg8KwS0tjKHQv9DatkfT2OEhgzRSEy3cE5PNO/xSw99AKSrrmg6S5Y49oh/0LeVc rINpPA5hQ5HGO/wQAQn45PmRkUNW4eoIbxrF8= X-Forwarded-Encrypted: i=1; AJvYcCXycriquAzvoVd7/1/fp9DI11uApQiyGRrQJb4R8ArGgmu8eEbnUzTujQkLqlFX/AJ2EAHPxKuwR3eGnyo=@vger.kernel.org X-Received: by 2002:a05:693c:2c93:b0:2d0:239a:23cb with SMTP id 5a478bee46e88-2d0239a26famr1645179eec.16.1775495455383; Mon, 06 Apr 2026 10:10:55 -0700 (PDT) X-Received: by 2002:a05:693c:2c93:b0:2d0:239a:23cb with SMTP id 5a478bee46e88-2d0239a26famr1645139eec.16.1775495454438; Mon, 06 Apr 2026 10:10:54 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2cf2be19f85sm5763478eec.30.2026.04.06.10.10.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 10:10:53 -0700 (PDT) Message-ID: Date: Mon, 6 Apr 2026 10:10:49 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 1/7] net: bcmgenet: convert RX path to page_pool To: Nicolai Buchwitz , netdev@vger.kernel.org Cc: Justin Chen , Simon Horman , Mohsin Bashir , Doug Berger , Broadcom internal kernel review list , Andrew Lunn , Eric Dumazet , Paolo Abeni , "David S. Miller" , Jakub Kicinski , Vikas Gupta , Bhargava Marreddy , Rajashekar Hudumula , Arnd Bergmann , Fernando Fernandez Mancera , =?UTF-8?Q?Markus_Bl=C3=B6chl?= , linux-kernel@vger.kernel.org References: <20260406083536.839517-1-nb@tipi-net.de> <20260406083536.839517-2-nb@tipi-net.de> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260406083536.839517-2-nb@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 4/6/26 01:35, Nicolai Buchwitz wrote: > Replace the per-packet __netdev_alloc_skb() + dma_map_single() in the > RX path with page_pool, which provides efficient page recycling and > DMA mapping management. This is a prerequisite for XDP support (which > requires stable page-backed buffers rather than SKB linear data). > > Key changes: > - Create a page_pool per RX ring (PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV) > - bcmgenet_rx_refill() allocates pages via page_pool_alloc_pages() > - bcmgenet_desc_rx() builds SKBs from pages via napi_build_skb() with > skb_mark_for_recycle() for automatic page_pool return > - Buffer layout reserves XDP_PACKET_HEADROOM (256 bytes) before the HW > RSB (64 bytes) + alignment pad (2 bytes) for future XDP headroom > > Signed-off-by: Nicolai Buchwitz Reviewed-by: Florian Fainelli Tested-by: Florian Fainelli -- Florian