From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0850925CC40 for ; Thu, 9 Oct 2025 05:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759988476; cv=none; b=hb5zi9JTlp+XeOo5UgMAVOeCfGfjEv5TPU0OTQHYPswuS9r3OMU0lBhHUsxK9a1eGyNNx2P8TLW5wMZ92mydXEAFs8UAZ5DZFe7cRXD0q4+PPSNU8/oHg4S89u1JkH1Z0W/nYZcCi0sWb/gZjR+7BGCvD4qOB1LUuC2WQsCXZ+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759988476; c=relaxed/simple; bh=U7g6KkV2IFnVrQikZSPZ1dcFlLVplBkp4l5QFbLACbQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K/ST42A7juC8HYg74gksKj0ZcaKOouRofGNM2HZmWNEuHe5Oct7jf5v94tPY5IgyyI/UP4UUG5SUmZ81onwUNEmx55ph6wPIIe5MQXwuaPwZ0aVJGXdIQoFF0yKxfCvKCsuldRSEKFj3vxO4qeYPT6qbOBFRQwBLkhRpSvcNzKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MlPROR1Q; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MlPROR1Q" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-76e2ea933b7so545430b3a.1 for ; Wed, 08 Oct 2025 22:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759988474; x=1760593274; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2KNKsCp2Ww11qIKHJ00jyA6DJfSKlBk9NjUhCjdbmcc=; b=MlPROR1QdnJHwGy1Pxg4JeitOCx4xPZ2WhXHglt5lweA0bH0o/v4/1caXnWkLlawc4 CTxMj/Bmp0FaQdZhkbY4lQCAhtLI/tKE8sZVGwhs62ltgn0tZcTKl3mrOMx9lFDcZzfT NE1ROT2vqqH3Atw8RabGiN/fM+v5nVkGKoRywHpwSGGjNgE+5riBjgoEtCoL7HE1k6lq OZDc4F1GK8QWJKa9uPH2vjDkhKP5DN3L7G1ajvBNqnN2BIFDHlEzhPEBBsHw9QSRnGk6 pEC1tZZUK5iMIce0X/W1iY9zNdvfs97QceSw+cFwKV3nAZcDJoN/wBwFI0ZgbdnuJgKn nQ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759988474; x=1760593274; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2KNKsCp2Ww11qIKHJ00jyA6DJfSKlBk9NjUhCjdbmcc=; b=KA678cDJhOQHmm1J8OlxR/rvlJKAS/H6TsZJeCInv7lvLDewZdCj7fHQElfx0wTC83 hpYxFzjN6zfkcPm7h9SJHbX8xymuLy3OFGZP+A27GKyQ2Yzj41EJATlAJXURB6P3KxUF VLH2uBAqc0mBTewCSP0095ffLKv/GrItEfCZ7yGcvK0v7XEK09oEj40OGIgcwe+wcr2x lTgAlBEashXja7MRyR7B57rHu6FTfez0szc40iAzF1BAK1QTHDz5PTObF+kRPdWUXQ09 AQniyqNK+Bp3cmfyzufKJiBIwMLUH0cAk8NmVU3naAFBCMLBBUJ78XJkbiD72+FMgjPS 3n8Q== X-Forwarded-Encrypted: i=1; AJvYcCX4zTU4ZH6xZ2XCBXy/RDfsSDdg4HOlfV7QA9wK4EppE+7vjjV8C6TgJK1Q2siK00cH5K4Syy2kbh3riCg=@vger.kernel.org X-Gm-Message-State: AOJu0YxPhKGxMX4jhRLViQf1L5g+ozHbkbLMQzGKFf/+F3bOoPvc+HI1 MP+VWGAgViy6a/FISaA47BPe8JvRqel62pYpJcs7TarOV5t2EinkK9zM X-Gm-Gg: ASbGncuD92QVxTssjEdtDGmWUW2O3YtZ3vjpELQqVjeCWnFCv/9Up8pc7VjMzjTpbHJ fT5Ew3Axqx9DZ3TNld9hFxofnV/2kLCo9Sd9p9lyd/MlzgQxT6sjmmJmSIcvGm4+R9kn8t1BnGy 9C1qgeVSyI+CqUHrQbQ8nplGnUmGPyDt0sLZeL/V7gGkshPMB3WIK1egFbFNDCOC7Vd3ij8ZiSg Q3SBKW1/VyV5zkNlctwFLu+gQvbhVQ+fVvB49I7dLJLW1+6cReM0d1kmWkGqenUI2wjElu5Oj+0 jeA0oYIUhRT3cy8M2Wva0FH8zhHoSMrY6kY9EzK9lCwD8t7bIj8WojD6HshpP2R8w/tmE6GwEE8 OI9Z6mK+PF5cFfpBsUTiB5SWkz06uaqSY03YG3rwDcenF5ZhsJZRFRbxlfaY+XSrvcoE= X-Google-Smtp-Source: AGHT+IE9oykuetNbvR+7em1eWM6yMVpGn5cles1cEeIi0mcRnMwvIGU8Ccu1Dh5yRdwJE+IrZiL2mg== X-Received: by 2002:a05:6300:7110:b0:32d:b924:f90e with SMTP id adf61e73a8af0-32db9251bfdmr3011937637.29.1759988474177; Wed, 08 Oct 2025 22:41:14 -0700 (PDT) Received: from [10.0.2.15] ([14.98.178.155]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b6099f3b041sm19842042a12.24.2025.10.08.22.41.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Oct 2025 22:41:13 -0700 (PDT) Message-ID: Date: Thu, 9 Oct 2025 11:11:08 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: usb: lan78xx: Fix lost EEPROM write timeout error(-ETIMEDOUT) in lan78xx_write_raw_eeprom To: Thangaraj Samynathan , Rengarajan Sundararajan , UNGLinuxDriver@microchip.com, Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Oleksij Rempel Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, khalid@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, stable@vger.kernel.org References: <20251009053009.5427-1-bhanuseshukumar@gmail.com> Content-Language: en-US From: Bhanu Seshu Kumar Valluri In-Reply-To: <20251009053009.5427-1-bhanuseshukumar@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/10/25 11:00, Bhanu Seshu Kumar Valluri wrote: > The function lan78xx_write_raw_eeprom failed to properly propagate EEPROM > write timeout errors (-ETIMEDOUT). In the timeout fallthrough path, it first > attempted to restore the pin configuration for LED outputs and then > returned only the status of that restore operation, discarding the > original timeout error saved in ret. > > As a result, callers could mistakenly treat EEPROM write operation as > successful even though the EEPROM write had actually timed out with no > or partial data write. > > To fix this, handle errors in restoring the LED pin configuration separately. > If the restore succeeds, return any prior EEPROM write timeout error saved > in ret to the caller. > > Suggested-by: Oleksij Rempel > Fixes: 8b1b2ca83b20 ("net: usb: lan78xx: Improve error handling in EEPROM and OTP operations") > cc: stable@vger.kernel.org > Signed-off-by: Bhanu Seshu Kumar Valluri > --- > Note: > The patch is compiled and tested using EVB-LAN7800LC. > The patch was suggested by Oleksij Rempel while reviewing a fix to a bug > found by syzbot earlier. > The review mail chain where this fix was suggested is given below. > https://lore.kernel.org/all/aNzojoXK-m1Tn6Lc@pengutronix.de/ > > ChangeLog: > v1->v2: > Added cc:stable tag as asked during v1 review. > V1 Link : https://lore.kernel.org/all/20251004040722.82882-1-bhanuseshukumar@gmail.com/ > > drivers/net/usb/lan78xx.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c > index d75502ebbc0d..5ccbe6ae2ebe 100644 > --- a/drivers/net/usb/lan78xx.c > +++ b/drivers/net/usb/lan78xx.c > @@ -1174,10 +1174,13 @@ static int lan78xx_write_raw_eeprom(struct lan78xx_net *dev, u32 offset, > } > > write_raw_eeprom_done: > - if (dev->chipid == ID_REV_CHIP_ID_7800_) > - return lan78xx_write_reg(dev, HW_CFG, saved); > - > - return 0; > + if (dev->chipid == ID_REV_CHIP_ID_7800_) { > + int rc = lan78xx_write_reg(dev, HW_CFG, saved); > + /* If USB fails, there is nothing to do */ > + if (rc < 0) > + return rc; > + } > + return ret; > } > > static int lan78xx_read_raw_otp(struct lan78xx_net *dev, u32 offset, Hi, The subject prefix must be [PATCH v2] instead. I overlooked it. Should I resend it? Regards, Bhanu Seshu Kumar Valluri