The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: duchangbin <changbin.du@huawei.com>
To: duchangbin <changbin.du@huawei.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	Valentin Schneider <vschneid@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/cputime: remove unused vtime_account_kernel
Date: Thu, 11 Apr 2024 12:05:48 +0000	[thread overview]
Message-ID: <b1befac0501944919cd99f20c4bcecaa@huawei.com> (raw)
In-Reply-To: <20240411112212.2061899-1-changbin.du@huawei.com>

The vtime_account_idle() can also be removed. Will update this change.

On Thu, Apr 11, 2024 at 07:22:12PM +0800, Changbin Du wrote:
> This removes the vtime_account_kernel() function in generic vtime
> accounting. It's never used anymore.
> 
> Signed-off-by: Changbin Du <changbin.du@huawei.com>
> ---
>  kernel/sched/cputime.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
> index af7952f12e6c..29320e66abdc 100644
> --- a/kernel/sched/cputime.c
> +++ b/kernel/sched/cputime.c
> @@ -709,18 +709,6 @@ static void __vtime_account_kernel(struct task_struct *tsk,
>  		vtime_account_system(tsk, vtime);
>  }
>  
> -void vtime_account_kernel(struct task_struct *tsk)
> -{
> -	struct vtime *vtime = &tsk->vtime;
> -
> -	if (!vtime_delta(vtime))
> -		return;
> -
> -	write_seqcount_begin(&vtime->seqcount);
> -	__vtime_account_kernel(tsk, vtime);
> -	write_seqcount_end(&vtime->seqcount);
> -}
> -
>  void vtime_user_enter(struct task_struct *tsk)
>  {
>  	struct vtime *vtime = &tsk->vtime;
> -- 
> 2.34.1
> 

-- 
Cheers,
Changbin Du

      reply	other threads:[~2024-04-11 12:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11 11:22 [PATCH] sched/cputime: remove unused vtime_account_kernel Changbin Du
2024-04-11 12:05 ` duchangbin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1befac0501944919cd99f20c4bcecaa@huawei.com \
    --to=changbin.du@huawei.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox