From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbdJ3ORb (ORCPT ); Mon, 30 Oct 2017 10:17:31 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47254 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbdJ3OR3 (ORCPT ); Mon, 30 Oct 2017 10:17:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4CBD26050D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150 To: Borislav Petkov Cc: Fengguang Wu , Huang Ying , Chen Gong , Linus Torvalds , Linux Kernel Mailing List , Will Deacon , "Rafael J. Wysocki" References: <20171029225155.qcum5i75awrt5tzm@wfg-t540p.sh.intel.com> <20171029231835.3725fnd5yehlmqob@wfg-t540p.sh.intel.com> <20171030110511.scfrdtlnf5lbdhu5@pd.tnic> <2d40fa2f-0b88-a466-fc67-26653f5f72e8@codeaurora.org> <20171030140553.akse6wcfzmuhldad@pd.tnic> From: Tyler Baicar Message-ID: Date: Mon, 30 Oct 2017 10:17:27 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171030140553.akse6wcfzmuhldad@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2017 10:06 AM, Borislav Petkov wrote: > On Mon, Oct 30, 2017 at 10:01:52AM -0400, Tyler Baicar wrote: >> This is not as important for polling sources as it is for the >> interrupt sources since polling sources are regularly checked and >> shouldn't be used for fatal error scenarios. For interrupt driven >> sources, there could already be a fatal error pending, so we should >> handle it immediately. > Whatever it is, you can't call it there as it could deadlock. You need > to think about doing that differently. If you can't come up with a > solution quickly, it should be reverted and then you can try again > later. I'm okay with reverting this and coming up with another solution, but that seems like it could be masking a problem. It should be valid for the polling timer to expire right after this probe function completes which would then trigger ghes_poll_func() to be called and that calls into ghes_proc() immediately. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.