From: Avichal Rakesh <arakesh@google.com>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
Alistair <alistair@alistair23.me>,
gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
colin.i.king@gmail.com, xuetao09@huawei.com,
quic_eserrao@quicinc.com, water.zhangjiantao@huawei.com,
peter.chen@freescale.com, balbi@ti.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
Linux regressions mailing list <regressions@lists.linux.dev>
Subject: Re: [PATCH v4 1/2] usb: gadget: udc: core: Invoke usb_gadget_connect only when started
Date: Tue, 30 May 2023 14:50:52 -0700 [thread overview]
Message-ID: <b1d1c907-406a-57bd-daf5-4366f8714cad@google.com> (raw)
In-Reply-To: <CAPTae5Lz=efNKhCnoy6Hp78HFqCLqxtWdZQ7zSDx2omeYf2KDw@mail.gmail.com>
On 5/17/23 10:45, Badhri Jagan Sridharan wrote:
> Keeping the thread updated. I sent out
> https://www.spinics.net/lists/kernel/msg4792009.html few hours earlier
> and have requested help from Francesco, Alistair and others who
> reported the issue.
> Discussing with Alan stern on the feedback he had left.
>
Tangential to the original issues: it looks like patch 2/2 also
breaks gadget functions that sets `bind_deactivated` to true.
When usb_gadget_connect is called while the gadget is deactivated from
functions binding, it sets gadget->connected to true, but does not call
the pullup function. Later, when the gadget function calls
usb_gadget_activate which in turn calls usb_gadget_connect, the pullup
function isn't called because gadget->connected is true.
- Avi
prev parent reply other threads:[~2023-05-30 21:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 3:07 [PATCH v4 1/2] usb: gadget: udc: core: Invoke usb_gadget_connect only when started Badhri Jagan Sridharan
2023-04-07 3:07 ` [PATCH v4 2/2] usb: gadget: udc: core: Prevent redundant calls to pullup Badhri Jagan Sridharan
2023-05-16 12:53 ` [PATCH v4 1/2] usb: gadget: udc: core: Invoke usb_gadget_connect only when started Alistair
2023-05-17 10:23 ` Linux regression tracking (Thorsten Leemhuis)
2023-05-17 10:32 ` Badhri Jagan Sridharan
2023-05-17 10:35 ` Francesco Dolcini
2023-05-17 10:56 ` Linux regression tracking (Thorsten Leemhuis)
2023-05-17 17:45 ` Badhri Jagan Sridharan
2023-05-30 21:50 ` Avichal Rakesh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1d1c907-406a-57bd-daf5-4366f8714cad@google.com \
--to=arakesh@google.com \
--cc=alistair@alistair23.me \
--cc=badhri@google.com \
--cc=balbi@ti.com \
--cc=colin.i.king@gmail.com \
--cc=francesco@dolcini.it \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@freescale.com \
--cc=quic_eserrao@quicinc.com \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=water.zhangjiantao@huawei.com \
--cc=xuetao09@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox