From: Dragan Simic <dsimic@manjaro.org>
To: linux-rockchip@lists.infradead.org
Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
didi.debian@cknow.org, marcin.juszkiewicz@linaro.org
Subject: Re: [PATCH] arm64: dts: rockchip: Describe why is HWRNG disabled in RK356x base dtsi
Date: Wed, 15 Jan 2025 10:51:57 +0100 [thread overview]
Message-ID: <b1f97e555e57e6593251bb1ef1353423@manjaro.org> (raw)
In-Reply-To: <6b272e2f8f916c04b05db50df621659a5a7f29ab.1733149874.git.dsimic@manjaro.org>
Just a brief reminder about this patch...
On 2024-12-02 15:44, Dragan Simic wrote:
> Despite the presence of the hardware random number generator (HWRNG) in
> the
> different Rockchip RK356x SoC variants, it remains disabled for the
> RK3566
> SoC because testing showed [1] that it produces unacceptably low
> quality of
> random data, for some yet unknown reason. The HWRNG is enabled for the
> RK3568
> SoC, on which the testing showed good quality of the generated random
> data.
>
> To avoid possible confusion in the future, [2] let's have this
> described
> briefly in the RK356x base SoC dtsi.
>
> [1]
> https://lore.kernel.org/linux-rockchip/cover.1720969799.git.daniel@makrotopia.org/T/#u
> [2]
> https://lore.kernel.org/linux-rockchip/20241201234613.52322-1-pbrobinson@gmail.com/T/#u
>
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
> ---
> arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> index 62be06f3b863..ab8f42c0a843 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> @@ -1032,6 +1032,11 @@ sdhci: mmc@fe310000 {
> status = "disabled";
> };
>
> + /*
> + * Testing showed that the HWRNG found in RK3566 produces
> unacceptably
> + * low quality of random data, so the HWRNG isn't enabled for all
> RK356x
> + * SoC variants despite its presence.
> + */
> rng: rng@fe388000 {
> compatible = "rockchip,rk3568-rng";
> reg = <0x0 0xfe388000 0x0 0x4000>;
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-01-15 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 14:44 [PATCH] arm64: dts: rockchip: Describe why is HWRNG disabled in RK356x base dtsi Dragan Simic
2024-12-02 14:55 ` Dragan Simic
2024-12-02 17:05 ` Diederik de Haas
2024-12-02 18:33 ` Dragan Simic
2025-01-15 9:51 ` Dragan Simic [this message]
2025-02-03 8:15 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1f97e555e57e6593251bb1ef1353423@manjaro.org \
--to=dsimic@manjaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox