From: linux-kernel@ton.iguana.be (Ton Hospel)
To: linux-kernel@vger.kernel.org
Subject: Re: two x86_64 fixes for 2.4.21-pre3
Date: Tue, 4 Feb 2003 03:13:22 +0000 (UTC) [thread overview]
Message-ID: <b1nb4i$crp$1@post.home.lunix> (raw)
In-Reply-To: 15921.37163.139583.74988@harpo.it.uu.se
In article <15921.37163.139583.74988@harpo.it.uu.se>,
Mikael Pettersson <mikpe@csd.uu.se> writes:
> #define safe_halt() __asm__ __volatile__("sti; hlt": : :"memory")
>
> +#define __save_and_cli(x) do { __save_flags(x); __cli(); } while(0);
> +#define __save_and_sti(x) do { __save_flags(x); __sti(); } while(0);
> +
The extra ; after the while(0) look wrong.
> #define restore_flags(x) __global_restore_flags(x)
> +#define save_and_cli(x) do { save_flags(x); cli(); } while(0);
> +#define save_and_sti(x) do { save_flags(x); sti(); } while(0);
Same here
next prev parent reply other threads:[~2003-02-04 3:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-24 19:16 two x86_64 fixes for 2.4.21-pre3 Mikael Pettersson
2003-01-24 19:37 ` Andi Kleen
2003-01-28 20:51 ` Mikael Pettersson
2003-01-28 21:27 ` Andi Kleen
2003-01-29 15:39 ` Mikael Pettersson
2003-01-29 16:28 ` Andi Kleen
2003-02-03 19:17 ` Mikael Pettersson
2003-02-03 19:49 ` Jean Tourrilhes
2003-02-03 20:12 ` Andi Kleen
2003-02-03 21:43 ` Jean Tourrilhes
2003-02-03 22:46 ` 32bit emulation of wireless ioctls Andi Kleen
2003-02-03 23:17 ` Jean Tourrilhes
2003-02-03 23:51 ` Andi Kleen
2003-02-04 0:09 ` Jean Tourrilhes
2003-02-03 23:58 ` David Woodhouse
2003-02-04 0:04 ` David Mosberger
2003-02-04 0:11 ` Anton Blanchard
2003-02-07 10:58 ` two x86_64 fixes for 2.4.21-pre3 Pavel Machek
2003-02-07 14:32 ` Alan Cox
2003-02-07 22:58 ` Erik Mouw
2003-02-04 3:13 ` Ton Hospel [this message]
2003-02-04 13:11 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b1nb4i$crp$1@post.home.lunix' \
--to=linux-kernel@ton.iguana.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox