From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93C22325719 for ; Mon, 15 Dec 2025 21:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765833864; cv=none; b=ZqFd1FmBzfIvBqNYfdbbdnbZAV+KTZf3fEJ7UObSvXluOV8IEQ/NpRLxc0+eHWr/6LlXekhPf4D2fzjS2/4EQHYhEPlt/h1rz0Mk80aZx2G150gxIPw1NqcKT0cO33j1CLndDIBi0DZZZImZ5cfbJlQBgYhu1h9vJbSDSy75VaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765833864; c=relaxed/simple; bh=kmOTkKar5ZszOKjZdAqGxu0zQ2gwIIJP+frCfxcIPbc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CESvTjfb5fWs9EgnyBs/NE6cqBZxH8e0puqfobr66afVSukQqrtJIQVOjMMGOsmuuJdvY/EmkRb4MR0YXA/tUnr4lqAevhnb6+d2Hsjcg3A+5MPZO2yGhXr7d9YJJ6AxLdWDMpEQWbZEmiWwWcPkfgVDZnrhiVTrLBxk+2INgpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iRbdr8Fo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iRbdr8Fo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E676C4CEF5; Mon, 15 Dec 2025 21:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765833864; bh=kmOTkKar5ZszOKjZdAqGxu0zQ2gwIIJP+frCfxcIPbc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iRbdr8FoY8wCz2d+TtdLAAVIGAjNVMAy2Fq474TrXiQwqteObQrrNbZVJU+1KxKJp QFt3/tFzfm4XkWcYGf0W0gtDoKE4Oku/k3FVp7n4FM7ygsK1jDlIoNULZbM3i7LsjQ 6SesqM8xUAwxrDZObsmnNYBitrOJcRW7lPbiQg21unxIWKqxk6pZax0/hNBa4KIcUH Ma52uS68TpHy58EVcDg3FeSbgE50fALCbRrZCzZKU7zS+nfM4AxLw+USaelT1Y8BwR QL1Sc0E8meAsGdnAcvEOZ8hYeepSgscHtUKoP6RulIVcIL9+nUwtTxXnD9i14oqP0b EmqRxFkxGJE3w== Message-ID: Date: Mon, 15 Dec 2025 15:24:22 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] firmware: dmi: Correct an indexing error in dmi.h To: Yazen Ghannam Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jean Delvare , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org References: <20251214185309.152614-1-superm1@kernel.org> <20251214185309.152614-2-superm1@kernel.org> <20251215211143.GA355290@yaz-khff2.amd.com> Content-Language: en-US From: Mario Limonciello In-Reply-To: <20251215211143.GA355290@yaz-khff2.amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/15/25 3:11 PM, Yazen Ghannam wrote: > On Sun, Dec 14, 2025 at 12:53:05PM -0600, Mario Limonciello (AMD) wrote: >> The entries later in `enum dmi_entry_type` don't match the SMBIOS >> specification. The entry for type 33: `64-Bit Memory Error Information` >> is not present and thus the index for all later entries is incorrect. >> >> Add the missing type 33 entry. > > Types 43, 44, 45, and 46 are missing also. Should those be added as > well? > > Probably not needed right now, but would be good to add them in a > future patch. I think there's precedent for keeping definitions up to > date with the spec even if they're not immediately used. ACPI does > this, I think. OK, thanks. I'll tail another patch to the next spin of the series to add those too. > >> >> Fixes: 93c890dbe5287 ("firmware: Add DMI entry types to the headers") >> Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0a.pdf >> Signed-off-by: Mario Limonciello (AMD) > > Reviewed-by: Yazen Ghannam > > Thanks, > Yazen