From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F166235358 for ; Tue, 28 Apr 2026 08:38:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365522; cv=none; b=UZDWvstdkB2yQWWUBjpmMBlmLUFuFztom5iYcUxQ/d5mZ/+ez7r8paZ2xw9E/sku2Ca/esQCgEkqaZdAQcS/tVEiBrtDPLVJqkVJQohF16PVy/54ss53JVH9pa4Taqo2oDh8TrENQOKT2k6iE8Zk1glfIAF1uk5q7O0lFJQRNIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365522; c=relaxed/simple; bh=4LPUJmzbAmWHUPl64OkGVhJBiuRxBDuzm53PTKHmLek=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fNz7Hf06K+z0zJN0V1FQtTj3enZUhMlOhTVTzVbHb4L0UOcz2eT+RyV2+YRrfQyp7Ygo8TgjDeWQZuHwYzjCfyhCkRgVbt5EnmFx8mGITlp5bKpvvTisxW4jIeOLkJzbCYlSYScjByYmQY9HGNIr5VhbEz6tEaVGVu7FA6IyIJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z0rwaKx3; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z0rwaKx3" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5a3d1561e38so9150784e87.0 for ; Tue, 28 Apr 2026 01:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777365519; x=1777970319; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=we2SJPuS0TpFWfCdtg7TArr+j+2zNbx0PJ/Tl04MBzA=; b=Z0rwaKx302yCH0A7LXxyBBZJZ6hxHZzVaEKtcs1zTBxigdrSdUUus+egzTyLhLGhmv V/msDnVlWeLgnWz3p9yWedNu3QCbIQ+P2HuEfZlGZFFTnV8glUMO1BUa57suruzzagLL N0RiyEbNJfcL4Cz4eZec/GubEa+b85OwaicDPN5eYXuSxkoTqKCZ3ygmj4NjC3Fh5Zls 7SGjb2xca0MF9ybptHh9WfCJ9wuKJWuM7J0JXo9K9KNZI6i7WsxFlZxsP8P9ioUW4yI4 yHvokOg9DcpUNDrlfyPGghx3SxRfkiNcIK36m634WZC04WdLXLaMeBWmR5SzWkrq7Q5p HqyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777365519; x=1777970319; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=we2SJPuS0TpFWfCdtg7TArr+j+2zNbx0PJ/Tl04MBzA=; b=lQwpQgQFunFJztsrOeRaA8np+Ra68jQBb8wr9F/UyMQ+q+YhdFzMujTk9LDaLgWVqP kSgOp485F71q52SfPS4QsFU+b8yW/waBfkWnyvNR3myFyvyClshnPgYuMEwvGfptUqD4 uM2xyyGclkO2H0kZgsTRWki0CjURJQ8PE0B7Kmmxli66aanHKnaQA7OMhUHylFkUQAWN GU+O31QmS3FXaPMybosYJXCYLd0D1QMzrVKFRgcf5SzUV5ooPTkb9UPYzltBQYsHbhzh jZWNDGFPT88/ixX/+qf5OlBE5ll+z5HAS3T1/TBNqG0Iv81L6/5f8sTpc6jKOGLs1ftG kE6A== X-Gm-Message-State: AOJu0Yw23fuCGOlz25Px2GwzV2zQxL4rqIqM/J+fbpkOpfTAf5ZCIkxJ og7eUZ4g6bVcJTi5HZYTmndcgypH6iFEJIrK/fg1XFwnndYM52IvBwrpaQJaTA== X-Gm-Gg: AeBDievOAPaE+sOE2HL2tm9yI9051l87cNUwuIT/SXvIB6n8Ldar0iyEMUtAeIs2eeK N0kbo9IoOjGDV9SpJ1261DW+UBPbkxsWFO13Cf+HRKgC/kGHzJVlpWI9MislPv+X9c650mOR6LR gfwppIHjK3pzSPnZXZHasfERavBhEpimZXjTEM2ZoXR5hVlAD27Vre7FbOV4yk9nvW5its8NaeB DW+9QswGELIQftFDB1lRULpS1SAdWLXi1HgGzjGgJ0Eb6+QmZOEKdTheVtmjgdg5xcV2lLcbar6 1+2S/a06syNaArXBLDY+RxxgOy6Vawq73IUkBCFviVXyEp9rCgd5rUeE/lHfPQtRx+7lUloK+M8 V39TFEoFGqB7tNUdrJwfvAx1vX2d5odcppUmlaMMHzWdA/qQyqvbiEOkRefgKPVurocBM0RmUjr 5zHa4uOQp0SGrccUSxC+8OKs6iRj1ZxpssoQtWZbrpbexqL22mhg/XB1knOSkicew3HS2X/LZPZ /2KaDPjkA== X-Received: by 2002:a05:6512:1392:b0:5a4:10b5:624c with SMTP id 2adb3069b0e04-5a746618210mr1012970e87.23.1777365519063; Tue, 28 Apr 2026 01:38:39 -0700 (PDT) Received: from [192.168.1.89] (c-85-228-44-247.bbcust.telenor.se. [85.228.44.247]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a7463f5ee5sm437520e87.39.2026.04.28.01.38.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 01:38:38 -0700 (PDT) Message-ID: Date: Tue, 28 Apr 2026 10:37:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] char: xillybus: use strscpy() in init_chrdev Content-Language: en-US To: Thorsten Blum , Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org References: <20260427173730.418592-3-thorsten.blum@linux.dev> From: Eli Billauer In-Reply-To: <20260427173730.418592-3-thorsten.blum@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, On 27/04/2026 19:37, Thorsten Blum wrote: > if (!enumerate) > - snprintf(unit->name, UNITNAMELEN, "%s", prefix); > + strscpy(unit->name, prefix); > > for (i = 0; enumerate; i++) { > snprintf(unit->name, UNITNAMELEN, "%s_%02d", snprintf() is used deliberately for code clarity: It makes a simple visual contrast with the use of snprintf() three rows below. As this call takes place only once for each physical hardware device handled by the driver, the advantage in optimizing this function call is negligible. And even though it's formally OK to use strscpy() with two arguments, and let the compilation machinery find out the length of the char array, I have to admit that it gives me the chills. Buffer overflow and that. So overall, I can't say I'm very fond of this patch. Thanks for the effort nevertheless. Regards, Eli