From: Stephen Boyd <sboyd@kernel.org>
To: David Lechner <dlechner@baylibre.com>, Tero Kristo <kristo@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
David Lechner <dlechner@baylibre.com>
Subject: Re: [PATCH] clk: ti: dra7-atl: fix leak of of_nodes
Date: Wed, 28 Aug 2024 13:18:11 -0700 [thread overview]
Message-ID: <b2737143b0c4f4eceb5008e6629f1691.sboyd@kernel.org> (raw)
In-Reply-To: <20240826-clk-fix-leak-v1-1-f55418a13aa6@baylibre.com>
Quoting David Lechner (2024-08-26 08:35:29)
> This fix leaking the of_node references in of_dra7_atl_clk_probe().
>
> The docs for of_parse_phandle_with_args() say that the caller must call
> of_node_put() on the returned node. This adds the missing of_node_put()
> to fix the leak.
>
> Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2024-08-28 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 15:35 [PATCH] clk: ti: dra7-atl: fix leak of of_nodes David Lechner
2024-08-26 16:12 ` Markus Elfring
2024-08-28 20:18 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2737143b0c4f4eceb5008e6629f1691.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=dlechner@baylibre.com \
--cc=kristo@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox