Re: [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages

Dave Hansen
2025-01-07T19:48:25Z

On 1/2/25 13:59, Edgecombe, Rick P wrote:
> union tdx_sept_gpa_mapping_info {
> struct {
> u64 level : 3;
> u64 reserved1 : 9;
> u64 gfn : 40;
> u64 reserved2 : 12;
> };
> u64 full;
> };

This is functionally OK, but seeing bitfields on a value that's probably
going to get shifted around makes me nervous because of:

> https://lore.kernel.org/lkml/20231111020019.553664-1-michael.roth@amd.com/
I wouldn't NAK it just for this, but it's also not how I would code it up.