From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFD8C433E6 for ; Mon, 8 Mar 2021 14:44:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0A22650ED for ; Mon, 8 Mar 2021 14:44:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230125AbhCHOnf (ORCPT ); Mon, 8 Mar 2021 09:43:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230511AbhCHOn2 (ORCPT ); Mon, 8 Mar 2021 09:43:28 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CF8EC06174A for ; Mon, 8 Mar 2021 06:43:28 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id bm21so20856864ejb.4 for ; Mon, 08 Mar 2021 06:43:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Az8rhA9caHuo5zJCEYV8g7y4jULWEe6VaW1tk9jHX3I=; b=VNEcNxDgmlldA/u8di4huVxTlpa63PWMrv1nVVNhGIhelZ8P8KTUV7fB2hzpu2JE3L JR2nNA8A2rPTgt7Y7SHLNz36wk7715OF6V3QdYK1ynr1bpibEr2d2s0obXyasg2pViE4 Y90OLyHBTliRuLh6i20zM+WckQYC6ADJexiAtBJF7QFrMZNV4vniXv0kP3lIinLsrmf7 dkfZBqm9FUtnoK3l4G4wpC4ZrT06TML31imjHUZe53UU0aWfQVJ/VJskJXmrYYHDWDQU UL2I7iIpchwsyzl9tknM4XrRJH8B5zXEuJe0woH/m8++6yUQZWjaJBrHWwtvnEOgMVig tJ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Az8rhA9caHuo5zJCEYV8g7y4jULWEe6VaW1tk9jHX3I=; b=DMhs270mG6XtJvlqVleiWaKoC6MXVRy+KDv48oEYZzq3umd7mdkSo7i/Ur6Cvk+/W7 5NJY2JgsNTkMr79AwMUMk76FCwXTvCrWlhc4pSd/YRtOP+G7F2bPL4hnk+JBpjfuuxna 9gf00RwtNyaITIxxk2jmfMXi23u5ww5V/7l5cfjKOvckxhwvM/htm3VoDeI+hj/uJcgg MvGu6xYqAIzL7+3FfPFfDLQW+QaI73MoweiJDaHST7b1whHnEeXovwrjc2JDl5fkLCY9 4FgYmTa1933GN0Sc2Vr1vDHnfvBc1S3hR3hfgptIc2OJkcz4kTOYmO5mZAUZ1mEClfKJ m7LA== X-Gm-Message-State: AOAM532eMrTHc61qTxsuH+0pbmviKmnkAgvbarSAjczLP14i0p7wEIY+ 5hQbXrMwp9evdspOveNoGtxmEbKUxsOnOQ== X-Google-Smtp-Source: ABdhPJzLVFusCJGHsLRE2whpfSe3NJ3sQRGVskencktMChCB5X29IBCZfnhGe0pbrM61syySA7Jj2g== X-Received: by 2002:a17:906:d787:: with SMTP id pj7mr14938160ejb.257.1615214606892; Mon, 08 Mar 2021 06:43:26 -0800 (PST) Received: from ?IPv6:2a02:908:1252:fb60:4794:2f8d:7bcd:36a5? ([2a02:908:1252:fb60:4794:2f8d:7bcd:36a5]) by smtp.gmail.com with ESMTPSA id d19sm7259446edr.45.2021.03.08.06.43.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 06:43:26 -0800 (PST) Subject: Re: [PATCH v1 12/15] powerpc/uaccess: Refactor get/put_user() and __get/put_user() To: Christophe Leroy , kernel test robot , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Evgeniy Polyakov , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: linuxppc-dev@lists.ozlabs.org, kbuild-all@01.org, amd-gfx list , linux-kernel@vger.kernel.org References: <3c174edb80d2d37af6b08c637b09268f675e5371.1614275314.git.christophe.leroy@csgroup.eu> <202103071822.4cXbH0Xp-lkp@intel.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Mon, 8 Mar 2021 15:43:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The radeon warning is trivial to fix, going to send out a patch in a few moments. Regards, Christian. Am 08.03.21 um 13:14 schrieb Christophe Leroy: > +Evgeniy for W1 Dallas > +Alex & Christian for RADEON > > Le 07/03/2021 ŕ 11:23, kernel test robot a écrit : >> Hi Christophe, >> >> I love your patch! Perhaps something to improve: >> >> [auto build test WARNING on powerpc/next] >> [also build test WARNING on v5.12-rc2 next-20210305] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: >> https://github.com/0day-ci/linux/commits/Christophe-Leroy/powerpc-Cleanup-of-uaccess-h/20210226-015715 >> base: >> https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next >> config: powerpc-randconfig-s031-20210307 (attached as .config) >> compiler: powerpc-linux-gcc (GCC) 9.3.0 >> reproduce: >>          wget >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >> -O ~/bin/make.cross >>          chmod +x ~/bin/make.cross >>          # apt-get install sparse >>          # sparse version: v0.6.3-245-gacc5c298-dirty >>          # >> https://github.com/0day-ci/linux/commit/449bdbf978936e67e4919be8be0eec3e490a65e2 >>          git remote add linux-review https://github.com/0day-ci/linux >>          git fetch --no-tags linux-review >> Christophe-Leroy/powerpc-Cleanup-of-uaccess-h/20210226-015715 >>          git checkout 449bdbf978936e67e4919be8be0eec3e490a65e2 >>          # save the attached .config to linux build tree >>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 >> make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot > > > The mentioned patch is not the source of the problem, it only allows > to spot it. > > Christophe > >> >> >> "sparse warnings: (new ones prefixed by >>)" >>>> drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: sparse: incorrect >>>> type in initializer (different address spaces) @@     expected char >>>> [noderef] __user *_pu_addr @@     got char *buf @@ >>     drivers/w1/slaves/w1_ds28e04.c:342:13: sparse:     expected char >> [noderef] __user *_pu_addr >>     drivers/w1/slaves/w1_ds28e04.c:342:13: sparse:     got char *buf >>>> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect >>>> type in initializer (different address spaces) @@     expected char >>>> const [noderef] __user *_gu_addr @@     got char const *buf @@ >>     drivers/w1/slaves/w1_ds28e04.c:356:13: sparse:     expected char >> const [noderef] __user *_gu_addr >>     drivers/w1/slaves/w1_ds28e04.c:356:13: sparse:     got char const >> *buf >> -- >>     drivers/gpu/drm/radeon/radeon_ttm.c:933:21: sparse: sparse: cast >> removes address space '__user' of expression >>     drivers/gpu/drm/radeon/radeon_ttm.c:933:21: sparse: sparse: cast >> removes address space '__user' of expression >>>> drivers/gpu/drm/radeon/radeon_ttm.c:933:21: sparse: sparse: >>>> incorrect type in initializer (different address spaces) @@     >>>> expected unsigned int [noderef] __user *_pu_addr @@     got >>>> unsigned int [usertype] * @@ >>     drivers/gpu/drm/radeon/radeon_ttm.c:933:21: sparse: expected >> unsigned int [noderef] __user *_pu_addr >>     drivers/gpu/drm/radeon/radeon_ttm.c:933:21: sparse:     got >> unsigned int [usertype] * >>     drivers/gpu/drm/radeon/radeon_ttm.c:933:21: sparse: sparse: cast >> removes address space '__user' of expression >> >> vim +342 drivers/w1/slaves/w1_ds28e04.c >> >> fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21  338 >> fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21  339  static ssize_t >> crccheck_show(struct device *dev, struct device_attribute *attr, >> fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 340                   >> char *buf) >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  341  { >> fbf7f7b4e2ae40 Markus Franke      2012-05-26 @342      if >> (put_user(w1_enable_crccheck + 0x30, buf)) >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  343 return -EFAULT; >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  344 >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  345      return >> sizeof(w1_enable_crccheck); >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  346  } >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  347 >> fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21  348  static ssize_t >> crccheck_store(struct device *dev, struct device_attribute *attr, >> fbf7f7b4e2ae40 Markus Franke      2012-05-26 349                    >> const char *buf, size_t count) >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  350  { >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  351      char val; >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  352 >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  353      if (count != 1 >> || !buf) >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  354 return -EINVAL; >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  355 >> fbf7f7b4e2ae40 Markus Franke      2012-05-26 @356      if >> (get_user(val, buf)) >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  357 return -EFAULT; >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  358 >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  359      /* convert to >> decimal */ >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  360      val = val - 0x30; >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  361      if (val != 0 >> && val != 1) >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  362 return -EINVAL; >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  363 >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  364      /* set the new >> value */ >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  365 w1_enable_crccheck >> = val; >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  366 >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  367      return >> sizeof(w1_enable_crccheck); >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  368  } >> fbf7f7b4e2ae40 Markus Franke      2012-05-26  369 >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >> > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx