From: Michael Walle <michael@walle.cc>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Jason Wang <jasowang@redhat.com>,
linux-gpio <linux-gpio@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] drivers: gpio: add virtio-gpio guest driver
Date: Thu, 03 Dec 2020 23:35:02 +0100 [thread overview]
Message-ID: <b287f185d554b5a87b82ea8ca79cb5a2@walle.cc> (raw)
In-Reply-To: <f14c0197-b346-7af5-9dd0-9b8018baaeaf@metux.net>
Am 2020-12-03 20:00, schrieb Enrico Weigelt, metux IT consult:
> On 02.12.20 15:15, Bartosz Golaszewski wrote:
>>> + bufwalk = name_buffer;
>>> +
>>> + while (idx < priv->num_gpios &&
>>> + bufwalk < (name_buffer+cf.names_size)) {
>>> + gpio_names[idx] = (strlen(bufwalk) ? bufwalk
>>> : NULL);
>>> + bufwalk += strlen(bufwalk)+1;
>>> + idx++;
>>
>>
>> Something's wrong with indentation here.
>
> i dont think so: the "bufwalk ..." line belongs to the while expression
> and is right under the "idx", as it should be. I didn't want to break
> up
> at the "<" operator. shall i do this instead ?
Or don't break the lines at all. Both lines don't add up to more than
100 chars,
right?
-michael
next prev parent reply other threads:[~2020-12-03 22:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 18:30 [PATCH] drivers: gpio: add virtio-gpio guest driver Enrico Weigelt, metux IT consult
2020-11-27 18:45 ` Randy Dunlap
2020-12-03 19:01 ` Enrico Weigelt, metux IT consult
2020-11-27 19:33 ` kernel test robot
2020-11-29 20:11 ` Michael S. Tsirkin
2020-11-29 22:10 ` Jonathan Neuschäfer
2020-12-03 19:12 ` Enrico Weigelt, metux IT consult
2020-12-02 14:15 ` Bartosz Golaszewski
2020-12-03 19:00 ` Enrico Weigelt, metux IT consult
2020-12-03 22:35 ` Michael Walle [this message]
2020-12-04 8:28 ` Enrico Weigelt, metux IT consult
2020-12-04 9:06 ` Michael Walle
-- strict thread matches above, loose matches on Subject: below --
2021-06-15 17:49 Enrico Weigelt, metux IT consult
2021-06-16 8:31 ` Linus Walleij
2021-06-16 11:49 ` Viresh Kumar
2021-06-16 15:04 ` Enrico Weigelt, metux IT consult
2021-06-17 3:59 ` Viresh Kumar
2021-06-17 9:54 ` Enrico Weigelt, metux IT consult
2021-06-17 11:47 ` Viresh Kumar
2021-06-16 14:41 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b287f185d554b5a87b82ea8ca79cb5a2@walle.cc \
--to=michael@walle.cc \
--cc=bgolaszewski@baylibre.com \
--cc=info@metux.net \
--cc=jasowang@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkml@metux.net \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox