From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751710AbdBAKAl (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Feb 2017 05:00:41 -0500
Received: from mx2.suse.de ([195.135.220.15]:40592 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751542AbdBAKAj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Feb 2017 05:00:39 -0500
Subject: Re: [PATCH 4/5] xen, x86/headers: Add <linux/device.h> dependency to
 <asm/xen/page.h>
To: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
References: <1485942677-19973-1-git-send-email-mingo@kernel.org>
 <1485942677-19973-5-git-send-email-mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@amacapital.net>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, Yinghai Lu <yinghai@kernel.org>
From: Juergen Gross <jgross@suse.com>
Message-ID: <b2a86ff2-c604-e68f-ece8-8f852e533d4d@suse.com>
Date: Wed, 1 Feb 2017 11:00:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <1485942677-19973-5-git-send-email-mingo@kernel.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/02/17 10:51, Ingo Molnar wrote:
> The following patch (not upstream yet):
> 
>   "x86/boot/e820: Remove spurious asm/e820/api.h inclusions"
> 
> Removed the (spurious) <asm/e820.h> include line from <asm/pgtable.h> to
> reduce header file dependencies - but a Xen header has (unintentionally)
> learned to rely on the indirect inclusion of <linux/device.h>.
> 
> This resulted in the following (harmless) build warning:
> 
>    arch/x86/include/asm/xen/page.h:302:7: warning: 'struct device' declared inside parameter list
> 
> Include <linux/device.h> explicitly.
> 
> No change in functionality.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: <stefano.stabellini@eu.citrix.com>
> Cc: Juergen Gross <jgross@suse.com>

Hmm, how did you send this? In spite of the Cc: list in the patch only
few of those listed here are included in the Cc: header of the mail.

> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Ingo Molnar <mingo@kernel.org>

Acked-by: Juergen Gross <jgross@suse.com>


Juergen