RE: [PATCH] gpio: davinci: fix lazy disable

["J, KEERTHY" <j-keerthy@ti.com>]

-----Original Message-----
From: Francesco Dolcini <francesco@dolcini.it> 
Sent: Monday, September 23, 2024 3:10 PM
To: J, KEERTHY <j-keerthy@ti.com>; Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Parth Pancholi <parth105105@gmail.com>; Linus Walleij <linus.walleij@linaro.org>; Emanuele Ghidoli <emanuele.ghidoli@toradex.com>; linux-gpio@vger.kernel.org; linux-kernel@vger.kernel.org; Parth Pancholi <parth.pancholi@toradex.com>; stable@vger.kernel.org
Subject: Re: [PATCH] gpio: davinci: fix lazy disable

Hello Keerthy,

On Mon, Sep 02, 2024 at 02:08:30PM +0200, Bartosz Golaszewski wrote:
> On Wed, Aug 28, 2024 at 3:32 PM Parth Pancholi <parth105105@gmail.com> wrote:
> >
> > From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> >
> > On a few platforms such as TI's AM69 device, disable_irq()
> > fails to keep track of the interrupts that happen between
> > disable_irq() and enable_irq() and those interrupts are missed.
> > Use the ->irq_unmask() and ->irq_mask() methods instead
> > of ->irq_enable() and ->irq_disable() to correctly keep track of
> > edges when disable_irq is called.
> > This solves the issue of disable_irq() not working as expected
> > on such platforms.
> >
> > Fixes: 23265442b02b ("ARM: davinci: irq_data conversion.")
> > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> > Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>
> > Cc: stable@vger.kernel.org
> > ---
> 
> It looks good to me but I'd like to have an Ack from Keerthy on this.

Keerthy, just a gentle ping on this, can you help?

> Acked-by: Keerthy <j-keerthy@ti.com>

Francesco