From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-190e.mail.infomaniak.ch (smtp-190e.mail.infomaniak.ch [185.125.25.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AE895DF1D; Tue, 23 Jan 2024 16:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.25.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706026678; cv=none; b=RhukSI3xEcoWf84BxFWfLUmwQabHxN+Wj+nTLvSSeETNdxUY4dY93Wt+7FnPePhNUmDNZpVqbBghhmfIyjMfeIAX4+mB970k+C8KsY67uFlxXDRCWLw+zfZqruZkFEsVuVjQ30FWmzjyjQ3SxTu2Ce8I256SDjKPbnUQr64qyaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706026678; c=relaxed/simple; bh=1NG8wi6AszbC+t2mITn/X0WKvcHrmSYn4Gpm9d1E7n0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=J26gu6KWzhQxTcrX1aPGwGktDGQOJ3gPTKlvX7zMawyUqDiXEZX7dJYofg3GDorOlJ6+R+u/i2/1HZn2kOw0+QlsT6CkR/UM99R221Q7bLBKuTPDFzjuFpymWbufI3NEPeQ8MNGEMw97fSAFkVhYu8YiP7wrr+/gyfnVddh79fU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pschenker.ch; spf=pass smtp.mailfrom=pschenker.ch; dkim=pass (1024-bit key) header.d=pschenker.ch header.i=@pschenker.ch header.b=F519chZT; arc=none smtp.client-ip=185.125.25.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pschenker.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pschenker.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pschenker.ch header.i=@pschenker.ch header.b="F519chZT" Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4TKC1G3P7FzMqFgm; Tue, 23 Jan 2024 17:17:54 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4TKC1F6DShzr4; Tue, 23 Jan 2024 17:17:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pschenker.ch; s=20220412; t=1706026674; bh=1NG8wi6AszbC+t2mITn/X0WKvcHrmSYn4Gpm9d1E7n0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=F519chZTJVObdy2utWFWlWTH24Apz/VpWi/QpvB+KxeHkqtE98o1TTT1fXq61NgK6 5ee7pjWUiJ6viyIQyOFKs2nIBqE5c9DMoJf9YNJr6eotoDf8MMnfEpSR2aLfatIAmj x21UmRMKRV8e5BCnndG/sC5Kc3wb1eONigMf0ILA= Message-ID: Subject: Re: [PATCH net-next v1 1/2] dt-bindings: net: dsa: Add KSZ8567 switch support From: Philippe Schenker To: Conor Dooley Cc: netdev@vger.kernel.org, Paolo Abeni , Conor Dooley , Woojung Huh , Vladimir Oltean , linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Marek Vasut , Florian Fainelli , devicetree@vger.kernel.org, Eric Dumazet , "David S . Miller" , Krzysztof Kozlowski , Jakub Kicinski , Andrew Lunn , Rob Herring Date: Tue, 23 Jan 2024 17:17:53 +0100 In-Reply-To: <20240123-ripening-tabby-b97785375990@spud> References: <20240123135014.614858-1-dev@pschenker.ch> <20240123-ripening-tabby-b97785375990@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Infomaniak-Routing: alpha On Tue, 2024-01-23 at 16:06 +0000, Conor Dooley wrote: > On Tue, Jan 23, 2024 at 02:50:13PM +0100, Philippe Schenker wrote: > > From: Philippe Schenker > >=20 > > This commit adds the dt-binding for KSZ8567, a robust 7-port > > Ethernet switch. The KSZ8567 features two RGMII/MII/RMII > > interfaces, > > each capable of gigabit speeds, complemented by five 10/100 Mbps > > MAC/PHYs. > >=20 > > Signed-off-by: Philippe Schenker >=20 > This device has all the same constraints as the other ones in this > binding, why is it not compatible with any of them? If it isn't, the > compatible should mention why it is not. Hi Conor, Thanks for your message! I need the compatible to make sure the correct ID of the switch is being set in the driver as well as its features. You mean I shall mention the reason in the commit-message, or where? Philippe >=20 > Cheers, > Conor. >=20 > > --- > >=20 > > =C2=A0Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 1 = + > > =C2=A01 file changed, 1 insertion(+) > >=20 > > diff --git > > a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > > b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > > index c963dc09e8e1..52acc15ebcbf 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > > @@ -31,6 +31,7 @@ properties: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - microchip,ksz9893 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - microchip,ksz9563 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - microchip,ksz8563 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - microchip,ksz8567 > > =C2=A0 > > =C2=A0=C2=A0 reset-gpios: > > =C2=A0=C2=A0=C2=A0=C2=A0 description: > > --=20 > > 2.34.1 > >=20