From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A730E33B6D9 for ; Wed, 14 Jan 2026 19:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768417410; cv=none; b=idBmprnlUUnrWCoxFOlA02yDFkvJf+fVNMbrk83tLLX0JMXte5je2FpO16WoGZ3vWo2rMbmUJre1qAPzmXUskfmZh9FPlaZ1emTHKyvF/DezckuWhViWVze00yMOEo+WSZSCBK1TU1/eqzi726m4UkfbbhoDNTIe5XZS0q/TmWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768417410; c=relaxed/simple; bh=0rMQ6zOURla4mzk4Z8trD7B7gUluo/Fy3On3fQUwXtg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sPLpeTkoGPbuohQssrmw0DQk5N9gva9GsEJMsdddQYsLG2hxWHeQdMMwKRmBwwju87Yi+yuMBunLCAeQ9BNp0NdUpWVBfV11XlvoxDnEjqY4FGbdnUbiwkLHo8xkBh4wTI4GKza2KvxnRRpUmA6L247bJkTS852VHHJ7u9C7yIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lvnIsTGZ; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lvnIsTGZ" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47ee3a63300so1455825e9.2 for ; Wed, 14 Jan 2026 11:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768417407; x=1769022207; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=59rTEl+o7f1MOuKCLVPM1nM2JKRGkvQaPwVRBCBoMgg=; b=lvnIsTGZGKs9BtAOGLsXBYnNo6oczlaT7Lw4VVfpFNurZylXPsUOTYNuDqT21uiKBV 6DkzVirfzl1oCUMXhEppImlWOGmYkqs5CBlwQrF1f8cVvK1ARf7RGvOw00K1M+MdN882 vl3JYba1HlH8Rb+U5mOSCj8Kw/6NjY45A3dd/27bedMtELAO38LpD2vX1fYR/rVJxXeF iCyOeAjedAJt9XbRcyjTI91NHWjzPLNtgcXl+ZK9ixCGQlwTnNJD6pfp+FSK+p4oUqfW L/S4SqkhBngEAatyhhlzXXnShgTJd8vJhnNALM7pnYZQucaTaLzSxXWP9oI5aMQvKM+f kTlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768417407; x=1769022207; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=59rTEl+o7f1MOuKCLVPM1nM2JKRGkvQaPwVRBCBoMgg=; b=IZ7W0xeguP6dflf3YiXGbJzey2h7JMp/v8Ukug5TTC31hKfx/fpK6F5xE3gdS1zDXV 2lfsSKLUaHAph1kfP43izNZT/DxwKOGs5TcHVafVl4r692pKDW/ny7M2edMj0u4wLz+6 YEAG1Ua4l6SVTAWkTQ0wvLcy/mcEgNi4CVnhNd+AJK5vFNvpA1HoJ7yc4hUH+I4txJVA KiBX0OZCiy38ZnjgVUyQ+xeZxXleOeRsi4xGvYXZlTDoCbjyTVtZwY1zs4SuAQ9E+Gmh ZcwxREPmg5uorvVIDYSM6VxOtHib7Bxt0EI/UahZ3fvTumRfbNuN2yoUmmy1CZw48l30 bF9A== X-Forwarded-Encrypted: i=1; AJvYcCXO8EM0seTrI1vbEqGSp/llJ7j4x9YU4SWC5JiXkh1+eY3FyhO4Zm8MMoGgaA4e3ooW9dnLSbHcGp8DRgc=@vger.kernel.org X-Gm-Message-State: AOJu0YykVJoluHTmxnL0W28IdI6JG9TeVoM4YdI6oX7migvR3CYv2U/V Y294QSQQlMS9Cir9ymuXbC50YK3H+3BNokzCoBO91dlS/1gBdXXcAeky X-Gm-Gg: AY/fxX6pxGyAhlHHxOHNlluT/U0LQtEhcpx374PPLGctFU+m9yhU4SKexN5avT33h0B /yN5xkSdGn/671Dy+qO0sUnoR5YkNsdjmv744hQPwaPAeU7ufhM67eb8DzAPUjfKs7M+p7pjRoN 5mTHhpKXaBToIU+jnkaCbuObd0DTSVeyBM0k2OdyGPd/i9mb3bq/vM7oj3aU9B4KMredb7ezaQ7 UznXj/PV8n1CzWkpws9MVmNqyCN7FyHWiunO83g5aEw3BAWieUDfnr0599C4cQPevJk3NPlRw4x N1KEpEB/xQJ5lBd/jkektTWsanOI7Mj9f2+lj8axwhKeSZNUU7mLpzRhxJwZh1sQ4KdCOO3WP+a 0nVbk3YQVwRhPYsFkasT9muzkUCohaTi+2jKlJfV0f9Rg7JSvKxikwsMTTRtHHCNXsN6tP87drK ARPIi1YzlI8tGxEw== X-Received: by 2002:a05:600c:548c:b0:477:fcb:2256 with SMTP id 5b1f17b1804b1-47ee3371876mr49366775e9.17.1768417406589; Wed, 14 Jan 2026 11:03:26 -0800 (PST) Received: from [192.168.0.2] ([212.50.121.5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f4289b83csm5779735e9.3.2026.01.14.11.03.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jan 2026 11:03:25 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 21:03:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: wwan: t7xx: Add CONFIG_WWAN_ADB_PORT for ADB port control To: "wanquan.zhong" , loic.poulain@oss.qualcomm.com, chandrashekar.devegowda@intel.com, chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com, ricardo.martinez@linux.intel.com Cc: netdev@vger.kernel.org, johannes@sipsolutions.net, davem@davemloft.net, andrew+netdev@lunn.ch, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, wanquan.zhong@fibocom.com References: <599905d9-19ac-4027-85d1-9b185603051c@gmail.com> <20260114131423.202777-1-zwq2226404116@163.com> Content-Language: en-US From: Sergey Ryazanov In-Reply-To: <20260114131423.202777-1-zwq2226404116@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Wanquan, On 1/14/26 15:14, wanquan.zhong wrote: > From: "wanquan.zhong" > > Changes from v2: > 1) Add missing 'net:' subsystem prefix to commit subject for compliance > 2) Remove redundant "to config" suffix and refine commit wording > 3) Split overlong Kconfig help text lines to meet 72-char limit > 4) Align EXPERT dependency desc with WWAN subsystem conventions > > Add a new Kconfig option CONFIG_WWAN_ADB_PORT to control the ADB debug port > functionality for MediaTek T7xx WWAN modem. This option depends on MTK_T7XX > and EXPERT, defaults to 'y' to avoid breaking existing debugging workflows > while mitigating potential security concerns on specific target systems. > > This change addresses security risks on systems such as Google Chrome OS, > where unauthorized root access could lead to malicious ADB configuration > of the WWAN device. The ADB port is restricted via this config only; the > MIPC port remains unrestricted as it is MTK's internal protocol port with > no associated security risks. As it was shared before, you cannot stop user having root privileges. He can simply unload your 'secured' driver and load another custom build module. If the patch is attempt to address a Chrome OS privileges separation issue, then, please, fix Chrome OS itself. For this specific patch: NACKed-by: Sergey Ryazanov