From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E5EC46CA3 for ; Mon, 4 Dec 2023 13:07:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344164AbjLDNHh (ORCPT ); Mon, 4 Dec 2023 08:07:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232947AbjLDNHe (ORCPT ); Mon, 4 Dec 2023 08:07:34 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B717FA7; Mon, 4 Dec 2023 05:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701695260; x=1733231260; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=rwfeHVUdIJbFUBsUHDPSqcnPbouutdp0s8W6pWKb+Y4=; b=fsgXxWRQ89m4nUroXsW8cNZiVAFyIkyNiUyf+4W9A8wxcEl0dcf6/OHN 0lRvV3dfulQDh/7rnREljYFb4WFLZIENwuWIdDmwgTWUnxW7HzaIfl3ex ZN4S3/Cs0E2w8BFR/z1H2LmDf5gdeZLaBTckYzs/aDb9SqaJvY3TSf+hb O+j/bt9fJDxXaxXaLLf0RjuotT1CgRHXFb17dvQheY5hqmB4jsTvnl9N5 UTe3cthvCNNc47QmHS5r2FtuamSEk9RpQMiX4eIqHmgzvuPIckptx+4S/ AVrdwdq/WTKLP0x45BtoDcs6XuyybGFMqnhqGK7gXRvscfaja3sJcwCWQ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="15275123" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="15275123" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 05:07:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="861373354" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="861373354" Received: from malladhi-mobl.gar.corp.intel.com ([10.249.34.28]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 05:07:12 -0800 Date: Mon, 4 Dec 2023 15:07:06 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Vadim Pasternak cc: Kunwu Chan , "hdegoede@redhat.com" , "jdelvare@suse.com" , "linux@roeck-us.net" , Shravan Ramani , "jiri@resnulli.us" , "kunwu.chan@hotmail.com" , "platform-driver-x86@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hwmon@vger.kernel.org" Subject: RE: [PATCH v2] platform/mellanox: Add some null/error pointer checks to mlxbf-pmc.c In-Reply-To: Message-ID: References: <20231201055447.2356001-1-chentao@kylinos.cn> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1694539297-1701695235=:3149" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1694539297-1701695235=:3149 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT > > Subject: [PATCH v2] platform/mellanox: Add some null/error pointer checks to > > mlxbf-pmc.c > > > > devm_kasprintf() returns a pointer to dynamically allocated memory which > > can be NULL upon failure. > > devm_hwmon_device_register_with_groups return a error pointer upon > > failure. > > > > Compile-tested only. > > > > Fixes: 1a218d312e65 ("platform/mellanox: mlxbf-pmc: Add Mellanox > > BlueField PMC driver") > > Suggested-by: Ilpo Järvinen > > Suggested-by: Vadim Pasternak > > Signed-off-by: Kunwu Chan > > Reviewed-by: Vadim Pasternak > > attr->dev_attr.attr.name = devm_kasprintf(dev, GFP_KERNEL, > > "enable"); > > + if (!attr->dev_attr.attr.name) > > + return -ENOMEM; > > pmc->hwmon_dev = devm_hwmon_device_register_with_groups( > > dev, "bfperf", pmc, pmc->groups); > > + if (IS_ERR(pmc->hwmon_dev)) > > + return PTR_ERR(pmc->hwmon_dev); Thank you both, applied to review-ilpo and will go into fixes branch once LKP has had its chance to build this. In the end, I decided to split the devm_kasprintf() and devm_hwmon_device_register_with_groups() changes into separate commits. -- i. --8323329-1694539297-1701695235=:3149--