Build problems with APM/Subarch type

Build problems with APM/Subarch type

[Raj]

I have been trying to build a 2.6.9-rc4. My box is an Intel P4.

Did all the configuration properly, except that i fumbled on the keyboard and
the option 'Subarchitecture Type' somehow got set to
'(SGI 320/540 Visual Workstation)'.

The build failed with an error 'Undefined reference to machine_real_restart'

It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) , 
CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
compiled.

( yeah, i know messing around with configs is suicidal, but.... )

Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??
-- 
######
raj
######

Re: Build problems with APM/Subarch type

[Randy.Dunlap]

Raj wrote:
> I have been trying to build a 2.6.9-rc4. My box is an Intel P4.
> 
> Did all the configuration properly, except that i fumbled on the keyboard and
> the option 'Subarchitecture Type' somehow got set to
> '(SGI 320/540 Visual Workstation)'.

Using an editor or make *config?  which *config?

> The build failed with an error 'Undefined reference to machine_real_restart'

Yep, I see that also.

> It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) , 
> CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
> compiled.
> 
> ( yeah, i know messing around with configs is suicidal, but.... )
> 
> Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??

Do you/we/maintainer know that APM is not applicable to all of the
other PC sub-arches?

I agree that it should be fixed, one way or another.
-- 
~Randy

Re: Build problems with APM/Subarch type

[Ricky lloyd]

> > Did all the configuration properly, except that i fumbled on the keyboard and
> > the option 'Subarchitecture Type' somehow got set to
> > '(SGI 320/540 Visual Workstation)'.
> 
> Using an editor or make *config?  which *config?

make menuconfig.

> 
> > The build failed with an error 'Undefined reference to machine_real_restart'
> 
> Yep, I see that also.
> 
> > It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
> > CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
> > compiled.
> >
> > ( yeah, i know messing around with configs is suicidal, but.... )
> >
> > Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??
> 
> Do you/we/maintainer know that APM is not applicable to all of the
> other PC sub-arches?
> 
afaics, i found 'apm.c' only in arch/i386/kernel and arch/arm/kernel.
does that really
confirm that apm would not be applicable for other archs ?? 

> I agree that it should be fixed, one way or another.
> --
> ~Randy
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


-- 
-> Ricky

Re: Build problems with APM/Subarch type

[Randy.Dunlap]

Ricky lloyd wrote:
>>>Did all the configuration properly, except that i fumbled on the keyboard and
>>>the option 'Subarchitecture Type' somehow got set to
>>>'(SGI 320/540 Visual Workstation)'.
>>
>>Using an editor or make *config?  which *config?
> 
> 
> make menuconfig.
> 
> 
>>>The build failed with an error 'Undefined reference to machine_real_restart'
>>
>>Yep, I see that also.
>>
>>
>>>It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
>>>CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
>>>compiled.
>>>
>>>( yeah, i know messing around with configs is suicidal, but.... )
>>>
>>>Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??
>>
>>Do you/we/maintainer know that APM is not applicable to all of the
>>other PC sub-arches?
>>
> 
> afaics, i found 'apm.c' only in arch/i386/kernel and arch/arm/kernel.
> does that really
> confirm that apm would not be applicable for other archs ?? 

The question is actually about other PC sub-arches, not other (Big)
arch-es.

> 
>>I agree that it should be fixed, one way or another.
>>--


-- 
~Randy

Re: Build problems with APM/Subarch type

[Raj]

> Using an editor or make *config?  which *config?
> 
xconfig

> > The build failed with an error 'Undefined reference to machine_real_restart'
> 
> Yep, I see that also.
> 
> > It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
> > CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
> > compiled.
> >
> > ( yeah, i know messing around with configs is suicidal, but.... )
> >
> > Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??
> 
> Do you/we/maintainer know that APM is not applicable to all of the
> other PC sub-arches?
> 
> I agree that it should be fixed, one way or another.

i am not aware much about the apm dependencies. maintainers might answer 
this more correctly. 

-- 
######
raj
######

Re: Build problems with APM/Subarch type

[Randy.Dunlap]

Raj wrote:
>>Using an editor or make *config?  which *config?
>>
> 
> xconfig
> 
> 
>>>The build failed with an error 'Undefined reference to machine_real_restart'
>>
>>Yep, I see that also.
>>
>>
>>>It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
>>>CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
>>>compiled.
>>>
>>>( yeah, i know messing around with configs is suicidal, but.... )
>>>
>>>Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??
>>
>>Do you/we/maintainer know that APM is not applicable to all of the
>>other PC sub-arches?
>>
>>I agree that it should be fixed, one way or another.
> 
> 
> i am not aware much about the apm dependencies. maintainers might answer 
> this more correctly. 

True.  I should have copied Andrey on it earlier.

Andrey, any thoughts about how to keep VISWS from building APM
support?  use Kconfig?  or does VISWS support APM?

-- 
~Randy

Re: Build problems with APM/Subarch type

[Andrey Panin]

> Raj wrote:
>>>Using an editor or make *config?  which *config?
>>>
>>
>> xconfig
>>
>>
>>>>The build failed with an error 'Undefined reference to
>>>> machine_real_restart'
>>>
>>>Yep, I see that also.
>>>
>>>
>>>>It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
>>>>CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not
>>>> be
>>>>compiled.
>>>>
>>>>( yeah, i know messing around with configs is suicidal, but.... )
>>>>
>>>>Can this be fixed ?? At the very least, hide APM options #if
>>>> !(CONFIG_PC) ??
>>>
>>>Do you/we/maintainer know that APM is not applicable to all of the
>>>other PC sub-arches?
>>>
>>>I agree that it should be fixed, one way or another.
>>
>>
>> i am not aware much about the apm dependencies. maintainers might answer
>> this more correctly.
>
> True.  I should have copied Andrey on it earlier.
>
> Andrey, any thoughts about how to keep VISWS from building APM
> support?  use Kconfig?  or does VISWS support APM?

IMHO Kconfig is the best choise. VISWS has no PC compatible BIOS at all,
it uses ARC compilant firmware for startup and configuration. Even though
this firmware does limited BIOS emulation for running ROMs on PCI cards, i
dont think it has working APM BIOS implementation.

[PATCH] VISWS: disable APM

[Randy.Dunlap]

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

(full email thread here:
   http://marc.theaimsgroup.com/?t=109758139300007&r=1&w=2
)

Andrey Panin wrote:
>>Raj wrote:
>>
>>>>>The build failed with an error 'Undefined reference to
>>>>>machine_real_restart'
>>>>
>>>>Yep, I see that also.
>>>>
>>>>>Can this be fixed ?? At the very least, hide APM options #if
>>>>>!(CONFIG_PC) ??
>>>>
>>>i am not aware much about the apm dependencies. maintainers might answer
>>>this more correctly.
>>
>>True.  I should have copied Andrey on it earlier.
>>
>>Andrey, any thoughts about how to keep VISWS from building APM
>>support?  use Kconfig?  or does VISWS support APM?
>
> IMHO Kconfig is the best choise. VISWS has no PC compatible BIOS at all,
> it uses ARC compilant firmware for startup and configuration. Even though
> this firmware does limited BIOS emulation for running ROMs on PCI cards, i
> dont think it has working APM BIOS implementation.

Raj, can you test this patch?  It WorksForMe.

It disables APM & P4THERMAL support for X86_VISWS so that VISWS
builds correctly.

-- 
~Randy

[-- Attachment #2: visws_noapm.patch --]
[-- Type: text/x-patch, Size: 1069 bytes --]


Prevent X86_VISWS config from building APM support.
APM isn't supported and it won't build if attempted.
Also disable P4THERMAL for VISWS.

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>


diffstat:=
 arch/i386/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -Naurp ./arch/i386/Kconfig~visws_noapm ./arch/i386/Kconfig
--- ./arch/i386/Kconfig~visws_noapm	2004-10-11 10:54:31.019559744 -0700
+++ ./arch/i386/Kconfig	2004-10-14 09:52:24.131743344 -0700
@@ -584,7 +584,7 @@ config X86_MCE_NONFATAL
 
 config X86_MCE_P4THERMAL
 	bool "check for P4 thermal throttling interrupt."
-	depends on X86_MCE && (X86_UP_APIC || SMP)
+	depends on X86_MCE && (X86_UP_APIC || SMP) && !X86_VISWS
 	help
 	  Enabling this feature will cause a message to be printed when the P4
 	  enters thermal throttling.
@@ -879,7 +879,7 @@ source kernel/power/Kconfig
 source "drivers/acpi/Kconfig"
 
 menu "APM (Advanced Power Management) BIOS Support"
-depends on PM
+depends on PM && !X86_VISWS
 
 config APM
 	tristate "APM (Advanced Power Management) BIOS support"