From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712381A23B9 for ; Tue, 25 Nov 2025 21:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764107764; cv=none; b=RCXBmizl3aFR/aZJz02JZmQGpjr/KhnG088CB+GI36KRIcokfzD5+HL4Sb5Pdpjs7ov/scaO8bRKKkRXrVZ/CI2oDzW92Iv2FErzjfBXzdkJ3fEtIeMP5I6wh4Jb+uW9kL/22uuuXws13qFG08mLkEoCc9JF7bqpRUg+tJFPLTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764107764; c=relaxed/simple; bh=3e0+dzaDLsHKg0U0f54rCzv32i0Sku0SQFUhjdfSvwA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iswvJR9mPTUXlDwnEuoR5265ZvxhjjWUw64XaajVQ2aM6MT8zHaPNHqxK69jaV+v2a8e6s9OO3ru6sreJSwgXvuaSOupZydvHf3EuU1LFnaWOx6ebgmyBN4LFV4I0ekHzpM1NiXN6sQUxuLw3VaE+/LC7JgPCRhkuR4fhj08DHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CBmGw98v; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=mU7CCRHK; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CBmGw98v"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="mU7CCRHK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764107761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aSxcDzgKkecVBpQbNcgBBZPZjsuHh8zneuXN2m7PNc4=; b=CBmGw98ve2VLhRN3iKTpFKEK1UKmrFCfPLGONn0WV8NlMWeccRnOxWrcp8Cp9yAuMgsEb0 StjXaDUwP6Ntxpjt3sZLd/HkLbrYIT6kN5oDSThGAVpeDZr3ANvdoToRdClupB9pK1qD2L CzDFZpTDJONNkkgoLW8NY2RecR+64SQ= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-kiGV1ebtMXeW8P5D6P9rJw-1; Tue, 25 Nov 2025 16:55:59 -0500 X-MC-Unique: kiGV1ebtMXeW8P5D6P9rJw-1 X-Mimecast-MFC-AGG-ID: kiGV1ebtMXeW8P5D6P9rJw_1764107759 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b17194d321so771394585a.0 for ; Tue, 25 Nov 2025 13:55:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764107759; x=1764712559; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aSxcDzgKkecVBpQbNcgBBZPZjsuHh8zneuXN2m7PNc4=; b=mU7CCRHK6gXOpKhLjiV3Hm3i85rgbh0IMjWsUImBNo6EM/0YDTVUBVxjcR5T21O4z1 2qDfLZqyYNn9du4+To5bYaMfmEJaFFLy38X5U4bBbAyEp9p9znuTgfey1Bs7+G4iN1x7 M+NoPvztSgPWR6m458LvtwDOsSnzbwnq85ydG0jVWTzAqhzuq0H7uAQ05BDt4lwgtROB 3rlElmJMksz3btHQNMPLy3wVyDjPb0biz9WaBdnwGVEqTEJj9kDT+qVn+dY0wedSefkh VdZEIQ4V0N49z1O8Y9uy8Srxd+OUScXY3XmqjnNOmPDG61Yp5E8PEyBYAJBH48qNVKzu e0kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764107759; x=1764712559; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aSxcDzgKkecVBpQbNcgBBZPZjsuHh8zneuXN2m7PNc4=; b=T5h2YNn2sPMtlh88w5hPcNLE2HydLLaosSvjrX4+SlWhrm1c6EKG1KdrhxysNDS9Hc AFfSbM9EeEri0qRoquHkPBVuAGQHbQc5kcWtmaf1IXh5zpeM/QaHpv7AkGTWculul1Km G73xYeWZLBmETHUiFVZiXqt2pWNHWDfZS5hvlKD2zlv/Vf1Cvc+VuLteCDapz0U4Fgda NppSb8S0xYKw+7b/uxVdKvKoCFvLepIQMJmQhkiT/FF4MiYepf8/0arA6P93Ge6A0Tu7 mLYksKNN51/Bn6fEP9wDRZhB51+ShHIAadhzoZ4oMwY4NIqxTCcqa9vyZEbJv9VJiU82 R8qw== X-Forwarded-Encrypted: i=1; AJvYcCVPWtYYnIBQFvuaKTnna61pg2vc+Ztfk5My6mBOGvo+8Pc0hM9NySdUJHewxF9+RwPT7ss2KO8HZ8QDH3Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxUNj5+K44Kolp9al8vVBK+2dSORgVtIcVWAadpq65scZLFUbK4 xsGGtYvUKyCF9c7hzfl3IDkFmtzIoh+meariW1wTrkLKIgWx7dkqw0omwVJU1ROyqTGIVIoI5Bq 74REPG9B5bXieJbPRVxsGyqrunjP/TI1++6wxB/Vud4yyG8Wq5RMr3mvMDJN8ci73iQ== X-Gm-Gg: ASbGncthqmAsU6tO4V/h20D3RgH08Gp6/gEa3eSZyoo9/dF4GUFoT6RXXaOMUeIYRmu G14SR+cO47Qu0mhpm3PKW4JZmXB5nbXM6n54W9n8yTtqIXaozkP7tSF0leCYzm8G9Ob0YpmfoDj FFfSYgi5HhqyFPJZaXCJaCb5bFCwf8ERXdQdvOhC/jxte2awduh2gsDveqHRcbZ0zRkNdHlmCd+ NTJBGXmeFWwlsrtDL0gSZDb+z1WvpFPTcS3eiFE1BewvJeECa07sLnePQc9Y1TrQ/kLveKtQ6VH IjDCbIGCdCKXj7ggP4UJmWIgROLupdu/mDHYLogdJ0JCpopOJydqVToYi6MHQbHkMovISygsXKy 7p1Z55CUBxg== X-Received: by 2002:a05:620a:4110:b0:8b2:ec5c:20bf with SMTP id af79cd13be357-8b4ebd5221emr603709085a.29.1764107758798; Tue, 25 Nov 2025 13:55:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNUiVdPADZLhEqiePWHHzDj+dyXpF+3u+pyWxwS7qaHE30wD9qtNmaFS/cc5pZdY4OGMrocQ== X-Received: by 2002:a05:620a:4110:b0:8b2:ec5c:20bf with SMTP id af79cd13be357-8b4ebd5221emr603707185a.29.1764107758381; Tue, 25 Nov 2025 13:55:58 -0800 (PST) Received: from [10.26.1.94] ([66.187.232.136]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b3295c17c7sm1265864785a.32.2025.11.25.13.55.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Nov 2025 13:55:57 -0800 (PST) Message-ID: Date: Tue, 25 Nov 2025 16:55:57 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] tools/power turbostat: allow turbostat to work when aperf is not available To: Len Brown Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251118155813.533424-1-darcari@redhat.com> <20251118155813.533424-4-darcari@redhat.com> Content-Language: en-US From: David Arcari In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/25/25 2:14 PM, Len Brown wrote: > It would be helpful if you could describe exactly what environment you > are running in. It' a VMWARE instance. CPUID(0): AuthenticAMD 0xd CPUID levels CPUID(1): family:model:stepping 0x17:0:0 (23:0:0) microcode 0x0 CPUID(0x80000000): max_extended_levels: 0x8000001f CPUID(1): SSE3 - - - - TSC MSR - - - CPUID(6): No-APERF, No-TURBO, No-DTS, No-PTM, No-HWP, No-HWPnotify, No-HWPwindow, No-HWPepp, No-HWPpkg, No-EPB CPUID(7): No-SGX No-Hybrid > > are there any MSRs? I'm not certain, is there something in particular you are looking for? > Is APERF available via perf, but not via MSR? > etc. I don't believe that APERF was available via perf. I'll go back and verify when I have a chance. -DA > > On Tue, Nov 18, 2025 at 10:58 AM David Arcari wrote: >> >> Currently when aperf is not available the function has_amperf() still >> returns true. The end result is that the program gets an error in >> delta_thread() which causes turbostat to restart. We can avoid this >> by not setting msr_counter_arch_infos[MSR_ARCH_INFO_APERF_INDEX].present >> when aperf is not available allowing turbostat to execute normally. >> >> Signed-off-by: David Arcari >> Cc: Len Brown >> Cc: linux-kernel@vger.kernel.org >> --- >> tools/power/x86/turbostat/turbostat.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c >> index 5567b9ecd516..b3f1e4ae5813 100644 >> --- a/tools/power/x86/turbostat/turbostat.c >> +++ b/tools/power/x86/turbostat/turbostat.c >> @@ -8592,6 +8592,10 @@ void msr_perf_init_(void) >> continue; >> >> if (cai->needed) { >> + /* check to see if APERF is available */ >> + if (cidx == MSR_ARCH_INFO_APERF_INDEX && !has_aperf) >> + continue; >> + >> /* Use perf API for this counter */ >> if (add_msr_perf_counter(cpu, cci, cai) != -1) { >> cci->source[cai->rci_index] = COUNTER_SOURCE_PERF; >> -- >> 2.51.0 >> >> > >