From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E94717BEBF for ; Sun, 9 Aug 2026 14:35:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786286145; cv=none; b=gcVwQgVPmV8WsW7O4xiS1uCFCpc01VYlG8EHq/0gCWdrT8QVmE+LDAedHFPr9mVG6wv7EIicX8fC7ilvLL/Mik9xkYo3iV7HPUv1flf90kEiWr9P9oZ+zWvVlMrlSIMRZ+90sG0t24teVpB47ivQsPA4eOpCLeRi8Mi7VFmzoSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786286145; c=relaxed/simple; bh=EwBznaVXv/GonOL8yX+GQ9+QJSwI8u4LrGtx5Fikk/4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=JtIkXFYoONSApyP4NaNFwlBGwzO0fOzzLh/HLKI5cjk/oWPnkrVEiohEd4LzO7gOfdug+sQFF5bvt3t5czHRN70UCoEOklwsch7Sy0EIdZUy6xC35RhCLvAwctq1u2tCN+fwNZHZa3Ziu+SKY6paMVVAldxbrAJaTN6MmS22twc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m5InN8qZ; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m5InN8qZ" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-480033bdcf4so484432f8f.2 for ; Sun, 09 Aug 2026 07:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786286142; x=1786890942; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=YYlAKIWzs1TvfB7xQgCTpmyRtf3Bl9uF5fd7z3Y9sBw=; b=m5InN8qZczTNyLfNExFnEP21tb3SFRY1Tcv/onvOwS5M71l5Q29EJq8py92+sMYY0z yYanDQoRuUr43h6JiaMDc1K4z0EwYrx/3Ml8sm0Lnr6MxZoMHiwB+CyT+RP6TjzonnsG SJNX4AFgvmh1ZUeSv7/SnA09o1Vqh06RgQ7K+Fin2ysyfKntXYdb3TH/1evisfKCGqWf mVNyqUrjPBah/QVo86oFFlG/ntct8s5K6Af1BV7x54DDHprPrOKhMa3y5Kc4vXU8rxzB rh8jyM/4NR/rYKHOzJHJCMsC89qUaB+8tpb/Ybod4eYKzCH7M6hjTd/xj2+jtOqpO5O+ IoYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786286142; x=1786890942; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YYlAKIWzs1TvfB7xQgCTpmyRtf3Bl9uF5fd7z3Y9sBw=; b=k6xxRxBXUWJFro4mIqw447/5znhpkN0KtzUBJ6itz/Hm3kSckgomO/hmgAZzjxDUEm XEAsDeLBOjiyzL3DvReGgmEdGM7O8tFBSgdVFjJpWzd7wZ0IBQbmX3+xvryF2E7ui9Nt wtxSoYnVv5+WSfwL+NkmuBu3Du7nZUU2ULJHzBgxJ/yKcFOfztgF37Ao9yeBCUYxDBG7 sE4cDhIBPAPzHA8P5c0c/eNPsLyNm5hJMJpyZ34LyTTCji3ZsEicDP/ajGJCf5c9NfCb dhZ9/wLlZe4SOdHi+uWCVUKmwGKme/1Jqin3a1dV468x3OpVYBtmoLYENpDBxbaYfYII 5iKg== X-Forwarded-Encrypted: i=1; AHgh+RrMZyy6OQ+cpokvo2AB155opt7Ea5h7ik0fJ7aaokFgdyQVPlUBVDUlRLd9NdlLbVg6aLSxLE8cMsnY+ic=@vger.kernel.org X-Gm-Message-State: AOJu0Yzz3fPO6HWZlk8StTwnpyBFJCheCUcRzdC47du3LszL1/vRUJJL Dz7aFq92X2ALsXhR99MDJFRc+D/yLlGxYBNY67FCkhkraodTsfBj3Z1v X-Gm-Gg: AR+sD11im1yWajL2jLY7ZzulIn1n6MELb3W27zALrBtNoHZhlE+BdtbFbCjBTAcmuEe g6rN7WtKgaCao/w1qaRMh1EraS2OR4BLAKCfOd+EzrkQIkyof6ndXBi9s8JG0svB9lbZVhIzYyd FSp7plvBLEG8M9gAtG62xRS9cSuGSF+OZ2u5p/mu5TdDKcp2jN72mc02alqpos8IIT7Z3hGx/i4 FUf9rEZp+GKKaPJ7Oc0FkR0l3nYmEce309QQUMlgR7fmQoWj/wjsaxFXfHWLg7owwAjStPvBoNI pdy6eaa4l/BXit6DyqPMNTffz4vt6JDe2TJU4uShTRC9DHwfxN8PODhLmRYYHtqXUZqRV9maZ7Q gIlmsECMO49tNE1R77t+sq0In9dvNQ28IOucXsVrQ84GuxY0yHYz57OBMR8Ly1CMKeev40E9tvu vEecaVx6nhriqpNDrqLZ+XZRDx8igRth/Wn9pvPbRI4PNPYIhhaYeFzDQ53ncE6aABsw== X-Received: by 2002:a05:6000:29ce:b0:47f:93be:dabd with SMTP id ffacd0b85a97d-47fec634beemr38517831f8f.28.1786286142353; Sun, 09 Aug 2026 07:35:42 -0700 (PDT) Received: from [192.168.1.225] ([81.187.78.108]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480021f8f33sm27797833f8f.27.2026.08.09.07.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 07:35:42 -0700 (PDT) Message-ID: Subject: Re: [PATCH net] et131x: propagate EEPROM readiness errors From: "mark.einon@gmail.com" To: Avi Weiss Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michael Grzeschik , Kees Cook , Jacob Keller , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= "(The Capable Hub)" , Alan Cox , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 09 Aug 2026 15:35:41 +0100 In-Reply-To: <20260808194347.813242-1-thnkslprpt@gmail.com> References: <20260808194347.813242-1-thnkslprpt@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2026-08-08 at 22:43 +0300, Avi Weiss wrote: > eeprom_wait_ready() returns a negative error when the LBCIF status > cannot be read or the device does not become ready for some other > reason. >=20 > eeprom_write() propagates this error before starting a write, but > currently returns 0 when the same readiness check fails after the > write begins. >=20 > This behavior was introduced when the EEPROM code was refactored to > use Linux error-return conventions (from 0 =3D failure to 0 =3D success). >=20 > Return the error so callers do not treat a failed EEPROM write as > successful and the function contract is maintained. >=20 > Fixes: b802ce0c705f ("Staging: et131x: tidy eeprom code up") > Signed-off-by: Avi Weiss Good spot, thanks Avi. Acked-by: Mark Einon Mark. > --- > =C2=A0drivers/net/ethernet/agere/et131x.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ethernet/agere/et131x.c > b/drivers/net/ethernet/agere/et131x.c > index 1b465a167672..4b6a579e9c66 100644 > --- a/drivers/net/ethernet/agere/et131x.c > +++ b/drivers/net/ethernet/agere/et131x.c > @@ -567,7 +567,7 @@ static int eeprom_write(struct et131x_adapter > *adapter, u32 addr, u8 data) > =C2=A0 */ > =C2=A0 err =3D eeprom_wait_ready(pdev, &status); > =C2=A0 if (err < 0) > - return 0; > + return err; > =C2=A0 > =C2=A0 /* Check bit 3 of the LBCIF Status Register.=C2=A0 If=C2=A0 > equal to 1, > =C2=A0 * an error has occurred.Don't break here if we are > revision >=20 > base-commit: dd057113ac7ba5bdd2aed3d9405305911152f911