From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D5921E1DFE for ; Wed, 26 Mar 2025 13:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742995028; cv=none; b=YVJLiVoTCTimqcmt/YuWkIqr8FrHXnWr/cCSyDXJrTc1F5OCQ1JEXjcBO9//NpMfKBs3lbz6TtFN1jFhkCFkNxt/F0blpWanYrTpUK+IzOrMMtC6MYwFncgcd9F53vUvBLkuHAPz6Plndh8kTXiaKmy94JHUyqe55bRnIV3JC+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742995028; c=relaxed/simple; bh=PlpLHMfHugWlyvKNdNjrSPwA2fM3W7l6yatfEAvFyzE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OkgLaPDot9CRuyZVRLCYymOJ2BrMvO40PlZqa+TBKubWstcFlUOH+gOY02qLSivwxhA8UOkT/r8CuBBGiARobGhRPMDhCGYujZ5S7jHdF5ud3j2Kt7iSe1o9TkWIpEih2AIXYmKvo9S+yLWdTj9eiyyrapOyGBwLGctikmSvibo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SAkJfa8J; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SAkJfa8J" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52QA1kUd025399 for ; Wed, 26 Mar 2025 13:17:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OSWNGu5ysI/ZrwWG3IadgQt1ZqUFERWo1HxXteYiRbc=; b=SAkJfa8JuX+DNtj9 aR1o3nDU52THt+xRPiVBJexltNqEQQUijtXVy44OrctV9wUA9aukpqJGsXXe+zJR UMmBpSNlbOJn/nU7eDzIWZDZNR+5VkY7AIeZ+ZTbAeQWGviadIT8gLzpM1ut1+8O M8pRiZiErAdwhtiZNCS2+wZdCRg2fZjqR4VyZiRSkRcDfOJf7RArA2hexpNTCljp 5FlrMWZOjZa0sHwSuGfhUknALabDD7cBYu4KrqmUmw2YqwrI1OATJZ4qErwxjIHl FTm4pNuw74nmhY48W+z3aVkYb6gEjcsd1ZuQYR9c0AqVQL8j12nGJmVM9ZWmbeC+ Ek25Vw== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45mffcghmn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 26 Mar 2025 13:17:05 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6e8fd4ef023so12400916d6.2 for ; Wed, 26 Mar 2025 06:17:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742995024; x=1743599824; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OSWNGu5ysI/ZrwWG3IadgQt1ZqUFERWo1HxXteYiRbc=; b=j54SN6FWLpqKtaLf2CkRSU1paieUo4FdVtCJTbZ3PA6nTmtLmgdlBRaUCg2i9sbRsW R9HAMexpd2+JLWxddI6EC1J3X1stKDUfBuzEKd9ljo38ZHS4xcFeovBzBEWMle9ULPix /hPRg9xiYvd5Lfg10zpBSYX4/UBNDdjLA4EFSXWbgCENpoLJrShuoGs1mmHez6JfNPAc MT6L3C4d3MOivuIc2A3SjH3nV6y84/IemwzX4CXltrzOq8ItGCFqntP/0+u7veDSPCyG zbaY/i6f7PX0G4yxOPH2jX4anWS6732HURDLJ6ro7ZxWbLtllRuU6BDl+M7gYHziUf4a fIBQ== X-Forwarded-Encrypted: i=1; AJvYcCUbtquqfkY4FMV9c0/M5RdWirSmFotOBrc7E+zQDoFtJsHEK3vpaiLcWgwISznjvJC4dMYgR6IKYipk3NE=@vger.kernel.org X-Gm-Message-State: AOJu0Yzwl2ftWwyHWV3wXCjL6NwHR6CvKExrcfMfndxqY5dteiLEdnYY zg6SY0d3KE+BwFL8VvxcVXad63Guu8eR4ekPZXu1OHbdp0ad7pnIHFK0SCPWWm+4sDDw8kMHnBa 9aPziLrc6DVamgpVnafoPgjZDT4qMx3+WYdi/X9dblYqRcugUFWmb1Lgduvz2gwc= X-Gm-Gg: ASbGncu/LkAizBEu7XM16KocTyVzXGtp7IUsUVCZqrI0HxmwRi2HuRhkrfq3XFJ9dS8 s3XyDIvehFZBrWOyfy2gHTQFOde5qvLTIh54V3NdCwIR/6xkaA7sAhh18ss3gz6OAvrz8T34PN8 uzap99RllZfiBvSf2a64pkmQaHFdFmL995W2wndvu9+zF2qOFf3xdnJt1fJnuRWe5qrgka/NjK6 YwJcnKnbrMl8cPeUdiuzAl8bwfwOLgiVcYsHt7sNdTdcfGEHMIhD/IWRWZMidae2Rh7bnfOpqVJ +9HMR6Bq+EUBN5VAl5xt/HaIIMtVKS2J9Jm01CSFgj2AUJ+lMRroNI/p4jV9Fnjh1gabVg== X-Received: by 2002:a05:620a:d8a:b0:7c5:9ab7:3012 with SMTP id af79cd13be357-7c5ba1f1008mr1014047985a.11.1742995024168; Wed, 26 Mar 2025 06:17:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGEWk+3aH6NV32r5YxqB7ELx5oUnVppF66A+EP9/TIjpwwijOlbyXw3XzCIrY9S6UeSPK/mWQ== X-Received: by 2002:a05:620a:d8a:b0:7c5:9ab7:3012 with SMTP id af79cd13be357-7c5ba1f1008mr1014046685a.11.1742995023623; Wed, 26 Mar 2025 06:17:03 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ebccfaecfbsm9373513a12.41.2025.03.26.06.17.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Mar 2025 06:17:03 -0700 (PDT) Message-ID: Date: Wed, 26 Mar 2025 14:17:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/5] Add snps,dis_u3_susphy_quirk for some QC targets To: Bjorn Andersson , Konrad Dybcio Cc: Prashanth K , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> <7029a455-47be-475d-b429-98031d227653@oss.qualcomm.com> <5k45tcntn2bhxqt35quzfm2dsq6eug3hgqdcrta25oy47zuqja@4jclvspwob5x> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5k45tcntn2bhxqt35quzfm2dsq6eug3hgqdcrta25oy47zuqja@4jclvspwob5x> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=CdgI5Krl c=1 sm=1 tr=0 ts=67e3fe51 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=xMnwRdS-aKneeMBeM7YA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: 4XhmwF0gABlV5q2dAWk8iguWdmHm4EdN X-Proofpoint-ORIG-GUID: 4XhmwF0gABlV5q2dAWk8iguWdmHm4EdN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-26_06,2025-03-26_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 phishscore=0 clxscore=1015 bulkscore=0 impostorscore=0 adultscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503260081 On 3/25/25 11:10 PM, Bjorn Andersson wrote: > On Tue, Mar 25, 2025 at 05:31:28PM +0100, Konrad Dybcio wrote: >> On 3/25/25 4:01 PM, Prashanth K wrote: >>> >>> >>> On 25-03-25 08:11 pm, Konrad Dybcio wrote: >>>> On 3/25/25 1:30 PM, Prashanth K wrote: >>>>> During device mode initialization on certain QC targets, before the >>>>> runstop bit is set, sometimes it's observed that the GEVNTADR{LO/HI} >>>>> register write fails. As a result, GEVTADDR registers are still 0x0. >>>>> Upon setting runstop bit, DWC3 controller attempts to write the new >>>>> events to address 0x0, causing an SMMU fault and system crash. More >>>>> info about the crash at [1]. >>>>> >>>>> This was initially observed on SM8450 and later reported on few >>>>> other targets as well. As suggested by Qualcomm HW team, clearing >>>>> the GUSB3PIPECTL.SUSPHY bit resolves the issue by preventing register >>>>> write failures. Address this by setting the snps,dis_u3_susphy_quirk >>>>> to keep the GUSB3PIPECTL.SUSPHY bit cleared. This change was tested >>>>> on multiple targets (SM8350, SM8450 QCS615 etc.) for over an year >>>>> and hasn't exhibited any side effects. >>>>> >>>>> [1]: https://lore.kernel.org/all/fa94cbc9-e637-ba9b-8ec8-67c6955eca98@quicinc.com/ >>>>> >>>>> Prashanth K (3): >>>>> arm64: dts: qcom: sm8150: Add snps,dis_u3_susphy_quirk >>>>> arm64: dts: qcom: sm8350: Add snps,dis_u3_susphy_quirk >>>>> arm64: dts: qcom: sm8450: Add snps,dis_u3_susphy_quirk >>>>> >>>>> Pratham Pratap (2): >>>>> arm64: dts: qcom: qcs615: Add snps,dis_u3_susphy_quirk >>>>> arm64: dts: qcom: qdu1000: Add snps,dis_u3_susphy_quirk >>>> >>>> Are there more targets affected, from the list of the ones currently >>>> supported upstream? >>>> >>>> Konrad >>> >>> My initial plan was to add it for all the QC platforms, but wasn't >>> confident enough about it. Because we have seen the issue only on these >>> targets and hence tested only on these. >> >> Okay, let's proceed with these and in the meantime please query internally >> whether it could be applicable to others too >> > > But if it applies to all qcom targets, wouldn't it make more sense to > add the property in the qcom glue driver? If we did that and the issue was ever fixed in future hw, we'd have to either re-add this patchset again or invent a snps,*en*_u3_susphy_quirk Konrad