From: Ricky WU <ricky_wu@realtek.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"frank.li@vivo.com" <frank.li@vivo.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: RE: [PATCH v3 1/2] misc: rtsx: add to support new card reader rts5264
Date: Mon, 23 Oct 2023 03:31:24 +0000 [thread overview]
Message-ID: <b31f74462ce240a18652643224e285dd@realtek.com> (raw)
In-Reply-To: <2023102153-paramedic-washboard-29e3@gregkh>
> > In order to support new chip rts5264, the definitions of some internal
> > registers and workflow have to be modified.
>
> That is fine, but that should be a single patch, right?
>
Sorry maybe about misunderstand, The modifications mentioned here, it talk about
some judgment expressions add "PID 5264" to make judgement in rtsx_pcr.c,
so only about 30 line modified in rtsx_pcr.c
> > Added rts5264.c rts5264.h for independent functions of the new chip rts5264
>
> And then add new support in a new patch, this is still too big as one
> patch to attempt to review it properly. Would you like to review this
> as-is?
>
Yes, thank you
Because rts5264.c rts5264.h only for rts5264 (new chip).
The past architecture of this driver was like this, and it will good for us to maintain the driver
different chip maybe has different functions and register definitions we used to separate different .c .h
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-10-23 3:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 8:13 [PATCH v3 1/2] misc: rtsx: add to support new card reader rts5264 Ricky WU
2023-10-21 20:57 ` gregkh
2023-10-23 3:31 ` Ricky WU [this message]
2023-10-25 10:39 ` gregkh
2023-10-27 8:25 ` Ricky WU
2023-10-27 8:44 ` gregkh
-- strict thread matches above, loose matches on Subject: below --
2023-10-19 3:08 Ricky WU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b31f74462ce240a18652643224e285dd@realtek.com \
--to=ricky_wu@realtek.com \
--cc=arnd@arndb.de \
--cc=frank.li@vivo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox