Re: [PATCH net-next v2] net: ti: icssg_prueth: add TAPRIO offload support

MD Danish Anwar
2023-09-28T10:16:28Z

On 21/09/23 16:12, Roger Quadros wrote:
> Hi Danish,
>
> On 21/09/2023 10:00, MD Danish Anwar wrote:
>
> Can you please retain patch authorhsip?
>
>> ICSSG dual-emac f/w supports Enhanced Scheduled Traffic (EST – defined
>> in P802.1Qbv/D2.2 that later got included in IEEE 802.1Q-2018)
>> configuration. EST allows express queue traffic to be scheduled
>> (placed) on the wire at specific repeatable time intervals. In
>> Linux kernel, EST configuration is done through tc command and
>> the taprio scheduler in the net core implements a software only
>> scheduler (SCH_TAPRIO). If the NIC is capable of EST configuration,
>> user indicate "flag 2" in the command which is then parsed by
>> taprio scheduler in net core and indicate that the command is to
>> be offloaded to h/w. taprio then offloads the command to the
>> driver by calling ndo_setup_tc() ndo ops. This patch implements
>> ndo_setup_tc() to offload EST configuration to ICSSG.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---

[ ... ]

>> + if (!netif_running(ndev)) {
>> + netdev_err(ndev, "interface is down, link speed unknown\n");
>> + return -ENETDOWN;
>> + }
>
> Do we really need this?

I don't think this is needed. I will drop this and spin next revision.

--
Thanks and Regards,
Danish