From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933748AbcIPLQq (ORCPT ); Fri, 16 Sep 2016 07:16:46 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:47562 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752619AbcIPLQh (ORCPT ); Fri, 16 Sep 2016 07:16:37 -0400 X-AuditID: cbfec7ef-f79e76d000005b57-03-57dbd492d691 Subject: Re: [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440 devices To: Sam Van Den Berge , vinod.koul@intel.com, dmaengine@vger.kernel.org Cc: kgene@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: Date: Fri, 16 Sep 2016 13:16:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1473968506-4150-1-git-send-email-sam.van.den.berge@telenet.be> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsWy7djPc7qTrtwON/j+UcJi9dS/rBavXxha 9D9+zWyx6fE1VovLu+awWcw4v4/JYvWK9cwWL/v2szhweCze85LJY9OqTjaPzUvqPfq2rGL0 2PnjOpvH501yAWxRXDYpqTmZZalF+nYJXBnbzu1kKvjOW3H55DXWBsbF3F2MnBwSAiYSi1t7 WSBsMYkL99azdTFycQgJLGOUmPznG5TzmVHi6buVjF2MHGAdB5bbwhVdOXCMFcJ5xigxZ9Nt JpBRwgLBEl+3PgAbKyKQLnF46nQwm1mgVmJzdwcbyCA2AW2Jf1uKITbLSfR2TwIr4RWwlTja +54NxGYRUJVo65zCClIuKhAhsftuKkSJoMSPyffAyjkFfCQ+9uxhhphuIDFjymEmCFteYvOa t8wgp0kIHGKX2Lm2lRniflmJTQeYIda6SCx/+5sVwhaWeHV8CzuELSPR2XEQag6fxKRt06Fa eSU62oQgSjwkGjZuYoOwHSV2vumEBtV8RonOy7tYJzDKzkJy6iwk581Cct4CRuZVjCKppcW5 6anFhnrFibnFpXnpesn5uZsYgani9L/j73cwPm0OOcQowMGoxMO7Yu6tcCHWxLLiytxDjBIc zEoivIsu3w4X4k1JrKxKLcqPLyrNSS0+xCjNwaIkzrt3wZVwIYH0xJLU7NTUgtQimCwTB6dU A+Pqq3uO1Syzrsvz3+Hbt+D74mlTP4guucqQtpTZb/GWjzwnF8f3aoZN2X3X3aFzjuuD6WqL rVul3qQtuu+snnjk1bnvV8r/bmLybapc+Umy2SOVM2vG/O1MT7YtKyrU6Oa33fWgMbEs6/7y xN3T1pe8c3zrlfWOm7X5w9lAgUP2x49XM6x8lxquxFKckWioxVxUnAgAnhmDBBEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEIsWRmVeSWpSXmKPExsVy+t/xy7qpV26HG1zYpGWxeupfVovXLwwt +h+/ZrbY9Pgaq8XlXXPYLGac38dksXrFemaLl337WRw4PBbvecnksWlVJ5vH5iX1Hn1bVjF6 7Pxxnc3j8ya5ALYoN5uM1MSU1CKF1Lzk/JTMvHRbpdAQN10LJYW8xNxUW6UIXd+QICWFssSc UiDPyAANODgHuAcr6dsluGVsO7eTqeA7b8Xlk9dYGxgXc3cxcnBICJhIHFhu28XICWSKSVy4 t56ti5GLQ0hgCaPEss+r2SGcZ4wS61fMZgOpEhYIlvi69QELiC0ikC6xcc07RoiihYwSb65P ZwRJMAvUSvTsfMUIsoFNQFvi35ZiiA1yEr3dk8B6eQVsJY72vgebySKgKtHWOYUVxBYViJC4 teojI0SNoMSPyffA6jkFfCQ+9uxhBhnJLKAncf+iFsQmeYnNa94yT2AUnIWkYxZC1SwkVQsY mVcxiqSWFuem5xYb6hUn5haX5qXrJefnbmIExt+2Yz8372C8tDH4EKMAB6MSD2/A7FvhQqyJ ZcWVuYcYJTiYlUR43567HS7Em5JYWZValB9fVJqTWnyI0RTohYnMUqLJ+cDUkFcSb2hiaG5p aGRsYWFuZKQkzlvy4Uq4kEB6YklqdmpqQWoRTB8TB6dUA6PyO8ECoZOfG2y0wqUM/G93aUz7 v1lpzdOqbWxxl8/ka9kskwrWOHvv5rdnexX+KmosP1O1/r2Yd+qBA6u3vr09ZZ7d5aTV17W/ H/d8sOgzj+i/jctWZGzre73nOyPrX2UHzfXf0vycOG5y3bnYf0dPOfD26am6t/KP1rEetPKq MpuZYz1f+OFhJZbijERDLeai4kQANLgTAdUCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160916111633eucas1p187d0b07f4c88f54aaa0ef4fb4d6f48b2 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160915194201eucas1p2961ce91633437ed68c5f61877a3f47c3 X-RootMTR: 20160915194201eucas1p2961ce91633437ed68c5f61877a3f47c3 References: <1473968506-4150-1-git-send-email-sam.van.den.berge@telenet.be> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/15/2016 09:41 PM, Sam Van Den Berge wrote: > This patch updates the s3c24xx dma driver to be able to pass a > dma_slave_map array via the platform data. This is needed to > be able to use the new, simpler dmaengine API [1]. > I used the virtual DMA channels as a parameter for the dma_filter > function. By doing that, I could reuse the existing filter function in > drivers/dma/s3c24xx-dma.c. > > I have tested this on my mini2440 board with the audio driver. > (I first applied the audio fixes from Sylwester Nawrocki [2]) > According to my observations, dma_request_slave_channel in the > function dmaengine_pcm_new in the file > sound/soc/soc-generic-dmaengine-pcm.c now returns a valid DMA channel > whereas before no DMA channel was returned at that point. > > Entries for DMACH_XD0, DMACH_XD1 and DMACH_TIMER are missing because I > don't realy know which driver to use for these. > > [1] > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/393635.html > [2] http://www.spinics.net/lists/arm-kernel/msg521918.html > > Signed-off-by: Sam Van Den Berge > Reviewed-by: Sylwester Nawrocki > Acked-by: Arnd Bergmann > > --- > > Changes since v1: > - rename arm into dmaengine in title > - one channel for s3c2440-sdi named "rx-tx" > > arch/arm/mach-s3c24xx/common.c | 35 +++++++++++++++++++++++++++++++ > drivers/dma/s3c24xx-dma.c | 3 +++ > include/linux/platform_data/dma-s3c24xx.h | 6 ++++++ > 3 files changed, 44 insertions(+) Vinod, do you want to take it through your tree? Not much difference for me, so in such case: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof