From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EEB3ECAAD8 for ; Wed, 21 Sep 2022 16:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231742AbiIUQfV (ORCPT ); Wed, 21 Sep 2022 12:35:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231573AbiIUQex (ORCPT ); Wed, 21 Sep 2022 12:34:53 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 368BCA8955 for ; Wed, 21 Sep 2022 09:17:10 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8480C1FC4; Wed, 21 Sep 2022 09:17:16 -0700 (PDT) Received: from [10.1.196.40] (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 373FB3F5A1; Wed, 21 Sep 2022 09:17:09 -0700 (PDT) Message-ID: Date: Wed, 21 Sep 2022 17:17:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/1] perf/arm-cmn: Add more bits to child node address offset field Content-Language: en-GB To: Ilkka Koskinen , Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@amperecomputing.com References: <20220808195455.79277-1-ilkka@os.amperecomputing.com> From: Robin Murphy In-Reply-To: <20220808195455.79277-1-ilkka@os.amperecomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2022 8:54 pm, Ilkka Koskinen wrote: > CMN-600 uses bits [27:0] for child node address offset while bits [30:28] > are required to be zero. > > For CMN-650, the child node address offset field has been increased > to include bits [29:0] while leaving only bit 30 set to zero. > > Let's include the missing two bits and assume older implementations > comply with the spec and set bits [29:28] to 0. Just to add that other users have run into this as well, so getting it applied as a fix would be just lovely. Technically I think it's: Fixes: 60d1504070c2 ("perf/arm-cmn: Support new IP features") Cheers, Robin. > Signed-off-by: Ilkka Koskinen > --- > > I have tested this patch on CMN-600 and CMN-650. > > drivers/perf/arm-cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > index 80d8309652a4..b80a9b74662b 100644 > --- a/drivers/perf/arm-cmn.c > +++ b/drivers/perf/arm-cmn.c > @@ -36,7 +36,7 @@ > #define CMN_CI_CHILD_COUNT GENMASK_ULL(15, 0) > #define CMN_CI_CHILD_PTR_OFFSET GENMASK_ULL(31, 16) > > -#define CMN_CHILD_NODE_ADDR GENMASK(27, 0) > +#define CMN_CHILD_NODE_ADDR GENMASK(29, 0) > #define CMN_CHILD_NODE_EXTERNAL BIT(31) > > #define CMN_MAX_DIMENSION 12