From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "Zhao, Yan Y" <yan.y.zhao@intel.com>
Cc: "Hansen, Dave" <dave.hansen@intel.com>,
"seanjc@google.com" <seanjc@google.com>,
"Huang, Kai" <kai.huang@intel.com>,
"kas@kernel.org" <kas@kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [PATCH 09/17] KVM: TDX: Add helper to handle mapping leaf SPTE into S-EPT
Date: Wed, 1 Apr 2026 23:59:38 +0000 [thread overview]
Message-ID: <b352ad09ee082b9d676febd0c28520ecd8f4e8cc.camel@intel.com> (raw)
In-Reply-To: <acobjplac2phLTKO@yzhao56-desk.sh.intel.com>
On Mon, 2026-03-30 at 14:43 +0800, Yan Zhao wrote:
> >
> > +static int tdx_sept_set_private_spte(struct kvm *kvm, gfn_t gfn,
> > + enum pg_level level, u64 mirror_spte)
> > +{
> >
> > + if (KVM_BUG_ON(!is_shadow_present_pte(mirror_spte), kvm))
> > + return -EIO;
> > +
> > + if (!is_last_spte(mirror_spte, level))
> > + return tdx_sept_link_private_spt(kvm, gfn, level,
> > mirror_spte);
> For symmetry, what about renaming tdx_sept_link_private_spt() to
> tdx_sept_map_nonleaf_spte()?
Yea, it fits better.
next prev parent reply other threads:[~2026-04-01 23:59 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260327201421.2824383-1-rick.p.edgecombe@intel.com>
[not found] ` <20260327201421.2824383-7-rick.p.edgecombe@intel.com>
2026-03-30 5:00 ` [PATCH 06/17] KVM: x86/tdp_mmu: Morph the !is_frozen_spte() check into a KVM_MMU_WARN_ON() Yan Zhao
2026-03-31 16:37 ` Edgecombe, Rick P
2026-04-02 1:06 ` Yan Zhao
2026-04-02 19:21 ` Sean Christopherson
2026-04-03 2:47 ` Yan Zhao
[not found] ` <20260327201421.2824383-8-rick.p.edgecombe@intel.com>
2026-03-30 6:14 ` [PATCH 07/17] KVM: x86/tdp_mmu: Centralize updates to present external PTEs Yan Zhao
2026-04-01 23:45 ` Edgecombe, Rick P
2026-04-02 1:59 ` Yan Zhao
2026-04-02 23:10 ` Edgecombe, Rick P
2026-04-02 23:28 ` Sean Christopherson
2026-04-03 9:05 ` Yan Zhao
2026-04-04 0:15 ` Edgecombe, Rick P
2026-04-03 9:08 ` Yan Zhao
2026-03-31 10:09 ` Huang, Kai
2026-04-01 23:58 ` Edgecombe, Rick P
2026-04-02 23:21 ` Sean Christopherson
2026-04-01 8:34 ` Yan Zhao
2026-04-02 23:46 ` Edgecombe, Rick P
2026-04-03 10:33 ` Yan Zhao
[not found] ` <20260327201421.2824383-9-rick.p.edgecombe@intel.com>
2026-03-30 6:28 ` [PATCH 08/17] KVM: TDX: Drop kvm_x86_ops.link_external_spt(), use .set_external_spte() for all Yan Zhao
[not found] ` <20260327201421.2824383-10-rick.p.edgecombe@intel.com>
2026-03-30 6:43 ` [PATCH 09/17] KVM: TDX: Add helper to handle mapping leaf SPTE into S-EPT Yan Zhao
2026-04-01 23:59 ` Edgecombe, Rick P [this message]
[not found] ` <20260327201421.2824383-15-rick.p.edgecombe@intel.com>
2026-03-30 7:01 ` [PATCH 14/17] KVM: x86/mmu: Remove KVM_BUG_ON() that checks lock when removing PTs Yan Zhao
2026-03-31 10:46 ` Huang, Kai
2026-04-02 0:08 ` Edgecombe, Rick P
2026-04-02 2:04 ` Yan Zhao
[not found] ` <20260327201421.2824383-3-rick.p.edgecombe@intel.com>
2026-03-31 9:47 ` [PATCH 02/17] KVM: x86/mmu: Update iter->old_spte if cmpxchg64 on mirror SPTE "fails" Huang, Kai
2026-03-31 9:17 ` Yan Zhao
2026-03-31 9:59 ` Huang, Kai
2026-03-31 9:22 ` Yan Zhao
2026-03-31 10:14 ` Huang, Kai
[not found] ` <20260327201421.2824383-11-rick.p.edgecombe@intel.com>
2026-03-31 10:30 ` [PATCH 10/17] KVM: TDX: Move set_external_spte_present() assert into TDX code Huang, Kai
2026-04-02 0:00 ` Edgecombe, Rick P
2026-03-31 10:34 ` Huang, Kai
[not found] ` <20260327201421.2824383-14-rick.p.edgecombe@intel.com>
2026-03-31 10:42 ` [PATCH 13/17] KVM: TDX: Hoist tdx_sept_remove_private_spte() above set_private_spte() Huang, Kai
2026-04-02 0:04 ` Edgecombe, Rick P
[not found] ` <20260327201421.2824383-18-rick.p.edgecombe@intel.com>
2026-03-30 7:49 ` [PATCH 17/17] KVM: TDX: Move external page table freeing to TDX code Yan Zhao
2026-04-02 0:17 ` Edgecombe, Rick P
2026-04-02 2:16 ` Yan Zhao
2026-04-02 2:17 ` Yan Zhao
2026-03-31 11:02 ` Huang, Kai
[not found] ` <20260327201421.2824383-12-rick.p.edgecombe@intel.com>
2026-03-31 10:36 ` [PATCH 11/17] KVM: x86/mmu: Fold set_external_spte_present() into its sole caller Huang, Kai
2026-04-01 7:41 ` Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b352ad09ee082b9d676febd0c28520ecd8f4e8cc.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=dave.hansen@intel.com \
--cc=kai.huang@intel.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=x86@kernel.org \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox