From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73939CA9EB0 for ; Mon, 21 Oct 2019 19:37:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 438A82084B for ; Mon, 21 Oct 2019 19:37:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="uhu8ADmf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730182AbfJUThR (ORCPT ); Mon, 21 Oct 2019 15:37:17 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:52432 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728819AbfJUThQ (ORCPT ); Mon, 21 Oct 2019 15:37:16 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x9LJbD3k071322; Mon, 21 Oct 2019 14:37:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1571686633; bh=ekjozCXAw6b8U4H+XTTsLy7p9fWE1plsq41QyKEnJfY=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=uhu8ADmfMLTbK8Fc1tT/Ngqs+VRtp8rNlCN5Ams4IzB3Y3pFN6889fKrb9CHCyVDf R4339oSBJY1z6u9uU3OgV6WYTzyH4+FuXiy3mjP7x6ZwxDYycBN+Wk6G9ZFb5b5GM0 mxshtNvpLpJjnbP2Lkg2iO7cb0etkQFYkQccJ+NU= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x9LJawLA051959 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Oct 2019 14:36:58 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 21 Oct 2019 14:36:57 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 21 Oct 2019 14:36:57 -0500 Received: from [10.250.35.43] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x9LJZuPo077548; Mon, 21 Oct 2019 14:35:57 -0500 Subject: Re: [PATCH 1/3] power_supply: Add additional health properties to the header To: Sebastian Reichel CC: , References: <20190930143137.21624-1-dmurphy@ti.com> <20191020122510.4llflz7s2kogcdbf@earth.universe> From: Dan Murphy Message-ID: Date: Mon, 21 Oct 2019 14:35:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191020122510.4llflz7s2kogcdbf@earth.universe> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian On 10/20/19 7:25 AM, Sebastian Reichel wrote: > Hi, > > On Mon, Sep 30, 2019 at 09:31:35AM -0500, Dan Murphy wrote: >> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum. > You used OVERHEAT instead of HOT in the implementation, > which makes sense to me, so please drop HOT here. Also > this needs to be documented in the ABI documentation: Hmm.  To me OVERHEAT and HOT can mean two different things.  I will check the implementation but I would prefer to use HOT. If a battery or charger is HOT that may be expected to be within the heat limits of the device being monitored but that it is hot. Overheating means the device is above the expected upper thermal limit.  Or over the heat limit. The user may want to take action within the hot range to cool the device or may expect the device to run hot without over heating. > Documentation/ABI/testing/sysfs-class-power ACK Dan