From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Jon Kohler <jon@nutanix.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] intel_idle: add CPUIDLE_FLAG_IRQ_ENABLE to SPR C1 and C1E
Date: Fri, 01 Jul 2022 16:30:07 +0300 [thread overview]
Message-ID: <b35cf10b03b441a95704648e816ff1acc150f38b.camel@linux.intel.com> (raw)
In-Reply-To: <20220630194309.40465-1-jon@nutanix.com>
Hi Jon,
On Thu, 2022-06-30 at 15:43 -0400, Jon Kohler wrote:
> Add CPUIDLE_FLAG_IRQ_ENABLE to spr_cstates C1 and C1E, which will
> allow local IRQs to be enabled during fast idle transitions on SPR.
Did you have a chance to measure this? When I was doing this for ICX and CLX, I
was using cyclictest and wult for measuring IRQ latency.
I was planning to do this for SPR as well.
> Note: Enabling this for both C1 and C1E is slightly different than
> the approach for SKX/ICX, where CPUIDLE_FLAG_IRQ_ENABLE is only
> enabled on C1; however, given that SPR target/exit latency is 1/1
> for c1 and 2/4 for C1E, respectively, which is slower than C1
> for SKX, it seems prudent to now enable it on both states.
I was also going to measure this for C1E.
Could we please hold on this a bit - I'd like to measure this before we merge
it.
Artem.
next prev parent reply other threads:[~2022-07-01 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 19:43 [PATCH] intel_idle: add CPUIDLE_FLAG_IRQ_ENABLE to SPR C1 and C1E Jon Kohler
2022-07-01 13:30 ` Artem Bityutskiy [this message]
2022-07-01 14:06 ` Jon Kohler
2023-11-10 20:00 ` Jon Kohler
2023-11-12 11:52 ` Artem Bityutskiy
2023-11-13 15:20 ` Jon Kohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b35cf10b03b441a95704648e816ff1acc150f38b.camel@linux.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jon@nutanix.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox